From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E843BC433F5 for ; Fri, 14 Jan 2022 06:48:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233481AbiANGsG (ORCPT ); Fri, 14 Jan 2022 01:48:06 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:59254 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229955AbiANGsD (ORCPT ); Fri, 14 Jan 2022 01:48:03 -0500 Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 90C1A402A4 for ; Fri, 14 Jan 2022 06:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642142881; bh=PKBAkmJ7or0T/bxHU0Wvyq29ugXtwBBaF+RK3mybysU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hDIiylRN/BhR3ijiiWn2wBFPyRwRb06nqYpmUx4C+aV6dTp5xI2nRrJGZ3n50E7O0 CbS1pO8x86DkqH4QUbPue5kg/sSXD9bqZpvAf6m2k82QB941iO2baagLssj9WarLQp KLMiSonoqyTJSWEY/X1fHx6nD9jrRmdvDsSCvcQA131JdAOjfBHyzZEDjO6GLgkrRv T4f0LMD1m9xLE6iEabDWROdRNcJxN7SJ1YiYOJpqX0/n+K9GaTyTVxQWEqYSQ/CYe/ G1NT0CiQdqFfO09vj0y7XGfVyJ8KK1+hN7FARhe5AJ5XMiXttlAht6j3CNnkTUH50B CeV74hekx6AnQ== Received: by mail-oi1-f198.google.com with SMTP id v72-20020acaac4b000000b002c8dd559f44so5452753oie.8 for ; Thu, 13 Jan 2022 22:48:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PKBAkmJ7or0T/bxHU0Wvyq29ugXtwBBaF+RK3mybysU=; b=IGmwkoJBKGfvGGlEi6o62XDZK6rBthDbbJl/Ud6ZnMqgFQUqkTZEErIxeClgrUKxFr 8v/cRmLAUVk8Cb8qiCulx268NDmRoPLh/DhXW964R7ZYYVGEGp15YrHbrR6XaSpsaRHN YGkqoxCVIn+m7Bsloa8lzj2/ERcZ9jDtBIyw4FNPMyz3HxJvNVaxrtvpIq7wtNkO7Cfu DALi3uuwmc7lDG58jShslhi0CtXlxwwR9VFpcK75+aSmr+lAWnN0dCJuxKHYyYs3WeP9 JU9tHlKPK7kvtoqona2+XdpjJhPyslTtQQn+/aE3W1xNQdfnE711eEB1KbO/7Ixc2A2X 8M1w== X-Gm-Message-State: AOAM530GLl+XvsqEUtoLnY5IRIzJEHsofUM65GOxsYZQGjVIExde1dsL Z28/YvV0BMvSulnNC23XGpBthoVg4rSiW/xVWywjojwHWNZzpvcCfyHpDI60OxK+CDE4iVPTGkQ g4YOwwEWjp3RRGlCWx7k/Lle+z0dxsWkzJ1cJ92+mClPUoEhvelxpjMeyjg== X-Received: by 2002:a05:6808:293:: with SMTP id z19mr10972604oic.41.1642142879353; Thu, 13 Jan 2022 22:47:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJye/IK1OGddDRHlpoRSRDwJDrr3evy3FfczWQgU60l1SslTO9lJxeMi9V5rBVY0jKXg6Ly5r0DmOwSH1F8j5i0= X-Received: by 2002:a05:6808:293:: with SMTP id z19mr10972566oic.41.1642142878837; Thu, 13 Jan 2022 22:47:58 -0800 (PST) MIME-Version: 1.0 References: <20220114040755.1314349-1-kai.heng.feng@canonical.com> <20220114040755.1314349-2-kai.heng.feng@canonical.com> <20220113203523.310e13d3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220113203523.310e13d3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> From: Kai-Heng Feng Date: Fri, 14 Jan 2022 14:47:47 +0800 Message-ID: Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware To: Jakub Kicinski Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, "David S. Miller" , Maxime Coquelin , Andrew Lunn , Heiner Kallweit , Russell King , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Ivan Bornyakov , =?UTF-8?Q?Pali_Roh=C3=A1r?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 14, 2022 at 12:35 PM Jakub Kicinski wrote: > > On Fri, 14 Jan 2022 12:07:54 +0800 Kai-Heng Feng wrote: > > BIOS on Dell Edge Gateway 3200 already makes its own phy LED setting, so > > instead of setting another value, keep it untouched and restore the saved > > value on system resume. > > > > Signed-off-by: Kai-Heng Feng > > I defer to PHY experts for review. Coincidentally the first Marvell > flag appears dead, nobody sets it: > > $ git grep MARVELL_PHY_M1145_FLAGS_RESISTANCE > drivers/net/phy/marvell.c: if (phydev->dev_flags & MARVELL_PHY_M1145_FLAGS_RESISTANCE) { > include/linux/marvell_phy.h:#define MARVELL_PHY_M1145_FLAGS_RESISTANCE 0x00000001 > $ > > unless it's read from DT under different name or something. It was introduced by 95d21ff4c645 without any user. Should we keep it? > > > Once you get some reviews please wait for net-next to open: > > http://vger.kernel.org/~davem/net-next.html > > and repost. It should happen the week of Jan 24th. When you repost > please drop the first patch, I believe Russell does not like the BIT() > macro, his opinion overrides checkpatch. Of course. I'll wait for the review and resubmit the 2nd patch. Kai-Heng > > Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 085B1C433F5 for ; Fri, 14 Jan 2022 06:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qVv0DYxDj7e3UpImT8orCciEQ0mgZfOnU7yxzQkVMxw=; b=v0wFrfQw5Kjr5j sX0J3A8OpzsOeQv6mRCngOJ/fK9pLe/g7sveC7/NvEQiZS4aifW229vUrhVl9Z9cf/wryjLqtZB80 Vr9ipg9TyUXQRYduAYfaGd757EPdJy4qVU1DyM9yienEe7eRcCDDyTqX4ypykdaDB14jbdUfwvmtr ods9vcEmN24iAkNLNq/irAVaP4O/bSwIdSQ4ayYu2OcahV0pOpFDwLSP/0hgcG2Y4ltuPdvMQHpsQ yDX3FyO24tDLSO0XQA11QhFSD+WWlX6oFN7PT/eagC8uh5tt4mOq+l3N3tKIMfh33oBpJBpKtbe1u vhwulX8aHboZEcvAkdQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8GNi-007xZC-Hc; Fri, 14 Jan 2022 06:48:14 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8GNe-007xWI-9b for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 06:48:11 +0000 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id DA0FF3F1DE for ; Fri, 14 Jan 2022 06:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642142880; bh=PKBAkmJ7or0T/bxHU0Wvyq29ugXtwBBaF+RK3mybysU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=LxvFn3HXX28YhC4TQMy/v9ut46IDsxRGCQvFE99D7Bl1zKiOl2kMWeHXSzIFePXCQ R/UHyjhhApSc+78vqT9T3yNiE+pWIWVFspYBLZteMe9B7Vc3jK5DPFEndhwVAfGGyy /2TX1bnGd15qZiSwDwqU1o6oORUBfJYcnWOoVd2S2K5R0wwjONukeXfF/mLgsB2v8O c91ulY9qPU5gQTwXVZFa1juurRC156WWRUVw4wXg0IpD84it05sWvuMDGqrxWcpmx8 tfgVAs0ZQ1bl8mqjhQKxJauHfWuEwLshrXYcY7iSMDmxPTF1bcMNflN6rCUbGDr71D eI+CVL+SQZeDQ== Received: by mail-oo1-f70.google.com with SMTP id t12-20020a4ab58c000000b002dcbee240efso5416534ooo.10 for ; Thu, 13 Jan 2022 22:48:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PKBAkmJ7or0T/bxHU0Wvyq29ugXtwBBaF+RK3mybysU=; b=jsnJAGa3Ne93SbsHE94uVZ3xENEgu1xZGYOIeswIU7a/d//zZdPNgxKZBpO8rqmj3J XBhjM0lmdOL1Qlt8GEgA+TLFoA24yOC+CQfH697nQzGJTUlSk2N47pVKgo8l946ZmSU+ ar0Awgid40FadYbYKMX2cUO0hPBZxvMQCuFDrbs2EZ3ceHpqqNO4nq8zWdJifChE+V7a dSZ9t0GUDQDGXnlorXEf4I3TlEM0MvL50sgaIEZk57jx87tTtDZzxC9TYmq8JCM7mPFp 5509XsAx/qFqY9mvhlllwm1DdvIiPtGRfPkQBZDXL3dVOMc2CxjAUekW84FdCZj30ys6 2eLQ== X-Gm-Message-State: AOAM5314F9wAgJUxXTjH4OI4O2gS+Myr/sE5fdVSpmhLYwWdlunM+ODi ljkGK7sH9fZl7+6mgJMpqZPZ1kpb4L1+jwObX58bF5AaiMtxoCZSYzcB7bZefO1pAFvXqku26uY 5eNobpH5nKME4cMYjnMSAj+ohiGSl8l9XEXFm6qSermlOpOJBf+THgNj4Dk3vk+704Atz X-Received: by 2002:a05:6808:293:: with SMTP id z19mr10972600oic.41.1642142879353; Thu, 13 Jan 2022 22:47:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJye/IK1OGddDRHlpoRSRDwJDrr3evy3FfczWQgU60l1SslTO9lJxeMi9V5rBVY0jKXg6Ly5r0DmOwSH1F8j5i0= X-Received: by 2002:a05:6808:293:: with SMTP id z19mr10972566oic.41.1642142878837; Thu, 13 Jan 2022 22:47:58 -0800 (PST) MIME-Version: 1.0 References: <20220114040755.1314349-1-kai.heng.feng@canonical.com> <20220114040755.1314349-2-kai.heng.feng@canonical.com> <20220113203523.310e13d3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220113203523.310e13d3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> From: Kai-Heng Feng Date: Fri, 14 Jan 2022 14:47:47 +0800 Message-ID: Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware To: Jakub Kicinski Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, "David S. Miller" , Maxime Coquelin , Andrew Lunn , Heiner Kallweit , Russell King , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Ivan Bornyakov , =?UTF-8?Q?Pali_Roh=C3=A1r?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_224810_522114_1FF47A1B X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 14, 2022 at 12:35 PM Jakub Kicinski wrote: > > On Fri, 14 Jan 2022 12:07:54 +0800 Kai-Heng Feng wrote: > > BIOS on Dell Edge Gateway 3200 already makes its own phy LED setting, so > > instead of setting another value, keep it untouched and restore the saved > > value on system resume. > > > > Signed-off-by: Kai-Heng Feng > > I defer to PHY experts for review. Coincidentally the first Marvell > flag appears dead, nobody sets it: > > $ git grep MARVELL_PHY_M1145_FLAGS_RESISTANCE > drivers/net/phy/marvell.c: if (phydev->dev_flags & MARVELL_PHY_M1145_FLAGS_RESISTANCE) { > include/linux/marvell_phy.h:#define MARVELL_PHY_M1145_FLAGS_RESISTANCE 0x00000001 > $ > > unless it's read from DT under different name or something. It was introduced by 95d21ff4c645 without any user. Should we keep it? > > > Once you get some reviews please wait for net-next to open: > > http://vger.kernel.org/~davem/net-next.html > > and repost. It should happen the week of Jan 24th. When you repost > please drop the first patch, I believe Russell does not like the BIT() > macro, his opinion overrides checkpatch. Of course. I'll wait for the review and resubmit the 2nd patch. Kai-Heng > > Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel