From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6571C433B4 for ; Mon, 26 Apr 2021 11:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62B6A61249 for ; Mon, 26 Apr 2021 11:10:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233146AbhDZLLE convert rfc822-to-8bit (ORCPT ); Mon, 26 Apr 2021 07:11:04 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:46456 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232185AbhDZLLD (ORCPT ); Mon, 26 Apr 2021 07:11:03 -0400 Received: from mail-lf1-f71.google.com ([209.85.167.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1laz89-0002BT-CW for linux-kernel@vger.kernel.org; Mon, 26 Apr 2021 11:10:21 +0000 Received: by mail-lf1-f71.google.com with SMTP id p28-20020a056512329cb02901ae653ca592so9279732lfe.12 for ; Mon, 26 Apr 2021 04:10:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xiDFWZDIwVOWhDf8JIJtdA0vE7Qg4WZABGwJr1mglyw=; b=Zj4EG5EXpfreMGAFcEu+d7HL3IKvr8Girxhue9R7pYZOBa2mKKCn3zUS5iJmq4Fx6V I6Rm21xAsTPo3/bwa/Oq7NAVVigXvUZq0APJZQTn4/ihag8hUkaxanBg5V24+dE3pi0o ddZetAhfjLydHu9S462EeqGSD4TyN5hJ0HKX/RaU0ogSzZ+MiLWJ0yzeIs0bsxkTXJnW XzrZqveNd/gUOmndSFe0FrIXIfNUBJV+LdNQeXSeGtm/CvquvC/Ms9GK8v58G6nS0/TR JYQGSn9gQ2xoHOHDQo/9DtVuk+81e4xq01F6thueWz1LU0F2UB9kxNDZ24XGUkzCXDmU mxKQ== X-Gm-Message-State: AOAM531pbX+60FUh2IlUO5s0koDmSTaa0xVYCs836MeEJWnvhh5RYIxJ LIgdugo1ZKuekq3q/hWQfVWPK2iM/c5a1uGr/gEuE8KFETLTwUKBkcRrOrzTOGmPD+H/Y0UBO9T gBM7a5R5r4L20qUxaD0UwxWfyqgdQsXrQMQmFwIQ7N6Sb30Ykvn0Ch1kfXA== X-Received: by 2002:ac2:4546:: with SMTP id j6mr307073lfm.290.1619435419363; Mon, 26 Apr 2021 04:10:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2HuOs7hsFQWQ6DpfjtFI/lGLMD7R4zW0qG+mZ1QM088Bg0L5h31Ae1gJG1TKdvDNzcal21ao43zQupwhBKww= X-Received: by 2002:ac2:4546:: with SMTP id j6mr307063lfm.290.1619435419143; Mon, 26 Apr 2021 04:10:19 -0700 (PDT) MIME-Version: 1.0 References: <20210423044700.247359-1-kai.heng.feng@canonical.com> In-Reply-To: From: Kai-Heng Feng Date: Mon, 26 Apr 2021 19:10:06 +0800 Message-ID: Subject: Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Takashi Iwai , intel-gfx , "open list:DRM DRIVERS" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 8:41 PM Ville Syrjälä wrote: > > On Fri, Apr 23, 2021 at 12:46:54PM +0800, Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > to discrete GFX after S3. This is not desirable, because userspace will > > treat connected display as a new one, losing display settings. > > > > The expected behavior is to let discrete GFX drives all external > > displays. > > > > The platform in question uses ACPI method \_SB.PCI0.HGME to enable MUX. > > The method is inside the BXT _DSM, so add the _DSM and call it > > accordingly. > > > > I also tested some MUX-less and iGPU only laptops with the BXT _DSM, no > > regression was found. > > > > v2: > > - Forward declare struct pci_dev. > > > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3113 > > References: https://lore.kernel.org/intel-gfx/1460040732-31417-4-git-send-email-animesh.manna@intel.com/ > > Signed-off-by: Kai-Heng Feng > > --- > > drivers/gpu/drm/i915/display/intel_acpi.c | 17 +++++++++++++++++ > > drivers/gpu/drm/i915/display/intel_acpi.h | 3 +++ > > drivers/gpu/drm/i915/i915_drv.c | 5 +++++ > > 3 files changed, 25 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c > > index 833d0c1be4f1..c7b57c22dce3 100644 > > --- a/drivers/gpu/drm/i915/display/intel_acpi.c > > +++ b/drivers/gpu/drm/i915/display/intel_acpi.c > > @@ -14,11 +14,16 @@ > > > > #define INTEL_DSM_REVISION_ID 1 /* For Calpella anyway... */ > > #define INTEL_DSM_FN_PLATFORM_MUX_INFO 1 /* No args */ > > +#define INTEL_DSM_FN_PLATFORM_BXT_MUX_INFO 0 /* No args */ > > > > static const guid_t intel_dsm_guid = > > GUID_INIT(0x7ed873d3, 0xc2d0, 0x4e4f, > > 0xa8, 0x54, 0x0f, 0x13, 0x17, 0xb0, 0x1c, 0x2c); > > > > +static const guid_t intel_bxt_dsm_guid = > > + GUID_INIT(0x3e5b41c6, 0xeb1d, 0x4260, > > + 0x9d, 0x15, 0xc7, 0x1f, 0xba, 0xda, 0xe4, 0x14); > > + > > I think this dsm is just supposed to be more or less an > alternative to the opregion SCI stuff. Why there are two > ways to do the same things I have no idea. The opregion > spec does not tell us such mundane details. Right now I think it's HP specific and from what I can see it doesn't touch opregion. > > It's also not documented to do anything except list the > supported functions: > "Get BIOS Data Functions Supported “Function #0" > This function can be called to discover which “_DSM” Functions are > supported. It may only return success if the return value accurately > lists supported Functions." > > But what you're apparently saying is that calling this changes > the behaviour of the system somehow? That is troubling. It flips a bit in BIOS-reserved Intel GPIO, and EC/hardware will change the MUX based on the GPIO bit. We can add a DMI check to match "HP" to minimize the potential regression factor. Kai-Heng > > -- > Ville Syrjälä > Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0006DC433ED for ; Mon, 26 Apr 2021 11:10:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98CA461006 for ; Mon, 26 Apr 2021 11:10:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98CA461006 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0A9C6E7D3; Mon, 26 Apr 2021 11:10:21 +0000 (UTC) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51DA96E7D3 for ; Mon, 26 Apr 2021 11:10:21 +0000 (UTC) Received: from mail-lj1-f199.google.com ([209.85.208.199]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1laz87-0002B0-Uw for dri-devel@lists.freedesktop.org; Mon, 26 Apr 2021 11:10:20 +0000 Received: by mail-lj1-f199.google.com with SMTP id a14-20020a2e7f0e0000b02900b9011db00cso14324308ljd.8 for ; Mon, 26 Apr 2021 04:10:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xiDFWZDIwVOWhDf8JIJtdA0vE7Qg4WZABGwJr1mglyw=; b=gThtnKm4/jsOwdZ6MkBnl9zDWeVC4bQJ3TvqxX0URH9Gz0GFlmUO0wXkEoPxlD/eQ2 xKprRPS4+6q0Gi5tW00C79QBSXdoQmxnKX+ox08L0suQJWac6/RZpB41tasli+X1CIBz UfcxorJcl1oGVU261cvmIseTHG/Xn4p6/4ioHaYIG6CtlcJWDUHZXUpVVDiCKE8HCino eeaHo3uJK5sicdH9tE06v/6Zs2IZKwv4jzInZAfWlxaJdcMw9qfakTkw0/sfLz+eAzR4 E6hhbm755jc8NZzbDEKGFTciGHprACWkkRwwcd2IoVSfi6qPnT0le3CoX6uUzgnCJpeL VDyw== X-Gm-Message-State: AOAM5303P1A4bnRLVmBgIoD03xnoBHUl358NtHjiCkaHujv8XR41GdQG ptYF71GBvXpD0Jt8uDuCAo+3iV3Cy3YyFhLNP7vmdLkU7Xoa1lBncYs4s/NlnNV56m2tnlOB8m/ pC6QvVnbTt+uIQtkY4w7/ngvC7CDXELC8j1B/VoWvq0FrwKitUSX4jq8gi4wLcw== X-Received: by 2002:ac2:4546:: with SMTP id j6mr307077lfm.290.1619435419365; Mon, 26 Apr 2021 04:10:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2HuOs7hsFQWQ6DpfjtFI/lGLMD7R4zW0qG+mZ1QM088Bg0L5h31Ae1gJG1TKdvDNzcal21ao43zQupwhBKww= X-Received: by 2002:ac2:4546:: with SMTP id j6mr307063lfm.290.1619435419143; Mon, 26 Apr 2021 04:10:19 -0700 (PDT) MIME-Version: 1.0 References: <20210423044700.247359-1-kai.heng.feng@canonical.com> In-Reply-To: From: Kai-Heng Feng Date: Mon, 26 Apr 2021 19:10:06 +0800 Message-ID: Subject: Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx , open list , "open list:DRM DRIVERS" , Rodrigo Vivi Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBBcHIgMjMsIDIwMjEgYXQgODo0MSBQTSBWaWxsZSBTeXJqw6Rsw6QKPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPgo+IE9uIEZyaSwgQXByIDIzLCAyMDIxIGF0 IDEyOjQ2OjU0UE0gKzA4MDAsIEthaS1IZW5nIEZlbmcgd3JvdGU6Cj4gPiBPbiBIUCBGdXJ5IEc3 IFdvcmtzdGF0aW9ucywgZ3JhcGhpY3Mgb3V0cHV0IGlzIHJlLXJvdXRlZCBmcm9tIEludGVsIEdG WAo+ID4gdG8gZGlzY3JldGUgR0ZYIGFmdGVyIFMzLiBUaGlzIGlzIG5vdCBkZXNpcmFibGUsIGJl Y2F1c2UgdXNlcnNwYWNlIHdpbGwKPiA+IHRyZWF0IGNvbm5lY3RlZCBkaXNwbGF5IGFzIGEgbmV3 IG9uZSwgbG9zaW5nIGRpc3BsYXkgc2V0dGluZ3MuCj4gPgo+ID4gVGhlIGV4cGVjdGVkIGJlaGF2 aW9yIGlzIHRvIGxldCBkaXNjcmV0ZSBHRlggZHJpdmVzIGFsbCBleHRlcm5hbAo+ID4gZGlzcGxh eXMuCj4gPgo+ID4gVGhlIHBsYXRmb3JtIGluIHF1ZXN0aW9uIHVzZXMgQUNQSSBtZXRob2QgXF9T Qi5QQ0kwLkhHTUUgdG8gZW5hYmxlIE1VWC4KPiA+IFRoZSBtZXRob2QgaXMgaW5zaWRlIHRoZSBC WFQgX0RTTSwgc28gYWRkIHRoZSBfRFNNIGFuZCBjYWxsIGl0Cj4gPiBhY2NvcmRpbmdseS4KPiA+ Cj4gPiBJIGFsc28gdGVzdGVkIHNvbWUgTVVYLWxlc3MgYW5kIGlHUFUgb25seSBsYXB0b3BzIHdp dGggdGhlIEJYVCBfRFNNLCBubwo+ID4gcmVncmVzc2lvbiB3YXMgZm91bmQuCj4gPgo+ID4gdjI6 Cj4gPiAgLSBGb3J3YXJkIGRlY2xhcmUgc3RydWN0IHBjaV9kZXYuCj4gPgo+ID4gQ2xvc2VzOiBo dHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvZHJtL2ludGVsLy0vaXNzdWVzLzMxMTMKPiA+ IFJlZmVyZW5jZXM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2ludGVsLWdmeC8xNDYwMDQwNzMy LTMxNDE3LTQtZ2l0LXNlbmQtZW1haWwtYW5pbWVzaC5tYW5uYUBpbnRlbC5jb20vCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBLYWktSGVuZyBGZW5nIDxrYWkuaGVuZy5mZW5nQGNhbm9uaWNhbC5jb20+Cj4g PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2FjcGkuYyB8IDE3 ICsrKysrKysrKysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9hY3BpLmggfCAgMyArKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAg ICAgICAgICB8ICA1ICsrKysrCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCsp Cj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf YWNwaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiA+IGlu ZGV4IDgzM2QwYzFiZTRmMS4uYzdiNTdjMjJkY2UzIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5jCj4gPiBAQCAtMTQsMTEgKzE0LDE2IEBACj4gPgo+ ID4gICNkZWZpbmUgSU5URUxfRFNNX1JFVklTSU9OX0lEIDEgLyogRm9yIENhbHBlbGxhIGFueXdh eS4uLiAqLwo+ID4gICNkZWZpbmUgSU5URUxfRFNNX0ZOX1BMQVRGT1JNX01VWF9JTkZPIDEgLyog Tm8gYXJncyAqLwo+ID4gKyNkZWZpbmUgSU5URUxfRFNNX0ZOX1BMQVRGT1JNX0JYVF9NVVhfSU5G TyAwIC8qIE5vIGFyZ3MgKi8KPiA+Cj4gPiAgc3RhdGljIGNvbnN0IGd1aWRfdCBpbnRlbF9kc21f Z3VpZCA9Cj4gPiAgICAgICBHVUlEX0lOSVQoMHg3ZWQ4NzNkMywgMHhjMmQwLCAweDRlNGYsCj4g PiAgICAgICAgICAgICAgICAgMHhhOCwgMHg1NCwgMHgwZiwgMHgxMywgMHgxNywgMHhiMCwgMHgx YywgMHgyYyk7Cj4gPgo+ID4gK3N0YXRpYyBjb25zdCBndWlkX3QgaW50ZWxfYnh0X2RzbV9ndWlk ID0KPiA+ICsgICAgIEdVSURfSU5JVCgweDNlNWI0MWM2LCAweGViMWQsIDB4NDI2MCwKPiA+ICsg ICAgICAgICAgICAgICAweDlkLCAweDE1LCAweGM3LCAweDFmLCAweGJhLCAweGRhLCAweGU0LCAw eDE0KTsKPiA+ICsKPgo+IEkgdGhpbmsgdGhpcyBkc20gaXMganVzdCBzdXBwb3NlZCB0byBiZSBt b3JlIG9yIGxlc3MgYW4KPiBhbHRlcm5hdGl2ZSB0byB0aGUgb3ByZWdpb24gU0NJIHN0dWZmLiBX aHkgdGhlcmUgYXJlIHR3bwo+IHdheXMgdG8gZG8gdGhlIHNhbWUgdGhpbmdzIEkgaGF2ZSBubyBp ZGVhLiBUaGUgb3ByZWdpb24KPiBzcGVjIGRvZXMgbm90IHRlbGwgdXMgc3VjaCBtdW5kYW5lIGRl dGFpbHMuCgpSaWdodCBub3cgSSB0aGluayBpdCdzIEhQIHNwZWNpZmljIGFuZCBmcm9tIHdoYXQg SSBjYW4gc2VlIGl0IGRvZXNuJ3QKdG91Y2ggb3ByZWdpb24uCgo+Cj4gSXQncyBhbHNvIG5vdCBk b2N1bWVudGVkIHRvIGRvIGFueXRoaW5nIGV4Y2VwdCBsaXN0IHRoZQo+IHN1cHBvcnRlZCBmdW5j dGlvbnM6Cj4gIkdldCBCSU9TIERhdGEgRnVuY3Rpb25zIFN1cHBvcnRlZCDigJxGdW5jdGlvbiAj MCIKPiAgVGhpcyBmdW5jdGlvbiBjYW4gYmUgY2FsbGVkIHRvIGRpc2NvdmVyIHdoaWNoIOKAnF9E U03igJ0gRnVuY3Rpb25zIGFyZQo+ICBzdXBwb3J0ZWQuIEl0IG1heSBvbmx5IHJldHVybiBzdWNj ZXNzIGlmIHRoZSByZXR1cm4gdmFsdWUgYWNjdXJhdGVseQo+ICBsaXN0cyBzdXBwb3J0ZWQgRnVu Y3Rpb25zLiIKPgo+IEJ1dCB3aGF0IHlvdSdyZSBhcHBhcmVudGx5IHNheWluZyBpcyB0aGF0IGNh bGxpbmcgdGhpcyBjaGFuZ2VzCj4gdGhlIGJlaGF2aW91ciBvZiB0aGUgc3lzdGVtIHNvbWVob3c/ IFRoYXQgaXMgdHJvdWJsaW5nLgoKSXQgZmxpcHMgYSBiaXQgaW4gQklPUy1yZXNlcnZlZCBJbnRl bCBHUElPLCBhbmQgRUMvaGFyZHdhcmUgd2lsbApjaGFuZ2UgdGhlIE1VWCBiYXNlZCBvbiB0aGUg R1BJTyBiaXQuCgpXZSBjYW4gYWRkIGEgRE1JIGNoZWNrIHRvIG1hdGNoICJIUCIgdG8gbWluaW1p emUgdGhlIHBvdGVudGlhbApyZWdyZXNzaW9uIGZhY3Rvci4KCkthaS1IZW5nCgo+Cj4gLS0KPiBW aWxsZSBTeXJqw6Rsw6QKPiBJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F1CCC43461 for ; Mon, 26 Apr 2021 11:10:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39EFC61263 for ; Mon, 26 Apr 2021 11:10:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39EFC61263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7320B6E7E6; Mon, 26 Apr 2021 11:10:24 +0000 (UTC) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC7866E7E6 for ; Mon, 26 Apr 2021 11:10:22 +0000 (UTC) Received: from mail-lf1-f71.google.com ([209.85.167.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1laz89-0002BW-Hg for intel-gfx@lists.freedesktop.org; Mon, 26 Apr 2021 11:10:21 +0000 Received: by mail-lf1-f71.google.com with SMTP id q4-20020a19df440000b02901bbaf9c6220so185893lfj.6 for ; Mon, 26 Apr 2021 04:10:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xiDFWZDIwVOWhDf8JIJtdA0vE7Qg4WZABGwJr1mglyw=; b=LlXXNCwe7QIpFyUt0Ld5i7Y30if6skiF+zim5Rb0jdZPr/6FKRuXxYy+zxXYIRmgBl svmc0WU1h9qYUwcUdNSL6sopuWBlJ2JdxaD17Ie6oVz54toCr+cYlgl3+Yv0HXDqO5+2 NzGWB8LZ4VJXrQWkFGiC6Mr5fvHRiN2ak/Tk1sI9IFYCVJaXLDV6/UuPNA/9qf+ouVdB JTSxJK6aQYQpiiItwqz6D988F8o3c9yZ0TKKRGcOFYfOYAg9h3wJjanf0GO+RejiZ8TH afgNgzPztJI4x4AIFCt+A5i42XnMjK2MYqswW/mmE3Pe8+qd+3Ojp18x/f/Y9n91COT7 A5tQ== X-Gm-Message-State: AOAM5333Orifnd2GHwm1lDCSwSVWfg525Pk4MpViVFOjYSgvSHC6ALs8 D8WGEoSYPVWqRbZFe2VP6Pvm4yyo67SofUHtt69DqW9me38Q0K0/VmJvS/psH5nDRcqulnnNp95 G5oBSTtBR/t5rK4OnGgVcP1Or8BdQR2bzmKcbpl2x83pzclZpYbgEsyWPg8G7HA== X-Received: by 2002:ac2:4546:: with SMTP id j6mr307083lfm.290.1619435419417; Mon, 26 Apr 2021 04:10:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2HuOs7hsFQWQ6DpfjtFI/lGLMD7R4zW0qG+mZ1QM088Bg0L5h31Ae1gJG1TKdvDNzcal21ao43zQupwhBKww= X-Received: by 2002:ac2:4546:: with SMTP id j6mr307063lfm.290.1619435419143; Mon, 26 Apr 2021 04:10:19 -0700 (PDT) MIME-Version: 1.0 References: <20210423044700.247359-1-kai.heng.feng@canonical.com> In-Reply-To: From: Kai-Heng Feng Date: Mon, 26 Apr 2021 19:10:06 +0800 Message-ID: To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx , open list , Takashi Iwai , "open list:DRM DRIVERS" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCBBcHIgMjMsIDIwMjEgYXQgODo0MSBQTSBWaWxsZSBTeXJqw6Rsw6QKPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPgo+IE9uIEZyaSwgQXByIDIzLCAyMDIxIGF0 IDEyOjQ2OjU0UE0gKzA4MDAsIEthaS1IZW5nIEZlbmcgd3JvdGU6Cj4gPiBPbiBIUCBGdXJ5IEc3 IFdvcmtzdGF0aW9ucywgZ3JhcGhpY3Mgb3V0cHV0IGlzIHJlLXJvdXRlZCBmcm9tIEludGVsIEdG WAo+ID4gdG8gZGlzY3JldGUgR0ZYIGFmdGVyIFMzLiBUaGlzIGlzIG5vdCBkZXNpcmFibGUsIGJl Y2F1c2UgdXNlcnNwYWNlIHdpbGwKPiA+IHRyZWF0IGNvbm5lY3RlZCBkaXNwbGF5IGFzIGEgbmV3 IG9uZSwgbG9zaW5nIGRpc3BsYXkgc2V0dGluZ3MuCj4gPgo+ID4gVGhlIGV4cGVjdGVkIGJlaGF2 aW9yIGlzIHRvIGxldCBkaXNjcmV0ZSBHRlggZHJpdmVzIGFsbCBleHRlcm5hbAo+ID4gZGlzcGxh eXMuCj4gPgo+ID4gVGhlIHBsYXRmb3JtIGluIHF1ZXN0aW9uIHVzZXMgQUNQSSBtZXRob2QgXF9T Qi5QQ0kwLkhHTUUgdG8gZW5hYmxlIE1VWC4KPiA+IFRoZSBtZXRob2QgaXMgaW5zaWRlIHRoZSBC WFQgX0RTTSwgc28gYWRkIHRoZSBfRFNNIGFuZCBjYWxsIGl0Cj4gPiBhY2NvcmRpbmdseS4KPiA+ Cj4gPiBJIGFsc28gdGVzdGVkIHNvbWUgTVVYLWxlc3MgYW5kIGlHUFUgb25seSBsYXB0b3BzIHdp dGggdGhlIEJYVCBfRFNNLCBubwo+ID4gcmVncmVzc2lvbiB3YXMgZm91bmQuCj4gPgo+ID4gdjI6 Cj4gPiAgLSBGb3J3YXJkIGRlY2xhcmUgc3RydWN0IHBjaV9kZXYuCj4gPgo+ID4gQ2xvc2VzOiBo dHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvZHJtL2ludGVsLy0vaXNzdWVzLzMxMTMKPiA+ IFJlZmVyZW5jZXM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2ludGVsLWdmeC8xNDYwMDQwNzMy LTMxNDE3LTQtZ2l0LXNlbmQtZW1haWwtYW5pbWVzaC5tYW5uYUBpbnRlbC5jb20vCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBLYWktSGVuZyBGZW5nIDxrYWkuaGVuZy5mZW5nQGNhbm9uaWNhbC5jb20+Cj4g PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2FjcGkuYyB8IDE3 ICsrKysrKysrKysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9hY3BpLmggfCAgMyArKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAg ICAgICAgICB8ICA1ICsrKysrCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCsp Cj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf YWNwaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiA+IGlu ZGV4IDgzM2QwYzFiZTRmMS4uYzdiNTdjMjJkY2UzIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5jCj4gPiBAQCAtMTQsMTEgKzE0LDE2IEBACj4gPgo+ ID4gICNkZWZpbmUgSU5URUxfRFNNX1JFVklTSU9OX0lEIDEgLyogRm9yIENhbHBlbGxhIGFueXdh eS4uLiAqLwo+ID4gICNkZWZpbmUgSU5URUxfRFNNX0ZOX1BMQVRGT1JNX01VWF9JTkZPIDEgLyog Tm8gYXJncyAqLwo+ID4gKyNkZWZpbmUgSU5URUxfRFNNX0ZOX1BMQVRGT1JNX0JYVF9NVVhfSU5G TyAwIC8qIE5vIGFyZ3MgKi8KPiA+Cj4gPiAgc3RhdGljIGNvbnN0IGd1aWRfdCBpbnRlbF9kc21f Z3VpZCA9Cj4gPiAgICAgICBHVUlEX0lOSVQoMHg3ZWQ4NzNkMywgMHhjMmQwLCAweDRlNGYsCj4g PiAgICAgICAgICAgICAgICAgMHhhOCwgMHg1NCwgMHgwZiwgMHgxMywgMHgxNywgMHhiMCwgMHgx YywgMHgyYyk7Cj4gPgo+ID4gK3N0YXRpYyBjb25zdCBndWlkX3QgaW50ZWxfYnh0X2RzbV9ndWlk ID0KPiA+ICsgICAgIEdVSURfSU5JVCgweDNlNWI0MWM2LCAweGViMWQsIDB4NDI2MCwKPiA+ICsg ICAgICAgICAgICAgICAweDlkLCAweDE1LCAweGM3LCAweDFmLCAweGJhLCAweGRhLCAweGU0LCAw eDE0KTsKPiA+ICsKPgo+IEkgdGhpbmsgdGhpcyBkc20gaXMganVzdCBzdXBwb3NlZCB0byBiZSBt b3JlIG9yIGxlc3MgYW4KPiBhbHRlcm5hdGl2ZSB0byB0aGUgb3ByZWdpb24gU0NJIHN0dWZmLiBX aHkgdGhlcmUgYXJlIHR3bwo+IHdheXMgdG8gZG8gdGhlIHNhbWUgdGhpbmdzIEkgaGF2ZSBubyBp ZGVhLiBUaGUgb3ByZWdpb24KPiBzcGVjIGRvZXMgbm90IHRlbGwgdXMgc3VjaCBtdW5kYW5lIGRl dGFpbHMuCgpSaWdodCBub3cgSSB0aGluayBpdCdzIEhQIHNwZWNpZmljIGFuZCBmcm9tIHdoYXQg SSBjYW4gc2VlIGl0IGRvZXNuJ3QKdG91Y2ggb3ByZWdpb24uCgo+Cj4gSXQncyBhbHNvIG5vdCBk b2N1bWVudGVkIHRvIGRvIGFueXRoaW5nIGV4Y2VwdCBsaXN0IHRoZQo+IHN1cHBvcnRlZCBmdW5j dGlvbnM6Cj4gIkdldCBCSU9TIERhdGEgRnVuY3Rpb25zIFN1cHBvcnRlZCDigJxGdW5jdGlvbiAj MCIKPiAgVGhpcyBmdW5jdGlvbiBjYW4gYmUgY2FsbGVkIHRvIGRpc2NvdmVyIHdoaWNoIOKAnF9E U03igJ0gRnVuY3Rpb25zIGFyZQo+ICBzdXBwb3J0ZWQuIEl0IG1heSBvbmx5IHJldHVybiBzdWNj ZXNzIGlmIHRoZSByZXR1cm4gdmFsdWUgYWNjdXJhdGVseQo+ICBsaXN0cyBzdXBwb3J0ZWQgRnVu Y3Rpb25zLiIKPgo+IEJ1dCB3aGF0IHlvdSdyZSBhcHBhcmVudGx5IHNheWluZyBpcyB0aGF0IGNh bGxpbmcgdGhpcyBjaGFuZ2VzCj4gdGhlIGJlaGF2aW91ciBvZiB0aGUgc3lzdGVtIHNvbWVob3c/ IFRoYXQgaXMgdHJvdWJsaW5nLgoKSXQgZmxpcHMgYSBiaXQgaW4gQklPUy1yZXNlcnZlZCBJbnRl bCBHUElPLCBhbmQgRUMvaGFyZHdhcmUgd2lsbApjaGFuZ2UgdGhlIE1VWCBiYXNlZCBvbiB0aGUg R1BJTyBiaXQuCgpXZSBjYW4gYWRkIGEgRE1JIGNoZWNrIHRvIG1hdGNoICJIUCIgdG8gbWluaW1p emUgdGhlIHBvdGVudGlhbApyZWdyZXNzaW9uIGZhY3Rvci4KCkthaS1IZW5nCgo+Cj4gLS0KPiBW aWxsZSBTeXJqw6Rsw6QKPiBJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK