From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3693C4320A for ; Thu, 29 Jul 2021 14:50:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C6C360EFD for ; Thu, 29 Jul 2021 14:50:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237816AbhG2Oum (ORCPT ); Thu, 29 Jul 2021 10:50:42 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:53054 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237779AbhG2Oum (ORCPT ); Thu, 29 Jul 2021 10:50:42 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 06D893F0AA for ; Thu, 29 Jul 2021 14:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627570237; bh=bU3aJudrCBoWRfseckxJjEUGOPUyIi0wc73ZEH0TAIo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=jCu6Nj6KfmlmQBvAxBB0tSc0zp7GO8uycf4ZWlSDUuGSL2u/4Nb9mGSv6Q/NSjqog BKNsIkMQBJRLZ4QXOCir1TYW8Kx3V9YRWCz2kOX2xYVYGd+GNsDlqw5lNXwZYAubuw 2tMt0QS521POL8tLul2FwXUHpxrZscGuDXbunq0lnQm7+cm/l+FOqIe3fs1wWmUCVm /z5K2wHDOSOJopp/k/pLZFfOu4LQhpkBQdG74Ri1bj3RGZnHtR1wJNbdHQr9bo58i5 CdTR0pGOj3LVPL/LrOik0/gm08BWnOuVOOZ+rNCQkL0gmU+UUhgM7BN4rCCT9TXI8S lnzrRs56+L2DQ== Received: by mail-ed1-f69.google.com with SMTP id b13-20020a056402278db029039c013d5b80so3068644ede.7 for ; Thu, 29 Jul 2021 07:50:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bU3aJudrCBoWRfseckxJjEUGOPUyIi0wc73ZEH0TAIo=; b=VISaF79ChorN28JTx4+K6mrP5XvrEf1nWaTdeQJJb0xowBIi/3Ntf7wsPnoG9Y30g/ feDT6Fh+0qZxki0UpX9mPi0TprCXI5ufjpRjKBPknhi/4WO8gSwwsWlR1ItPEX55yOde gk9v4ZgLQiHVP71qdNL/xBw4p2DpvcJWFvkvYcOy6YUHDDms5C1yVcv8SCZBs23XbL93 /XGY6n8ym37wHjdIAiryt4Op123hpc9jg9gTGt7XfE5uM4iVu6lmfqTEckYHS8VoyZNz Z7PdccmwBv0yGuJ8T8ESx1WbVJ6R1E+El0oiTjlK5gRt/mIGCqhMlCGDYaW0R+OwBE0o Niyg== X-Gm-Message-State: AOAM53117R1Nt0MeWFcad/TM34t0QRdcWHi579v+BrgAyZv99XGVgCUu 6gaFjabJpIJdJXjVgvjZpFTDM4pwlccq5PT1upmufIbYoQiPOcGD96jtnLX5DZ/t+teF1N0T2Gd 67sw3eo+dCz/KmUjlrw5sE61eHma7yYTbXdLJy1oYhEX9jDLWs7ub/A== X-Received: by 2002:a17:906:4e52:: with SMTP id g18mr5068696ejw.432.1627570231830; Thu, 29 Jul 2021 07:50:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLbaFtB4Oa0qb/cXYZ3tKM/1FAsoCdzWz2mqugcIj84Rzh8YIxhE0ygEpBqP7MTQZ+YfzXNAEBEeRHHsZ7qNk= X-Received: by 2002:a17:906:4e52:: with SMTP id g18mr5068680ejw.432.1627570231539; Thu, 29 Jul 2021 07:50:31 -0700 (PDT) MIME-Version: 1.0 References: <20210727155512.GA716431@bjorn-Precision-5520> In-Reply-To: <20210727155512.GA716431@bjorn-Precision-5520> From: Kai-Heng Feng Date: Thu, 29 Jul 2021 22:50:16 +0800 Message-ID: Subject: Re: [Bug 213873] New: Hotplug ethernet cable to runtime suspended Realtek NIC doesn't raise PCIe PME IRQ on Intel ADL To: Bjorn Helgaas Cc: Linux PCI , "Rafael J. Wysocki" , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jul 27, 2021 at 11:55 PM Bjorn Helgaas wrote: > > On Tue, Jul 27, 2021 at 06:10:13AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=213873 > > > > Bug ID: 213873 > > Summary: Hotplug ethernet cable to runtime suspended Realtek > > NIC doesn't raise PCIe PME IRQ on Intel ADL > > Product: Drivers > > Version: 2.5 > > Kernel Version: mainline > > Hardware: All > > OS: Linux > > Tree: Mainline > > Status: NEW > > Severity: normal > > Priority: P1 > > Component: PCI > > Assignee: drivers_pci@kernel-bugs.osdl.org > > Reporter: kai.heng.feng@canonical.com > > Regression: No > > > > Both PCIe bridge and Realtek NIC are runtime suspended. When ethernet cable is > > plugged, PMEStatus and PMEPending are marked: > > RootSta: PME ReqID 0200, PMEStatus+ PMEPending+ > > > > But the IRQ isn't raised: > > $ cat /proc/interrupts | grep PME > > 145: 0 0 0 0 0 0 > > 0 0 0 0 0 0 VMD-MSI 126 PCIe > > PME, aerdrv, pcie-dpc > > > > So the hotplug event isn't detected. > > > > -- > > From the lspci after cable hotplug (comment #3): > > 0000:00:1c.0 PCI bridge ... > RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna- CRSVisible- > RootSta: PME ReqID 0200, PMEStatus+ PMEPending+ > > So it looks like the root port is not enabled to generate a PME > interrupt. pcie_pme_interrupt_enable() looks like it *could* enable > that. From a quick look, my guess is that pme.c doesn't claim this > root port because the platform says it doesn't support it: > > acpi PNP0A08:00: _OSC: platform does not support [PCIeHotplug SHPCHotplug PME] > acpi PNP0A08:00: _OSC: OS now controls [AER PCIeCapability LTR] > > Does booting with "pcie_ports=native" make it work? That's not a very > good solution, of course, because then both the firmware and Linux > think they own this functionality. Yes, thanks for spotting this. > > Is there a BIOS update that would fix this? This platform is still under enablement so we'll get a BIOS fix. Kai-Heng > > Bjorn