From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
mathias.nyman@intel.com, Lars_Chang@asmedia.com.tw,
USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Tsai, Nicholas" <nicholas.tsai@amd.com>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
Ramkumar Subramaniyan <ramkumar.ks@amd.com>
Subject: Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"
Date: Tue, 29 Aug 2017 12:56:20 +0800 [thread overview]
Message-ID: <CAAd53p7df_njTwYyhS=n3=d3B5j5N46kB257097Gtm43GRrdcQ@mail.gmail.com> (raw)
In-Reply-To: <59A3ECF2.8050406@linux.intel.com>
On Mon, Aug 28, 2017 at 6:14 PM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
> On 28.08.2017 12:29, Greg KH wrote:
>>
>> On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote:
>>>
>>> This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f.
>>>
>>> Commit dec08194ffec ("xhci: Limit USB2 port wake support for AMD
>>> Promontory
>>> hosts") makes all high speed USB ports on ASUS PRIME B350M-A cease to
>>> function after enabling runtime PM.
>>>
>>> All boards with this chipsets will be affected, so revert the commit.
>>>
>>> Conflicts:
>>> drivers/usb/host/xhci-pci.c
>>> drivers/usb/host/xhci.h
>>
>>
>> Why are these "Conflicts:" lines here, you did fix up the issues, so
>> there shouldn't be any more conflicts.
>>
>> And if you revert this, don't we still have the original problem here?
>>
>
> Adding more people who were involved in the original patch.
>
> Users are now seeing the unresponsive USB2 ports with Promontory hosts.
> Is there any update on a better way to solve the original issue.
>
> To me a "dead" USB2 port seems like a much worse issue for a user
> than a BIOS disabled port waking up on plug/unplug (wake on
> connect/disconnect),
> so I'm myself in favor of doing this revert.
At least I can't find "Disable USB2" on my ASUS PRIME B350M-A, so the
new behavior is quite surprising.
>
> But there was a strong push from Promontory developers to get the original
> fix in,
> and I would like to get some comment from them before I do anything about
> it.
You looped them to the mail thread which I reported the regression two
weeks ago, and there is no response since then...
>
> Thanks
> -Mathias
>
next prev parent reply other threads:[~2017-08-29 4:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 9:14 [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts" Kai-Heng Feng
2017-08-28 9:29 ` Greg KH
2017-08-28 10:14 ` Mathias Nyman
2017-08-29 4:56 ` Kai-Heng Feng [this message]
2017-09-16 4:49 ` Kai-Heng Feng
2017-09-18 8:06 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAd53p7df_njTwYyhS=n3=d3B5j5N46kB257097Gtm43GRrdcQ@mail.gmail.com' \
--to=kai.heng.feng@canonical.com \
--cc=Lars_Chang@asmedia.com.tw \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=nicholas.tsai@amd.com \
--cc=ramkumar.ks@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.