From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF157C4338F for ; Fri, 30 Jul 2021 17:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 984FF60F5E for ; Fri, 30 Jul 2021 17:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbhG3ReT (ORCPT ); Fri, 30 Jul 2021 13:34:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbhG3ReS (ORCPT ); Fri, 30 Jul 2021 13:34:18 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC07C06175F for ; Fri, 30 Jul 2021 10:34:13 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id h9so13408598ljq.8 for ; Fri, 30 Jul 2021 10:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mlX1nCiNDRiVrVxlVDHszrB0v/ewjTsjg4ostQyNPUg=; b=bynegcZxgDCEpUi8d2HuAzcpZ1tEmeaASJMHmkOYZc3mvMjCLUDIbTm+O1VuoWz91H 9R28kLzaqtrtHbh9yTEfJSESk7sV+cF8+oLbjR9RXqSJqaX0bVci5a3SnRsowoV+yED6 qZ1TK7yxLK6D7Dwz70IPalyohCTfsZ0VxZdPgPixwDQdgqQw/m4dO7i2KIOJ2e+w+ygF e9QCCHbYO5VNcNwQ9EfUkoqJQg+ZrK8WL7ZrKiM7muXUNXPn/a3WuhkqK+lk8Fc+TMQZ ia21dWwC18DDnXBaP3W4XQnWopcwzowFvE3wYZ8lhNd61SbFTMvyTL7EpbyJclo+l3xb +6yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mlX1nCiNDRiVrVxlVDHszrB0v/ewjTsjg4ostQyNPUg=; b=GDq18iaNpysbGseck+EiPBfQjnKDF785DxQ7ZTmNyaSN2ox1Q0zOfQfvTRLKHBEevE 4Jy7c17V2PF82p802NYqLm12I1anaEbe2VDJETKPvvVgb9KMFgm6in+YbtFI77xhfJXP LQke76t2yLjTqcd4v2/J5yaXy1EQiK+grAzB+VBc3vOFF/eXyoPZlDFE/4gDbRdQhN+k zXJcMeaviLM6GHPtZhPxbhtWRuisZCGksXwg9gue6oj3uGd1aQP54ObvhfLIPwMLQM8C QP9A70pzrjRmgG7oaPmqyAHI8XDI/Uk71FHdgX3tyqKZqztabpUt6/PmNldJ1TQBD1nH FAog== X-Gm-Message-State: AOAM531XCYbZA+n+pxVUL7CHUZk4j1p0OCamHn5iMXdYb7EtHqCRDlEH xNIo3WoOVu/gfv3kSL9nbCDuMWKu+pJjhRgORNz4Ow== X-Google-Smtp-Source: ABdhPJwQm7osgysjal7b4gFKQif1+BNO+0WNNDORDMRHHkvDuxmU8Mm408VnxrPPcR+CR90UPsnKxeheV7HfFlQNNJA= X-Received: by 2002:a2e:90c4:: with SMTP id o4mr2361162ljg.28.1627666451240; Fri, 30 Jul 2021 10:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20210706180350.2838127-1-jingzhangos@google.com> <20210706180350.2838127-5-jingzhangos@google.com> <8a6f9314-7329-54d1-63b4-dc7ba6b4ea1d@redhat.com> In-Reply-To: <8a6f9314-7329-54d1-63b4-dc7ba6b4ea1d@redhat.com> From: Jing Zhang Date: Fri, 30 Jul 2021 10:34:00 -0700 Message-ID: Subject: Re: [PATCH v1 4/4] KVM: stats: Add halt polling related histogram stats To: Paolo Bonzini Cc: KVM , KVMPPC , Sean Christopherson , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , David Matlack Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jul 28, 2021 at 5:45 AM Paolo Bonzini wrote: > > On 06/07/21 20:03, Jing Zhang wrote: > > + kvm_stats_log_hist_update( > > + vc->runner->stat.generic.halt_wait_hist, > > + LOGHIST_SIZE_LARGE, > > + ktime_to_ns(cur) - ktime_to_ns(start_wait)); > > Instead of passing the size to the function, perhaps you can wrap it > with a macro > > #define KVM_STATS_LOG_HIST_UPDATE(array, value) \ > kvm_stats_log_hist_update(array, ARRAY_SIZE(array), value) That's nice! Will do that. > > Paolo > Thanks, Jing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jing Zhang Date: Fri, 30 Jul 2021 17:34:00 +0000 Subject: Re: [PATCH v1 4/4] KVM: stats: Add halt polling related histogram stats Message-Id: List-Id: References: <20210706180350.2838127-1-jingzhangos@google.com> <20210706180350.2838127-5-jingzhangos@google.com> <8a6f9314-7329-54d1-63b4-dc7ba6b4ea1d@redhat.com> In-Reply-To: <8a6f9314-7329-54d1-63b4-dc7ba6b4ea1d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paolo Bonzini Cc: KVM , KVMPPC , Sean Christopherson , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , David Matlack On Wed, Jul 28, 2021 at 5:45 AM Paolo Bonzini wrote: > > On 06/07/21 20:03, Jing Zhang wrote: > > + kvm_stats_log_hist_update( > > + vc->runner->stat.generic.halt_wait_hist, > > + LOGHIST_SIZE_LARGE, > > + ktime_to_ns(cur) - ktime_to_ns(start_wait)); > > Instead of passing the size to the function, perhaps you can wrap it > with a macro > > #define KVM_STATS_LOG_HIST_UPDATE(array, value) \ > kvm_stats_log_hist_update(array, ARRAY_SIZE(array), value) That's nice! Will do that. > > Paolo > Thanks, Jing