All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philippe@mathieu-daude.net>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Alistair Francis <alistair23@gmail.com>
Subject: Re: [Qemu-devel] [RFC v1 1/3] util/qemu-error: Rename error_print_loc() to be more generic
Date: Wed, 28 Jun 2017 01:32:36 -0300	[thread overview]
Message-ID: <CAAdtpL5OL5MAue11GRuegt-i=JVET1BPejbwU6Dkn40hhkCogw@mail.gmail.com> (raw)
In-Reply-To: <c0a2b62c80ddf46f99885b43215899a51a81ebc3.1498596157.git.alistair.francis@xilinx.com>

On Tue, Jun 27, 2017 at 5:45 PM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> Rename the error_print_loc() function in preperation for using it to

preparation

> print warnings as well.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>
>  util/qemu-error.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index b331f8f4a4..1c5e35ecdb 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -146,7 +146,7 @@ const char *error_get_progname(void)
>  /*
>   * Print current location to current monitor if we have one, else to stderr.
>   */
> -static void error_print_loc(void)
> +static void print_loc(void)
>  {
>      const char *sep = "";
>      int i;
> @@ -197,7 +197,7 @@ void error_vreport(const char *fmt, va_list ap)
>          g_free(timestr);
>      }
>
> -    error_print_loc();
> +    print_loc();
>      error_vprintf(fmt, ap);
>      error_printf("\n");
>  }
> --
> 2.11.0
>
>

  reply	other threads:[~2017-06-28  4:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 20:45 [Qemu-devel] [RFC v1 0/3] Implement a warning_report function Alistair Francis
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 1/3] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-06-28  4:32   ` Philippe Mathieu-Daudé [this message]
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 2/3] util/qemu-error: Add a warning_report() function Alistair Francis
2017-06-27 22:21   ` Thomas Huth
2017-06-28  0:16     ` Alistair Francis
2017-06-28  9:04   ` Daniel P. Berrange
2017-06-28 16:16     ` Alistair Francis
2017-06-28 16:19       ` Daniel P. Berrange
2017-06-29  7:38         ` Markus Armbruster
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 3/3] char-socket: Report TCP socket waiting as a warning Alistair Francis
2017-06-27 21:10   ` Edgar E. Iglesias
2017-06-28  0:17     ` Alistair Francis
2017-06-28  6:15       ` Edgar E. Iglesias
2017-06-28 16:18         ` Alistair Francis
2017-06-28  9:07 ` [Qemu-devel] [RFC v1 0/3] Implement a warning_report function Daniel P. Berrange
2017-06-28 15:49   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdtpL5OL5MAue11GRuegt-i=JVET1BPejbwU6Dkn40hhkCogw@mail.gmail.com' \
    --to=philippe@mathieu-daude.net \
    --cc=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.