All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Kyle Evans <kevans@freebsd.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Laurent Vivier <laurent@vivier.eu>,
	Paolo Bonzini <pbonzini@redhat.com>, Warner Losh <imp@bsdimp.com>
Subject: Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host
Date: Mon, 27 Sep 2021 11:40:02 +0200	[thread overview]
Message-ID: <CAAdtpL7DesxBWZkjZdrWtSVNuqzqthPR-MMdCCd4LMg+Rnudww@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_pRwZz=cK7=EjTsffhfhkXA-WvfecYWQ16sHYW+yQJBA@mail.gmail.com>

On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell <peter.maydell@linaro.org> wrote:
> On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> > Reported-by: Warner Losh <imp@bsdimp.com>
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  bsd-user/meson.build | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/bsd-user/meson.build b/bsd-user/meson.build
> > index 03695493408..a7607e1c884 100644
> > --- a/bsd-user/meson.build
> > +++ b/bsd-user/meson.build
> > @@ -1,3 +1,7 @@
> > +if not config_host.has_key('CONFIG_BSD')
> > +  subdir_done()
> > +endif
> > +
> >  bsd_user_ss.add(files(
> >    'bsdload.c',
> >    'elfload.c',
>
>
> So, what's the reason for this change?

https://lore.kernel.org/qemu-devel/CANCZdfprC16ezJQCWJmYEApX6eym9nxSOqAtBAGr+cziS4r2qw@mail.gmail.com/

linux-user/meson.build is evaluated on bsd, and bsd-user/meson.build on Linux.

> The commit messages and
> the cover letter don't really explain it. Is this fixing a bug
> (if so what?), a precaution to avoid possible future bugs,
> fixing a performance issue with how long meson takes to run (if
> so, how much effect does this have), or something else?

I'll wait for feedback from Paolo, then work on the explanation.

Regards,

Phil.


  reply	other threads:[~2021-09-27  9:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 22:01 [PATCH 0/2] user-mode: Avoid processing unnecessary meson rules Philippe Mathieu-Daudé
2021-09-26 22:01 ` [PATCH 1/2] bsd-user: Only process meson rules on BSD host Philippe Mathieu-Daudé
2021-09-26 23:08   ` Richard Henderson
2021-09-26 23:31     ` Warner Losh
2021-09-27  5:24     ` Philippe Mathieu-Daudé
2021-10-05 19:16       ` Paolo Bonzini
2021-09-27  2:42   ` WANG Xuerui
2021-09-27  2:59     ` WANG Xuerui
2021-09-27  9:14   ` Peter Maydell
2021-09-27  9:40     ` Philippe Mathieu-Daudé [this message]
2021-09-27  9:54       ` Peter Maydell
2021-10-05 19:23         ` Paolo Bonzini
2021-10-05 18:28       ` Alex Bennée
2021-09-27  9:52   ` Daniel P. Berrangé
2021-09-27 10:07     ` Peter Maydell
2021-09-27 10:53       ` Warner Losh
2021-10-05 19:26     ` Paolo Bonzini
2021-10-05 20:41       ` Laurent Vivier
2021-10-05 20:46         ` Warner Losh
2021-10-06  6:02           ` Laurent Vivier
2021-09-26 22:01 ` [PATCH 2/2] linux-user: Only process meson rules on Linux host Philippe Mathieu-Daudé
2021-09-27  2:42   ` WANG Xuerui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdtpL7DesxBWZkjZdrWtSVNuqzqthPR-MMdCCd4LMg+Rnudww@mail.gmail.com \
    --to=f4bug@amsat.org \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.