From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA8CC55ABD for ; Thu, 12 Nov 2020 19:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6211920A8B for ; Thu, 12 Nov 2020 19:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="euZJ1KFs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726868AbgKLTwH (ORCPT ); Thu, 12 Nov 2020 14:52:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbgKLTwG (ORCPT ); Thu, 12 Nov 2020 14:52:06 -0500 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2292C0613D1 for ; Thu, 12 Nov 2020 11:52:05 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id g7so5545513pfc.2 for ; Thu, 12 Nov 2020 11:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6grGTHRg8rsQq1ytOmJKPPc/a47JtcnHiEDyRqBbLFo=; b=euZJ1KFslUbqxplovouyxG8p0U+5+xuKJD4/GMN4ixlQJDzc/G0SQZTp3Fl2aryH9a jZuQg6p73xPEgXHx7QgnJGdxpcO43wqgWjrCEiigP6qhu0Z1ONy4LM69d5xWn5fqiAjf nKQRjWnb43kbs/G6nf27kwm0DIdmx4dezF7NZ18jeI0t3egMDcup0GnZ2C86V2fJPBJf O5Hjp9M28mx002EbXyvkABmb714LZbbKkBYqGZG7Sbv2lJZUBFQi+18Yw8nt7GZAmYC6 HR2kUslyxlb8trjZS5Y3X95dlNU7osxVXNTIhdobS1PtxwPkWIxUCsaMmLuKGdsZ3WpH Q9LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6grGTHRg8rsQq1ytOmJKPPc/a47JtcnHiEDyRqBbLFo=; b=XxHe5preXqlfk/BVL27CR9d5zwHAe9Xh8acjIahsk5GqnQ5FAUZVfeDl7ZVRK1ej9E S2LBbc8lBSXNZav96INuEfqySkbulWgXmWNRvIfrfpooGvBauv0TKVici8D78hGzomp1 Hnp7OMu4t3sLEEQe16D7tcsxZMX0MP5zBWJFzQ1lfxG+R6r3Au8zlsSqp4D/F7j9RVdZ IhFzzqQCFSPFOINHqKv+oOXoeX6AnOAxmtpl0Nd0CKtkKbba2e0+jtkXciGtk+uFfYqx 5z6Fd2ob1wdLq1ykVKbIMvq5cZvgMrIPrJhDlZmN1KRvloKE903/dVfFWTI6U5C8CGVb v0lA== X-Gm-Message-State: AOAM5335KgNZhUL2Kw7zZiLODN/mUauG6/9QhtVGSdO5/o3nnuY6wONJ eXYtonH+/4XyXXMei9tdI85yoAt+TQelbPOfTdA6bQ== X-Google-Smtp-Source: ABdhPJwKzVqKpDX9KBt9y8fPXoFH25yT6OCFViJDkBsmWi4+WIsb92nIDpsfYsvWT4Q0Jq4is2aH0qhBhL/vC1bjOoE= X-Received: by 2002:a17:90a:eb02:: with SMTP id j2mr842940pjz.136.1605210725310; Thu, 12 Nov 2020 11:52:05 -0800 (PST) MIME-Version: 1.0 References: <20201111182931.GM517454@elver.google.com> In-Reply-To: <20201111182931.GM517454@elver.google.com> From: Andrey Konovalov Date: Thu, 12 Nov 2020 20:51:52 +0100 Message-ID: Subject: Re: [PATCH v2 11/20] kasan: add and integrate kasan boot parameters To: Marco Elver Cc: Dmitry Vyukov , Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 7:29 PM Marco Elver wrote: > > > +#include > > +#include > > This should include -- although the rest of the > kernel seems to also inconsistently use on or the other. Since the name, > as referred to also by macros are "static keys", perhaps the > static_key.h header is more appropriate... Will fix. > > +enum kasan_arg_stacktrace { > > + KASAN_ARG_STACKTRACE_DEFAULT, > > It seems KASAN_ARG_STACKTRACE_DEFAULT is never used explicitly. Could > the switch statements just be changed to not have a 'default' but > instead refer to *DEFAULT where appropriate? We need to either cover all cases explicitly, or use default in each switch, otherwise there's a warning. I guess covering everything explicitly is a better approach, in case more values are added in the future, as we'll get warnings for those if they aren't covered in switches. Will do. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14B6C2D0E4 for ; Thu, 12 Nov 2020 19:52:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3814420825 for ; Thu, 12 Nov 2020 19:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="euZJ1KFs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3814420825 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A2C0D6B0036; Thu, 12 Nov 2020 14:52:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DBA26B005C; Thu, 12 Nov 2020 14:52:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A43D6B0068; Thu, 12 Nov 2020 14:52:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 5D36D6B0036 for ; Thu, 12 Nov 2020 14:52:07 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0C9FB180AD801 for ; Thu, 12 Nov 2020 19:52:07 +0000 (UTC) X-FDA: 77476812294.23.dust55_381084227309 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id DFC9037606 for ; Thu, 12 Nov 2020 19:52:06 +0000 (UTC) X-HE-Tag: dust55_381084227309 X-Filterd-Recvd-Size: 4219 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 19:52:06 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id z24so5111812pgk.3 for ; Thu, 12 Nov 2020 11:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6grGTHRg8rsQq1ytOmJKPPc/a47JtcnHiEDyRqBbLFo=; b=euZJ1KFslUbqxplovouyxG8p0U+5+xuKJD4/GMN4ixlQJDzc/G0SQZTp3Fl2aryH9a jZuQg6p73xPEgXHx7QgnJGdxpcO43wqgWjrCEiigP6qhu0Z1ONy4LM69d5xWn5fqiAjf nKQRjWnb43kbs/G6nf27kwm0DIdmx4dezF7NZ18jeI0t3egMDcup0GnZ2C86V2fJPBJf O5Hjp9M28mx002EbXyvkABmb714LZbbKkBYqGZG7Sbv2lJZUBFQi+18Yw8nt7GZAmYC6 HR2kUslyxlb8trjZS5Y3X95dlNU7osxVXNTIhdobS1PtxwPkWIxUCsaMmLuKGdsZ3WpH Q9LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6grGTHRg8rsQq1ytOmJKPPc/a47JtcnHiEDyRqBbLFo=; b=oNIADtnXn1m+/adyTXDOcBnHwgyULrJxNwhoIEn98BtJO8QXHwDcxz/NGLa5p3f+XZ Wk1fu6XhV5qHxciux87GOQcgW6cEwXCLGw3Z3xSFHBoTAGpPiPAHsdYlfmhjfh70dyCj LqEb9cjEh+ViD/GjapjMHNZbq5bgtd3Bcq0HICpdjPliV8gUZ39COs/hxlnNoosK6rRO GHGvjEWopoMi4YN0/tXuA7K6fbtdp3ugubIeL1b5xymRl6WzxrY9iORZzvCPGDCriK3L LySOu98bF+ZeD9Wz60kWe1hPXi5D7u+AuaCAMdHNv+hHBH0pQ7hMukFwqkwb105OfYm8 fnqA== X-Gm-Message-State: AOAM532K5ld+BfLqKeJJyhBqhmZbuMroT3tWTIK1q8iSQPjfWaAIUWFv qvSydS+s5sXa2AZeuujEqVp66ia7HJTzqP+cOMeUOA== X-Google-Smtp-Source: ABdhPJwKzVqKpDX9KBt9y8fPXoFH25yT6OCFViJDkBsmWi4+WIsb92nIDpsfYsvWT4Q0Jq4is2aH0qhBhL/vC1bjOoE= X-Received: by 2002:a17:90a:eb02:: with SMTP id j2mr842940pjz.136.1605210725310; Thu, 12 Nov 2020 11:52:05 -0800 (PST) MIME-Version: 1.0 References: <20201111182931.GM517454@elver.google.com> In-Reply-To: <20201111182931.GM517454@elver.google.com> From: Andrey Konovalov Date: Thu, 12 Nov 2020 20:51:52 +0100 Message-ID: Subject: Re: [PATCH v2 11/20] kasan: add and integrate kasan boot parameters To: Marco Elver Cc: Dmitry Vyukov , Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 7:29 PM Marco Elver wrote: > > > +#include > > +#include > > This should include -- although the rest of the > kernel seems to also inconsistently use on or the other. Since the name, > as referred to also by macros are "static keys", perhaps the > static_key.h header is more appropriate... Will fix. > > +enum kasan_arg_stacktrace { > > + KASAN_ARG_STACKTRACE_DEFAULT, > > It seems KASAN_ARG_STACKTRACE_DEFAULT is never used explicitly. Could > the switch statements just be changed to not have a 'default' but > instead refer to *DEFAULT where appropriate? We need to either cover all cases explicitly, or use default in each switch, otherwise there's a warning. I guess covering everything explicitly is a better approach, in case more values are added in the future, as we'll get warnings for those if they aren't covered in switches. Will do. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D54BFC2D0E4 for ; Thu, 12 Nov 2020 19:53:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61ACB2078D for ; Thu, 12 Nov 2020 19:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KQTmlWWC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="euZJ1KFs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61ACB2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FyZePvuC0iYX0wzoDG+78PlAtvzIiKaeG1QynEtYYlw=; b=KQTmlWWCqATO2G9vBK78eCAkD HiBVxgENTFfYfeRf3db4O4g2fBV400m1EqQxwsK5I3+yYEdfrGgmlBwf2oq6q5xfPrlxfsidkkqCN tfKfiDwaQLDc7E7fU5/acFvhb3+duoJFO5E2M/7y+1HzOUDe4Wm34PVlprl5U95ZRcuQiYRDDQJIj qcGLy54iaNFnHgYE++AWPckUGp7ag9sBd3+auFLe4Nl3reM6MFWwcCyL8eVhymlwtyvuwbR9hv6Vl QVLhIrsVbbGhKOPsyRIaGlGdMQmYux4pC07fUln4yt1iLqpe7l4/BQLm1foQeTUQd1dRGDnwtaLtS JurqLztkg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdIde-0003pA-Em; Thu, 12 Nov 2020 19:52:10 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdIdb-0003oK-M3 for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 19:52:08 +0000 Received: by mail-pg1-x541.google.com with SMTP id 34so1828224pgp.10 for ; Thu, 12 Nov 2020 11:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6grGTHRg8rsQq1ytOmJKPPc/a47JtcnHiEDyRqBbLFo=; b=euZJ1KFslUbqxplovouyxG8p0U+5+xuKJD4/GMN4ixlQJDzc/G0SQZTp3Fl2aryH9a jZuQg6p73xPEgXHx7QgnJGdxpcO43wqgWjrCEiigP6qhu0Z1ONy4LM69d5xWn5fqiAjf nKQRjWnb43kbs/G6nf27kwm0DIdmx4dezF7NZ18jeI0t3egMDcup0GnZ2C86V2fJPBJf O5Hjp9M28mx002EbXyvkABmb714LZbbKkBYqGZG7Sbv2lJZUBFQi+18Yw8nt7GZAmYC6 HR2kUslyxlb8trjZS5Y3X95dlNU7osxVXNTIhdobS1PtxwPkWIxUCsaMmLuKGdsZ3WpH Q9LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6grGTHRg8rsQq1ytOmJKPPc/a47JtcnHiEDyRqBbLFo=; b=K2bAmxkhGDo4xYHtgAFHpPvQto/i75CYl2i5HjOyv8+xxJMpXyR+ME9PQ/klO0nPaW XEHfqUJGgMDze+nMdvFPNtakOKFWI4rU8ZkSGktmupl7WrKQlKRKrM1Wtf/8KnoMs97h k67G5TcSaYqdC92XDMEep1QQZn5+WEFawV0w2hOYXkJHiEYSPJWVxWwBA3Xk3VV+nnfm h3b6rZlXIvFRFb9tRm/dPROruWlyZN1UqQlwpS25C6J0TMs4ypAKu+Sqf1xG9lgTnVAP /aqyXWPwbtUi8UhwsfQHd63f4EJCzMhZ/znO56bLEzeTs+H4fJXtjsUPamSFLPLoNeh2 Fbjg== X-Gm-Message-State: AOAM530euyPbE/awOfTWbTZgcrd//mwJ7BtcDhGVUn3wK62sXx+fYJ7V AH+H0C+FSCmIrH+/PuROr8PI6Z1pKey4Z8o6hA/r/w== X-Google-Smtp-Source: ABdhPJwKzVqKpDX9KBt9y8fPXoFH25yT6OCFViJDkBsmWi4+WIsb92nIDpsfYsvWT4Q0Jq4is2aH0qhBhL/vC1bjOoE= X-Received: by 2002:a17:90a:eb02:: with SMTP id j2mr842940pjz.136.1605210725310; Thu, 12 Nov 2020 11:52:05 -0800 (PST) MIME-Version: 1.0 References: <20201111182931.GM517454@elver.google.com> In-Reply-To: <20201111182931.GM517454@elver.google.com> From: Andrey Konovalov Date: Thu, 12 Nov 2020 20:51:52 +0100 Message-ID: Subject: Re: [PATCH v2 11/20] kasan: add and integrate kasan boot parameters To: Marco Elver X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_145207_787663_3A4CB6BA X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , LKML , kasan-dev , Linux Memory Management List , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 11, 2020 at 7:29 PM Marco Elver wrote: > > > +#include > > +#include > > This should include -- although the rest of the > kernel seems to also inconsistently use on or the other. Since the name, > as referred to also by macros are "static keys", perhaps the > static_key.h header is more appropriate... Will fix. > > +enum kasan_arg_stacktrace { > > + KASAN_ARG_STACKTRACE_DEFAULT, > > It seems KASAN_ARG_STACKTRACE_DEFAULT is never used explicitly. Could > the switch statements just be changed to not have a 'default' but > instead refer to *DEFAULT where appropriate? We need to either cover all cases explicitly, or use default in each switch, otherwise there's a warning. I guess covering everything explicitly is a better approach, in case more values are added in the future, as we'll get warnings for those if they aren't covered in switches. Will do. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel