From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B78C433DB for ; Mon, 8 Mar 2021 14:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56363651CD for ; Mon, 8 Mar 2021 14:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbhCHORQ (ORCPT ); Mon, 8 Mar 2021 09:17:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbhCHOQr (ORCPT ); Mon, 8 Mar 2021 09:16:47 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0342FC06174A for ; Mon, 8 Mar 2021 06:16:47 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id x7so3807969pfi.7 for ; Mon, 08 Mar 2021 06:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=o+U3uLj/MTWI/WnVGPqlD6bxQPjQLWYNbYeWyg5OtXhJZtnF5QsfwC6uq/PN/KqSBv L89RvIDZAM3pr6p4HBVvuwVIxP30I6MI2oVGpDIPZ4MWGA4EIUD/DYBLe1G/DlhbyyO0 GAQGMqfv8JxfVGyUqE/fRYcXPD2hKSNZvHR7MaBPuVCBR781NmjLLKKeCoNyuvxEIunj TkOz4nN/4iO7zf1Xg/osQmzUIG/2foVQ9VdONOGwCBPMVykxqhDI/kjKkaxXB2dMjaEw FJCBnL7b6tevkBWuzSrS300s5XtR62ewi1NA3iF1wlsx10TEtAwiv0pY4sJN1+xcXi7W Su5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=S1n2UAKqEimNbXF48+O9lbK9Um2274sPQtFMNTCuxQZ10iL98DFFUFNMRjaRdZ6jnp w+wfwDiGb0v6KacOqPN3h5oiyTo25Vy8OVAwdx5dvQDgh94yHn6QfEMPlCMdlXgsYzQY DH6o6a/rgLoFHr4pjx/s2RZ1sL7M+IGxd/vV+a4n+B8XvdIj4oieRLvjv0iqWC9UVM6v QWSUVqZKkL+OTAdRbY33jKPITeHI86Hg0UHyYxbxCPtVoD1Moovfoig7BEXVDRQ7C41N kN/1bUVT4A6xtlQqFJ3xkFVTflxV1kMOKWuLiqqpp8AoHyK+sHoSMn4USIXD5+zwrcCQ NYPg== X-Gm-Message-State: AOAM531dc6vxAoI9jbHZB3QdvXh50R/1KwC9FOk/2JUMbN7ciX5hO0hG /J+6q8/4OfNKD8XzpoLMXzLLwcOUVnOpBqxMy3v/Ew== X-Google-Smtp-Source: ABdhPJyAp/P5kFJMxbcLsevox5U3CG3+Kx9o3JHlkHdZvbegTiBwdTL3Q4As4bAkrSTLq5PRYZOymxznMF9dggO3H3U= X-Received: by 2002:a63:f14b:: with SMTP id o11mr20763989pgk.440.1615213006419; Mon, 08 Mar 2021 06:16:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 8 Mar 2021 15:16:35 +0100 Message-ID: Subject: Re: [PATCH 5/5] kasan, mm: integrate slab init_on_free with HW_TAGS To: Marco Elver Cc: Alexander Potapenko , Andrew Morton , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 8, 2021 at 12:45 PM Marco Elver wrote: > > > > > - if (unlikely(slab_want_init_on_free(cachep))) > > + /* > > + * As memory initialization is integrated with hardware tag-based > > This may no longer be true if the HW-tags architecture doesn't support > init (although currently it is certainly true). > > Perhaps: "As memory initialization may be accelerated by some KASAN > implementations (such as some HW_TAGS architectures) ..." > > or whatever else is appropriate. Will change the comment here and in other patches, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A086AC433E0 for ; Mon, 8 Mar 2021 14:16:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4494D6512B for ; Mon, 8 Mar 2021 14:16:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4494D6512B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CCA1A8D002F; Mon, 8 Mar 2021 09:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1FA8D001D; Mon, 8 Mar 2021 09:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B69658D002F; Mon, 8 Mar 2021 09:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 9C4368D001D for ; Mon, 8 Mar 2021 09:16:49 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5E7AB824999B for ; Mon, 8 Mar 2021 14:16:49 +0000 (UTC) X-FDA: 77896908138.03.6B68252 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf18.hostedemail.com (Postfix) with ESMTP id BCA242000383 for ; Mon, 8 Mar 2021 14:16:48 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id g4so6493075pgj.0 for ; Mon, 08 Mar 2021 06:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=o+U3uLj/MTWI/WnVGPqlD6bxQPjQLWYNbYeWyg5OtXhJZtnF5QsfwC6uq/PN/KqSBv L89RvIDZAM3pr6p4HBVvuwVIxP30I6MI2oVGpDIPZ4MWGA4EIUD/DYBLe1G/DlhbyyO0 GAQGMqfv8JxfVGyUqE/fRYcXPD2hKSNZvHR7MaBPuVCBR781NmjLLKKeCoNyuvxEIunj TkOz4nN/4iO7zf1Xg/osQmzUIG/2foVQ9VdONOGwCBPMVykxqhDI/kjKkaxXB2dMjaEw FJCBnL7b6tevkBWuzSrS300s5XtR62ewi1NA3iF1wlsx10TEtAwiv0pY4sJN1+xcXi7W Su5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=HPH3WhjFjmKiUDxLf3ex9JktsxugT+41sYYEvuqj/vBOLVVlsfsmOt/wjoAYph5Kmz jX6d6unp1vYiuZyIsxwTwE8QrwywAws/5rJD9qVkxlrwTuCFSAcSCEWU4WXqvK7hu3ep SkeiQSTLRr6clfj3HlifwSu8CNCm4dqQnInJSrOhHxK6+QhAYQ02v1y+4RbFJvjyXkFK xMnpblLyKWAu7GVtVXyzoLDdlQSG8YS2TcCDEEZekcvYlZunMHsYess5zf3JO7chgCkX a+o4qaJ6VD8WYmVNxqBnwt6PDqsBf4J81mtsAlHvw+XFH4wx6Z3/b8GhA77crPJAwxN8 FAGA== X-Gm-Message-State: AOAM533BC0z3L3xgAkeJzklF/hDkYpiGe4Zmamv8MRRfKz88UADY01Pv Td3TEsM2cNu+/FfkZBNOtnLbk0s3mJd/bk3pw18xbg== X-Google-Smtp-Source: ABdhPJyAp/P5kFJMxbcLsevox5U3CG3+Kx9o3JHlkHdZvbegTiBwdTL3Q4As4bAkrSTLq5PRYZOymxznMF9dggO3H3U= X-Received: by 2002:a63:f14b:: with SMTP id o11mr20763989pgk.440.1615213006419; Mon, 08 Mar 2021 06:16:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 8 Mar 2021 15:16:35 +0100 Message-ID: Subject: Re: [PATCH 5/5] kasan, mm: integrate slab init_on_free with HW_TAGS To: Marco Elver Cc: Alexander Potapenko , Andrew Morton , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 59z1j8fjxrtfc8qckopfs6ibnxrkyx4b X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BCA242000383 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-pg1-f179.google.com; client-ip=209.85.215.179 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615213008-538921 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 8, 2021 at 12:45 PM Marco Elver wrote: > > > > > - if (unlikely(slab_want_init_on_free(cachep))) > > + /* > > + * As memory initialization is integrated with hardware tag-based > > This may no longer be true if the HW-tags architecture doesn't support > init (although currently it is certainly true). > > Perhaps: "As memory initialization may be accelerated by some KASAN > implementations (such as some HW_TAGS architectures) ..." > > or whatever else is appropriate. Will change the comment here and in other patches, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA14C433DB for ; Mon, 8 Mar 2021 14:18:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E5CD651DC for ; Mon, 8 Mar 2021 14:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E5CD651DC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LUYNvnBX1sqQtYeCsf/AkGFUH1sikXWH+NHEPY682Eo=; b=dR5TeF/x9S7UT/r7SjmC8+haO LslRdJT1JNQLS8SvGym4STR1Ov7EAvBWW4rmqw4pAD4q1vHxWZCz2TUhXHiwW/vGk4FAAYYg5Pb1O cjo4J3p4DyjBGy71lkBPoLWUmQYvAech6BJ89SmuDQSWnqQsh/DgYbStEQ9w/0rr0x0YII2XzgDoN +nev1PyH+l/My9kuf0t5jrOCrKOkwc/D1t0bH7bS29vjqA5uVr3GdyIhu1DXq+b18TqgvijNdS4Ud ooRftrZLYGq5ipYb2xkhgj8LNV617qwzkjOIzDpeqKPMtMUKCZnLfWkf0vnUFSZ66W7jD5qlf7sjx X1N85TBsA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJGgo-000ATW-0A; Mon, 08 Mar 2021 14:16:54 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJGgi-000ARO-4A for linux-arm-kernel@lists.infradead.org; Mon, 08 Mar 2021 14:16:50 +0000 Received: by mail-pg1-x529.google.com with SMTP id a4so6491935pgc.11 for ; Mon, 08 Mar 2021 06:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=o+U3uLj/MTWI/WnVGPqlD6bxQPjQLWYNbYeWyg5OtXhJZtnF5QsfwC6uq/PN/KqSBv L89RvIDZAM3pr6p4HBVvuwVIxP30I6MI2oVGpDIPZ4MWGA4EIUD/DYBLe1G/DlhbyyO0 GAQGMqfv8JxfVGyUqE/fRYcXPD2hKSNZvHR7MaBPuVCBR781NmjLLKKeCoNyuvxEIunj TkOz4nN/4iO7zf1Xg/osQmzUIG/2foVQ9VdONOGwCBPMVykxqhDI/kjKkaxXB2dMjaEw FJCBnL7b6tevkBWuzSrS300s5XtR62ewi1NA3iF1wlsx10TEtAwiv0pY4sJN1+xcXi7W Su5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=OGoj1+fObdBhWJGlZtcw4dKnOvHfK3dioL+3lZmYuP7Y8jDz5+Df5clFMJtPNAsHlJ mGBkkDmxWqUi/4Zit+qpl8NoONA8aL22AIrMFeN13UCIwopiDqzecYxjv2+U0V5yDlsA Oi6S1BvIYsoAZrbkt9j3pl3BuVXRDnmgPkXDSrhEiH1ybZSTXKpgXVr7hmzLu/zxNaK7 lFRkUpq6SptumoWYGOk6niirUaiyoua3GNrNYWJs9tq9BX0tqvu/hAhwKZQkfbwR+edB FOFEYEv3DJYU1KZ4Sy9IBGhOB7eFoTZ8XAPl+P2Yc27lHAJvV8wH5xdyUOXrhRo7kY5Y tHWA== X-Gm-Message-State: AOAM533sw+45a5B21ToyG/aex66hhkLJtFT7TZoTDxemOgpI7Ehyadb/ +793iEgN5eZ9pkHC3rsFQFDNfR/Hc89T0UYJpfy0tw== X-Google-Smtp-Source: ABdhPJyAp/P5kFJMxbcLsevox5U3CG3+Kx9o3JHlkHdZvbegTiBwdTL3Q4As4bAkrSTLq5PRYZOymxznMF9dggO3H3U= X-Received: by 2002:a63:f14b:: with SMTP id o11mr20763989pgk.440.1615213006419; Mon, 08 Mar 2021 06:16:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 8 Mar 2021 15:16:35 +0100 Message-ID: Subject: Re: [PATCH 5/5] kasan, mm: integrate slab init_on_free with HW_TAGS To: Marco Elver Cc: Alexander Potapenko , Andrew Morton , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_141648_456312_71F354A3 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 8, 2021 at 12:45 PM Marco Elver wrote: > > > > > - if (unlikely(slab_want_init_on_free(cachep))) > > + /* > > + * As memory initialization is integrated with hardware tag-based > > This may no longer be true if the HW-tags architecture doesn't support > init (although currently it is certainly true). > > Perhaps: "As memory initialization may be accelerated by some KASAN > implementations (such as some HW_TAGS architectures) ..." > > or whatever else is appropriate. Will change the comment here and in other patches, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel