All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@google.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Marco Elver <elver@google.com>
Subject: Re: [PATCH] kasan, mm: fix build issue with asmlinkage
Date: Mon, 30 Nov 2020 16:21:41 +0100	[thread overview]
Message-ID: <CAAeHK+xn=aOq7vU0FKNDj8txU6y05g-5=mnkcn3RsWJsoPCfFg@mail.gmail.com> (raw)
In-Reply-To: <CANpmjNObtKCG3PPdDRrFczHU3wUnybTqp-F2tMx4CB1T+bThwg@mail.gmail.com>

On Mon, Nov 30, 2020 at 10:46 AM Marco Elver <elver@google.com> wrote:
>
> On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> > commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> > Author: Andrey Konovalov <andreyknvl@google.com>
> > Date:   Tue Nov 24 16:45:08 2020 +1100
> >
> >     kasan: shadow declarations only for software modes
> >
> > introduces a build failure when it removed an include for linux/pgtable.h
> > It actually only needs linux/linkage.h
> >
> > Test builds on both x86_64 and arm build cleanly
> >
> > Fixes:   2df573d2ca4c ("kasan: shadow declarations only for software modes")
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
> Reviewed-by: Marco Elver <elver@google.com>
>
> Probably want to add
>
>   Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
>
> for more context, too.

Reviewed-by: Andrey Konovalov <andreyknvl@google.com>

Thank you, Valdis!

WARNING: multiple messages have this Message-ID
From: Andrey Konovalov <andreyknvl@google.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Marco Elver <elver@google.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	kasan-dev <kasan-dev@googlegroups.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] kasan, mm: fix build issue with asmlinkage
Date: Mon, 30 Nov 2020 16:21:41 +0100	[thread overview]
Message-ID: <CAAeHK+xn=aOq7vU0FKNDj8txU6y05g-5=mnkcn3RsWJsoPCfFg@mail.gmail.com> (raw)
In-Reply-To: <CANpmjNObtKCG3PPdDRrFczHU3wUnybTqp-F2tMx4CB1T+bThwg@mail.gmail.com>

On Mon, Nov 30, 2020 at 10:46 AM Marco Elver <elver@google.com> wrote:
>
> On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> > commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> > Author: Andrey Konovalov <andreyknvl@google.com>
> > Date:   Tue Nov 24 16:45:08 2020 +1100
> >
> >     kasan: shadow declarations only for software modes
> >
> > introduces a build failure when it removed an include for linux/pgtable.h
> > It actually only needs linux/linkage.h
> >
> > Test builds on both x86_64 and arm build cleanly
> >
> > Fixes:   2df573d2ca4c ("kasan: shadow declarations only for software modes")
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
> Reviewed-by: Marco Elver <elver@google.com>
>
> Probably want to add
>
>   Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
>
> for more context, too.

Reviewed-by: Andrey Konovalov <andreyknvl@google.com>

Thank you, Valdis!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-30 15:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 15:00 Valdis Klētnieks
2020-11-26 15:00 ` Valdis Klētnieks
2020-11-30  9:46 ` Marco Elver
2020-11-30  9:46   ` Marco Elver
2020-11-30 15:21   ` Andrey Konovalov [this message]
2020-11-30 15:21     ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeHK+xn=aOq7vU0FKNDj8txU6y05g-5=mnkcn3RsWJsoPCfFg@mail.gmail.com' \
    --to=andreyknvl@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=elver@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=valdis.kletnieks@vt.edu \
    --subject='Re: [PATCH] kasan, mm: fix build issue with asmlinkage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.