From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965170AbeALQuC (ORCPT + 1 other); Fri, 12 Jan 2018 11:50:02 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:37706 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964814AbeALQuA (ORCPT ); Fri, 12 Jan 2018 11:50:00 -0500 X-Google-Smtp-Source: ACJfBot4PklsTqkmtNSUwNcCr3GuOniV311DaF4oaK8Fag9HPySjWQjAP1Qhwt8QOIMIdeK6JF6eJfPnVQ1QOi4FPcw= MIME-Version: 1.0 In-Reply-To: References: From: Andrey Konovalov Date: Fri, 12 Jan 2018 17:49:57 +0100 Message-ID: Subject: Re: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage To: Andrey Ryabinin Cc: Alexander Potapenko , Dmitry Vyukov , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , kasan-dev , Linux Memory Management List , linux-arm-kernel@lists.infradead.org, "the arch/x86 maintainers" , LKML , Kostya Serebryany Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 10:59 PM, Andrey Ryabinin wrote: > > > On 01/11/2018 06:29 PM, Andrey Konovalov wrote: > >> diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h >> index e266f80e45b7..811643fe7640 100644 >> --- a/arch/arm64/include/asm/kasan.h >> +++ b/arch/arm64/include/asm/kasan.h >> @@ -27,7 +27,8 @@ >> * should satisfy the following equation: >> * KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61) > > Care to update comments as well? Sure, done in v2. > >> */ >> -#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << (64 - 3))) >> +#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << \ >> + (64 - KASAN_SHADOW_SCALE_SHIFT))) >> >> void kasan_init(void); >> void kasan_copy_shadow(pgd_t *pgdir); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f72.google.com (mail-oi0-f72.google.com [209.85.218.72]) by kanga.kvack.org (Postfix) with ESMTP id A84E56B0261 for ; Fri, 12 Jan 2018 11:49:59 -0500 (EST) Received: by mail-oi0-f72.google.com with SMTP id i66so747865oih.5 for ; Fri, 12 Jan 2018 08:49:59 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b47sor8500092oth.255.2018.01.12.08.49.58 for (Google Transport Security); Fri, 12 Jan 2018 08:49:58 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Andrey Konovalov Date: Fri, 12 Jan 2018 17:49:57 +0100 Message-ID: Subject: Re: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Andrey Ryabinin Cc: Alexander Potapenko , Dmitry Vyukov , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , kasan-dev , Linux Memory Management List , linux-arm-kernel@lists.infradead.org, the arch/x86 maintainers , LKML , Kostya Serebryany On Thu, Jan 11, 2018 at 10:59 PM, Andrey Ryabinin wrote: > > > On 01/11/2018 06:29 PM, Andrey Konovalov wrote: > >> diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h >> index e266f80e45b7..811643fe7640 100644 >> --- a/arch/arm64/include/asm/kasan.h >> +++ b/arch/arm64/include/asm/kasan.h >> @@ -27,7 +27,8 @@ >> * should satisfy the following equation: >> * KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61) > > Care to update comments as well? Sure, done in v2. > >> */ >> -#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << (64 - 3))) >> +#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << \ >> + (64 - KASAN_SHADOW_SCALE_SHIFT))) >> >> void kasan_init(void); >> void kasan_copy_shadow(pgd_t *pgdir); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: andreyknvl@google.com (Andrey Konovalov) Date: Fri, 12 Jan 2018 17:49:57 +0100 Subject: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 11, 2018 at 10:59 PM, Andrey Ryabinin wrote: > > > On 01/11/2018 06:29 PM, Andrey Konovalov wrote: > >> diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h >> index e266f80e45b7..811643fe7640 100644 >> --- a/arch/arm64/include/asm/kasan.h >> +++ b/arch/arm64/include/asm/kasan.h >> @@ -27,7 +27,8 @@ >> * should satisfy the following equation: >> * KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61) > > Care to update comments as well? Sure, done in v2. > >> */ >> -#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << (64 - 3))) >> +#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << \ >> + (64 - KASAN_SHADOW_SCALE_SHIFT))) >> >> void kasan_init(void); >> void kasan_copy_shadow(pgd_t *pgdir);