From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A2BC2D0EA for ; Wed, 8 Apr 2020 15:53:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A93020730 for ; Wed, 8 Apr 2020 15:53:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="J6W9o6yE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A93020730 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 230D78E000D; Wed, 8 Apr 2020 11:53:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E18D8E0006; Wed, 8 Apr 2020 11:53:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D0928E000D; Wed, 8 Apr 2020 11:53:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id E88A68E0006 for ; Wed, 8 Apr 2020 11:53:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B06F3440B for ; Wed, 8 Apr 2020 15:53:17 +0000 (UTC) X-FDA: 76685132034.19.map68_1cb829433aa26 X-HE-Tag: map68_1cb829433aa26 X-Filterd-Recvd-Size: 7369 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Apr 2020 15:53:17 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id c23so3508568pgj.3 for ; Wed, 08 Apr 2020 08:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/oDZZ2MbTzO9wnVaGRPSvfuPsJci0n6LlPxvqykCqUs=; b=J6W9o6yEopjoLEMZhgq6ZXNAO8O2/T7LbDBzPM58IkZF84GDRqpWHoQm0dCTnJaI4f vaafTk2/SaTlG7A6oalHV6Sp93tFnN9gomzSN6tfo5BvKLxLtt4nU7FtcYB9hEpIlz5o ZhaMrJg1RHVVKqGNX8jIVV+rgMr7cROZxwu5SAg71q68b4otyLhh87YFpTtfLfN5WT7i 7LynOC1+t+MRgQnvpl9NwpvTvhBEn1dJFwswbLItUTs84UaaoJvLQFMe4B9sbstow5hB NoknLKQeua3rJErJ8AR1wIyVk4K5vEpCA4Z/Ph4yaVsGkaJaFygAVICXBboErTJ72I4C ioOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/oDZZ2MbTzO9wnVaGRPSvfuPsJci0n6LlPxvqykCqUs=; b=mRP7T8t/cpJzi/WJGNnLz5TeJVVR7WRCI3uP3u+TJQD3W0DFfxEkTqxvovU3uCaeCN micrq6T10+uyBJQFWVWBeDTSuNPeWwyW+5hP3JniUV7WaCt/rcIwARdLRRZ+971S8krL 7eHngc2b8etRvTCa2bIKcbpmtWUbV5DDfq9Uw4ixTWgFHKxbtdV3YbO5JJqMqDST58D8 oA2ITO+1nJZvrXVlA+/bAR8PBkDfVzeePNBAzUe4dIVBcGXMuJn31QwY5/IZWfLvkRTu 0rTlWMq36JWswBRnyV11NBDhG2fmzZbAPJWA6yhfGxwmAx3clzkNn3KvN/6YwsXnrkGe LeeA== X-Gm-Message-State: AGi0PubY5aIRQKZ3DkobiCzX9NriBt2+O0Pwq12M5Z+wZX2erLaA0BJx 2/xyFxAFR/2dVFaB8wuUUNqGzO8A16/lN9+IO/kLKg== X-Google-Smtp-Source: APiQypIfnn0YXbsgn2nAnp1JhPyTKmD9gpnS/0Q769oZUoIx3fgN0iO/R3o1L48XQHh7kb6Yh7euYYgEpDm7BA05u2g= X-Received: by 2002:a62:55c2:: with SMTP id j185mr8736312pfb.318.1586361195504; Wed, 08 Apr 2020 08:53:15 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-37-glider@google.com> In-Reply-To: <20200325161249.55095-37-glider@google.com> From: Andrey Konovalov Date: Wed, 8 Apr 2020 17:53:04 +0200 Message-ID: Subject: Re: [PATCH v5 36/38] x86: kasan: kmsan: support CONFIG_GENERIC_CSUM on x86, enable it for KASAN/KMSAN To: Alexander Potapenko Cc: Arnd Bergmann , Michal Simek , Andrey Ryabinin , Vegard Nossum , Dmitry Vyukov , Marco Elver , Randy Dunlap , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrew Morton , Andy Lutomirski , Ard Biesheuvel , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Hocko , Petr Mladek , Qian Cai , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:14 PM wrote: > > This is needed to allow memory tools like KASAN and KMSAN see the > memory accesses from the checksum code. Without CONFIG_GENERIC_CSUM the > tools can't see memory accesses originating from handwritten assembly > code. > For KASAN it's a question of detecting more bugs, for KMSAN using the C > implementation also helps avoid false positives originating from > seemingly uninitialized checksum values. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Arnd Bergmann > Cc: Michal Simek > Cc: Andrey Ryabinin > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: Randy Dunlap > Cc: linux-mm@kvack.org Reviewed-by: Andrey Konovalov > --- > > v2: > - dropped the "default n" (as requested by Randy Dunlap) > > v4: > - changed "net:" to "x86:" in the patch name > > Change-Id: I645e2c097253a8d5717ad87e2e2df6f6f67251f3 > --- > arch/x86/Kconfig | 4 ++++ > arch/x86/include/asm/checksum.h | 10 +++++++--- > arch/x86/lib/Makefile | 2 ++ > 3 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 376c13480def2..c45c937682863 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -274,6 +274,10 @@ config GENERIC_ISA_DMA > def_bool y > depends on ISA_DMA_API > > +config GENERIC_CSUM > + bool > + default y if KMSAN || KASAN > + > config GENERIC_BUG > def_bool y > depends on BUG > diff --git a/arch/x86/include/asm/checksum.h b/arch/x86/include/asm/checksum.h > index d79d1e622dcf1..ab3464cbce26d 100644 > --- a/arch/x86/include/asm/checksum.h > +++ b/arch/x86/include/asm/checksum.h > @@ -1,6 +1,10 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -#ifdef CONFIG_X86_32 > -# include > +#ifdef CONFIG_GENERIC_CSUM > +# include > #else > -# include > +# ifdef CONFIG_X86_32 > +# include > +# else > +# include > +# endif > #endif > diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile > index 6110bce7237bd..40d6704c4767d 100644 > --- a/arch/x86/lib/Makefile > +++ b/arch/x86/lib/Makefile > @@ -64,7 +64,9 @@ endif > lib-$(CONFIG_X86_USE_3DNOW) += mmx_32.o > else > obj-y += iomap_copy_64.o > +ifneq ($(CONFIG_GENERIC_CSUM),y) > lib-y += csum-partial_64.o csum-copy_64.o csum-wrappers_64.o > +endif > lib-y += clear_page_64.o copy_page_64.o > lib-y += memmove_64.o memset_64.o > lib-y += copy_user_64.o > -- > 2.25.1.696.g5e7596f4ac-goog >