From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109C1C2BB1D for ; Fri, 13 Mar 2020 14:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC2A6206FA for ; Fri, 13 Mar 2020 14:56:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cx2qTH6s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbgCMO4t (ORCPT ); Fri, 13 Mar 2020 10:56:49 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37979 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbgCMO4t (ORCPT ); Fri, 13 Mar 2020 10:56:49 -0400 Received: by mail-pl1-f195.google.com with SMTP id w3so4362588plz.5 for ; Fri, 13 Mar 2020 07:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p6VRmjxt/RLuEV3vnRanaLSMonZS+QrB7w914S386sk=; b=cx2qTH6sC970pnUA6vaQYxDBliAsFLKpx5jgY/1l7mE1/koc3rjku94As1o/Q1Giwc lh5Ov0bnx2tmzuty4qSKnHAhRLLijzBjLNbfd92vBUi+Xo7SYQq5nLEu5pgYvkQQooir oDAN6iKicD+pDQoGrYezZSUB72PeP0bHomMLvT5TVYJL5ZAK5dLeSAL2MKOAJDcSyDlb 8F/+0XzLtjTWok0EoOeCCPMzMXcLjWsL8yuMLkIueMfM1vW0xVizPRB25FIiBz/DHe7M vf0nPC0/NxdiKx8RYjo11F2plWtpyA7aS2UTtn5PCKUIM5P96c+XNiFwvXayVNkWUQco D5/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p6VRmjxt/RLuEV3vnRanaLSMonZS+QrB7w914S386sk=; b=qtdJ5pY+gOgC4D+W/3wrLncgHsHO+6be6q9KdOkwCsBYQ+pCa+jtjXfVbiwj7w3jzS stcUm+6U9O0fgZ+BfFCFAA96xbuYhEgap6meQrfXsAkajZpPMthHZvXAdk1pMIJ7qtbw Sry6lZqt2emIBV+3y0Tkhr7j2MN62SSEenqMLy6Wb6chwJ8TQSHVQq20Dc6ZxyoqA/fH jRruj7o5suwIBg9zKf0mEX9JS5RGvrGcmG78mxvbMKfMUMq8BakC66nULl9BAGyV6p4h eReB9z6lTvsMSwriusYp1kwj7wWGNLnEk1wxCEUEcPOfPTThJk41uzR/ZioIYksvWFrg MOLg== X-Gm-Message-State: ANhLgQ3LesKn188RpVG+eHzNbTM2lSr/H8wyX0z8CTzNMPqBjgPE3PiN enMxKBg6S2zX3KdkekAmojGwfJWJ42dM8T8WSytzYQ== X-Google-Smtp-Source: ADFU+vuhhw0Ig3FeJf7sHNwTyURe80VBP0AJ5DzMG6Pzz6M4bqpHJu5itSRP30AMNbYDh7Ql5moWNWo2vTsmwOM/MPc= X-Received: by 2002:a17:902:8492:: with SMTP id c18mr14107191plo.147.1584111406059; Fri, 13 Mar 2020 07:56:46 -0700 (PDT) MIME-Version: 1.0 References: <32bce32c8b88c2f88cd0a8acfcdb5d3a6e894632.1583778264.git.andreyknvl@google.com> <20200312093920.GD14625@b29397-desktop> In-Reply-To: <20200312093920.GD14625@b29397-desktop> From: Andrey Konovalov Date: Fri, 13 Mar 2020 15:56:35 +0100 Message-ID: Subject: Re: [PATCH v2 3/3] usb: core: kcov: collect coverage from usb complete callback To: Peter Chen Cc: Dmitry Vyukov , Greg Kroah-Hartman , Alan Stern , Andrew Morton , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alexander Potapenko , Marco Elver Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 10:39 AM Peter Chen wrote: > > On 20-03-09 19:27:06, Andrey Konovalov wrote: > > This patch adds kcov_remote_start/stop() callbacks around the urb > > complete() callback that is executed in softirq context when dummy_hcd > > is in use. As the result, kcov can be used to collect coverage from those > > those callbacks, which is used to facilitate coverage-guided fuzzing with > > Typo, One more "those" Will fix in v3, thanks Peter! > > Peter > > > syzkaller. > > > > Signed-off-by: Andrey Konovalov > > --- > > drivers/usb/core/hcd.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > > index aa45840d8273..de624c47e190 100644 > > --- a/drivers/usb/core/hcd.c > > +++ b/drivers/usb/core/hcd.c > > @@ -31,6 +31,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -1645,7 +1646,9 @@ static void __usb_hcd_giveback_urb(struct urb *urb) > > > > /* pass ownership to the completion handler */ > > urb->status = status; > > + kcov_remote_start_usb((u64)urb->dev->bus->busnum); > > urb->complete(urb); > > + kcov_remote_stop(); > > > > usb_anchor_resume_wakeups(anchor); > > atomic_dec(&urb->use_count); > > -- > > 2.25.1.481.gfbce0eb801-goog > > > > -- > > Thanks, > Peter Chen