From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2DA8C43331 for ; Mon, 30 Mar 2020 13:37:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D0F720771 for ; Mon, 30 Mar 2020 13:37:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="P3E+OshQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D0F720771 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E29D96B0032; Mon, 30 Mar 2020 09:37:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB3566B0037; Mon, 30 Mar 2020 09:37:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7BF96B006C; Mon, 30 Mar 2020 09:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id AE9CE6B0032 for ; Mon, 30 Mar 2020 09:37:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 827594DDB for ; Mon, 30 Mar 2020 13:37:41 +0000 (UTC) X-FDA: 76652131122.29.smash35_431ac87a4aa0d X-HE-Tag: smash35_431ac87a4aa0d X-Filterd-Recvd-Size: 6705 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Mar 2020 13:37:41 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id d24so2892803pll.8 for ; Mon, 30 Mar 2020 06:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yjgKkoyIuroWlOLq0r/c7Ge6BXeCQu1fvq4rtwS5nJU=; b=P3E+OshQf+0IXETCE8g/tnK6gj3QboBpUZeAoZVRNIsnKqV28naDAvtuTehjpTKjwP v3xrn9DAOYRi0VyFy2hAN5C6SQjFpHRTAX2TgzZXQCA++C/rRG+0OPEZL6wCYYP4Ntwu wh5Z7avfkJgphmkiR/AtggpZQh65UhYirTBT/XB4irTySUTMym/R3bniSSWMNW3yATVr 2VZpXmEw7RRXFOEBleNvsA/umeu1UNcP/18RIM6PkWLWiDEBBiASTXFMQGDmptAZ+Aq5 Rutq9HXviLjm+B4OQ+TrsgVaGCtxkCz4An2rSqpqGxenPm8T4qwwZsIB/AGO3gSQ70OU PGjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yjgKkoyIuroWlOLq0r/c7Ge6BXeCQu1fvq4rtwS5nJU=; b=sKoKvj0lgexkOrQoiPEpcP9HtI/b6koDiyaskaUWsK2LvYKUwA8VBBFL0F84mFY1H5 LAqgnDm2U/xSt/jxQ80ZJTv34Bu8OXm3SW80bL6HnAHt+f6pCnPs1uc7JQYpRqTFa+kF Uo1K65+LO5rCoJg6ZtjIJ2pdJGRnFx79jSxl58smWz8eARBIYtV/PuvHAsHsVJegx+/Y w35qS0l83Q+2uxpK6DBMlqBtdweeckqv6Gx8YvgfbFHnUHJfO1SqlPL/CYTnNzH7xP5R bC/Bm8gSEkk39jCe1xx0YnFf4Ut6eCd55/ibSL+q0mZXNP5Awy5x3A/0vEJ5e7I8FK3v jk4Q== X-Gm-Message-State: ANhLgQ2xGG0XhUWD1GqRS7XRtkM/7Y79ZKaSCeNg5ZMM1XhVJaZb1ffG hm/ZrrNb+5dctBGHwSItmheBprTaNu5Vvbt/mACSTw== X-Google-Smtp-Source: ADFU+vu5VSIxUs/IrOvAZy1hg42EZ0t/RXzAooFUMAPPv2b3SMwtVh3T75GyUHT2OV3HCwlAzCavzl6MzdZWEss7nhw= X-Received: by 2002:a17:902:8c94:: with SMTP id t20mr12370504plo.336.1585575459738; Mon, 30 Mar 2020 06:37:39 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-5-glider@google.com> In-Reply-To: <20200325161249.55095-5-glider@google.com> From: Andrey Konovalov Date: Mon, 30 Mar 2020 15:37:28 +0200 Message-ID: Subject: Re: [PATCH v5 04/38] kmsan: introduce __no_sanitize_memory and __SANITIZE_MEMORY__ To: Alexander Potapenko Cc: Vegard Nossum , Dmitry Vyukov , Marco Elver , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Hocko , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:13 PM wrote: > > __no_sanitize_memory is a function attribute that makes KMSAN > ignore the uninitialized values coming from the function's > inputs, and initialize the function's outputs. > > Functions marked with this attribute can't be inlined into functions > not marked with it, and vice versa. > > __SANITIZE_MEMORY__ is a macro that's defined iff the file is > instrumented with KMSAN. This is not the same as CONFIG_KMSAN, which is > defined for every file. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: linux-mm@kvack.org > Acked-by: Marco Elver Reviewed-by: Andrey Konovalov > > --- > > v4: > - dropped an unnecessary comment as requested by Marco Elver > > Change-Id: I1f1672652c8392f15f7ca8ac26cd4e71f9cc1e4b > --- > include/linux/compiler-clang.h | 7 +++++++ > include/linux/compiler-gcc.h | 5 +++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > index 2cb42d8bdedc6..d4f929b4a6705 100644 > --- a/include/linux/compiler-clang.h > +++ b/include/linux/compiler-clang.h > @@ -33,6 +33,13 @@ > #define __no_sanitize_thread > #endif > > +#if __has_feature(memory_sanitizer) > +# define __SANITIZE_MEMORY__ > +# define __no_sanitize_memory __attribute__((no_sanitize("kernel-memory"))) > +#else > +# define __no_sanitize_memory > +#endif > + > /* > * Not all versions of clang implement the the type-generic versions > * of the builtin overflow checkers. Fortunately, clang implements > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index cf294faec2f87..1121557252f88 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -151,6 +151,11 @@ > #define __no_sanitize_thread > #endif > > +/* > + * GCC doesn't support KMSAN. > + */ > +#define __no_sanitize_memory > + > #if GCC_VERSION >= 50100 > #define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1 > #endif > -- > 2.25.1.696.g5e7596f4ac-goog >