From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66410C4338F for ; Wed, 11 Aug 2021 10:23:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85B1A601FF for ; Wed, 11 Aug 2021 10:23:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85B1A601FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 42A2782DA3; Wed, 11 Aug 2021 12:23:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.b="MtyWm7eq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F43F82DB0; Wed, 11 Aug 2021 12:23:53 +0200 (CEST) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 13F4282D7C for ; Wed, 11 Aug 2021 12:23:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=philipp.tomsich@vrull.eu Received: by mail-wm1-x333.google.com with SMTP id k5-20020a05600c1c85b02902e699a4d20cso1595421wms.2 for ; Wed, 11 Aug 2021 03:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=K3oMx6N73PLL2EkmV09wWXM0ARS8sDRXyhI00944UGM=; b=MtyWm7eqWi8pf2rdrisFombqjMncW5yBDEYYqCAEYRQ9pbTir3rets+7O8PlbUlCRD MGfKqCffKyUgyBWHIL5S8OBY6dLambsTe4aqft6L75kaWmBrZWv+GdSJjBH4DEt59y5l b4OpyYqHPDuHl63prVMk5RLH4FfmaujdssM0CqslEhVs9Br6ZQIhx5xD7WpgBM8sOUTr KmmIsRJKXa0wfwWUF/+nYgJTWk3MySJZ26IdNAZqyXEIvjbs6fQFzxkGbniZVw9nxaEM 5qW+Gq/sgL6zBa96kHsmf+aCSfZ91NBLFhTCvnJ0BRF0oZ0ewGyVOw7cUNf27GhVtePq 88ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=K3oMx6N73PLL2EkmV09wWXM0ARS8sDRXyhI00944UGM=; b=V211zR5uSxlPCdu2sHon1xUoZdI3r2dyqAz76LqPcM/ylr/cJn2MoPSZDBrgL8sN94 8uVXLNHlnqR/ziBClCY0IvtTJtME/Sk7e4SBrp82lX6rTwGb3DMAQLHAJvzNHXy2qjNa +ppJoX+BcaMNq05XI0zMGjZtPnSaHE10SaFeOqqwkb/SpUBI2+GhmJj7m9uplfjXnBAk Zg8vj4nxrBpWIzgBbFebDUETkL/1uXQWfrdEU49hZSlxy4eFJcxqjU3zkje0jHycz4Js yub5oPO0ySuDWbJEofO4mBI6oeCwJ7TTTrJ7589HOspTqSKPZ0EhtdNHO0gFZVv+mvpQ LaIA== X-Gm-Message-State: AOAM530nEUfWPeJTg30rnaxRNCQIbkWq1wmLs9huR9lPHE8mMNmIKYkJ 9zrX3T57CGmxZAAN9yRkC3d4hzZ8n01dkaaejTtujw== X-Google-Smtp-Source: ABdhPJwY6nd4ZrUcV7sTtP4UR2bXQL89xPrSL1lu3aB5iuGUgSVzsd4RtgwPJbQu3rkcZHsSVi2d+6zc2mAIf1RpPtA= X-Received: by 2002:a1c:e919:: with SMTP id q25mr22477469wmc.28.1628677428628; Wed, 11 Aug 2021 03:23:48 -0700 (PDT) MIME-Version: 1.0 References: <20210629082443.22308-1-yifeng.zhao@rock-chips.com> <20210629082443.22308-3-yifeng.zhao@rock-chips.com> In-Reply-To: <20210629082443.22308-3-yifeng.zhao@rock-chips.com> From: Philipp Tomsich Date: Wed, 11 Aug 2021 12:23:38 +0200 Message-ID: Subject: Re: [PATCH v3 2/3] mmc: rockchip_sdhci: Add support for RK3568 To: Yifeng Zhao Cc: Jaehoon Chung , sjg , Kever Yang , Peng Fan , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 29 Jun 2021 at 10:24, Yifeng Zhao wrot= e: > > This patch adds support for the RK3568 platform to this driver. > > Signed-off-by: Yifeng Zhao I thought I had raised an objection to this patch previously, but did not see a discussion... So here we go again. In 2017, we decided to split the HDMI drivers such that there is a common core driver and a "mini-driver" wrapping it, so we don't pull in the extra code for every chip. See the original comment from Simon at https://patchwork.ozlabs.org/project/uboot/patch/1493394792-20743-4-git-= send-email-philipp.tomsich@theobroma-systems.com/#1648072 Given that we established that pattern already=E2=80=94and that there are practical benefits (e.g., in code-size), we should follow the same pattern for the SDHCI drive= r. Thank you, Philipp.