From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B587C433EF for ; Wed, 9 Feb 2022 04:52:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B978E49EFE; Tue, 8 Feb 2022 23:52:07 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yqFJsTkvz77m; Tue, 8 Feb 2022 23:52:06 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B91F549EFF; Tue, 8 Feb 2022 23:52:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F036549ED8 for ; Tue, 8 Feb 2022 23:52:05 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pv+z7tkphR1t for ; Tue, 8 Feb 2022 23:52:04 -0500 (EST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 97AA749EBE for ; Tue, 8 Feb 2022 23:52:04 -0500 (EST) Received: by mail-pf1-f170.google.com with SMTP id i186so2357642pfe.0 for ; Tue, 08 Feb 2022 20:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PR9huqMPKoKBRfN5n+K9Fdcj8rjbPiaTb5ftDSq6ZW8=; b=tQaAa/Eoya61ibJVdVxszqGG/UfmlZZiGR7xPsfkCDCEkdWlPtzGXjJApJX5e+FU9+ wmn39wUvZIjraVZ+MZFPURdjeDgkcL2Ky+XpOYKD90Qr2JSLE4h7QDc8WD8aboPNBK4z 74YHsm0O699dnj3zabAnBzANeZ0MyIJAj140UZqIxCqL5aOnbKkBgiAQ40c+6rjuzah7 Mih047zYSw7TfkZGwqxqvV7SeHajB7IsYZRetsE9/ZBa+GFsdGgdPyQyoxkbvYKat+jh OqHjGLs+zpREYER9xZHySaCZ1+bLpAFxt3vfiHtS2RL3UtVB/y9BrkN58Kh1nsUx25hr mbzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PR9huqMPKoKBRfN5n+K9Fdcj8rjbPiaTb5ftDSq6ZW8=; b=DpARItimj4vYtIaD0T8e6hzlZGWi2KkdHlibqC6ic+fHVz+wbhePtVOLUk4ZDWycvE Q1wLaEeZv0d+saZE52WYtTEiJth4Dkcvqyx+lWgCQ82RH4c/I5Vz059m/YmAX8bhRExJ C5k8yw1Th24ejTD79++cRMl/4qIMUcyfcsrKxRfb79epwH0CRfqIVjJaQcBWQ6BygqQB BaFQuRO+e1lhs+qQ+pbDSO1XuLmd90g2zO+Y7V7MjzWIONzXhwz6fuDzot8Mdi/1YLOY s/cXlJ17hcqoh3zGznKrh44qwse33LuJ6Y9ooNi6WQSPwE+sfcb6TtuZy2NAHQUUM1Wo ei6w== X-Gm-Message-State: AOAM533OWuoSoURg+I9XOtD9a9TZbXwKnxy0bI6zdXXDCuJ+YMhQ1xwN GXFNeKQQAz3a81wWZigEVUC8bBwP7kCPBd9og6DHLQ== X-Google-Smtp-Source: ABdhPJyJlqEofZ7FNvhCVWK/Fj3kLxyOD4l5cf2Tx4Vqf1uOnZGRpCs5oYUnLgprJaxq8w4j07PtbuNWc1rPBvp8/4I= X-Received: by 2002:a63:2b4d:: with SMTP id r74mr547546pgr.514.1644382323360; Tue, 08 Feb 2022 20:52:03 -0800 (PST) MIME-Version: 1.0 References: <20220106042708.2869332-1-reijiw@google.com> <20220106042708.2869332-24-reijiw@google.com> In-Reply-To: From: Reiji Watanabe Date: Tue, 8 Feb 2022 20:51:47 -0800 Message-ID: Subject: Re: [RFC PATCH v4 23/26] KVM: arm64: Trap disabled features of ID_AA64MMFR1_EL1 To: Fuad Tabba Cc: kvm@vger.kernel.org, Marc Zyngier , Peter Shier , Paolo Bonzini , Will Deacon , kvmarm@lists.cs.columbia.edu, Linux ARM X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Fuad, > > The series might be missing an entry for ID_AA64MMFR0_EL1, Debug > > Communications Channel registers, ID_AA64MMFR0_FGT -> MDCR_EL2_TDCC. Looking at Arm ARM, it appears any of the registers that can be trapped by MDCR_EL2_TDCC are present even when FEAT_FGT is not implemented (I understand MDCR_EL2_TDCC is available when FEAT_FGT is implemented though). So, this is not something that the framework is trying to address. Thanks, Reiji > > I will add them in v5 series. > Thank you so much for all the review comments! > > Thanks, > Reiji > > > > > > Cheers, > > /fuad _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E5F9C433EF for ; Wed, 9 Feb 2022 04:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=boFrBkUn/uID3NaLcUmEZO0uQ1X2zt5t0LSHoVWM0DM=; b=osm2bINhKapb85 v46Shd7b/4y23YxWbklt2Jr9ZjBxG7CgkhKQ1LDezAvebW6FJs/4a1sUMjThwJPhOUsFgoDnIfnCc pSbqGyoWsHXmnfno1DnNRdO5tVnue0bZ4DiyjNarEVXiL/hlG+iJdRMOSxj2RsOSVYQ5oVdA9/s5Y /5OzPcwqsPFyrkbzExODJyhKD/U26+qQSYAy2lbNfcx153OYF+/Xp2sXXEOokZHZ9gvCLEZnl2CKu 5uhZtcVWo5jLVNnPQoQExk3Kt7kIg0t0BE6wvf+Mgcm8AZ/pl7HNEidPC8Mqdam4e4+3Nauo65yA6 MgMnrfhediH5IP2XUUng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHexc-00GDvS-ED; Wed, 09 Feb 2022 04:52:08 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHexY-00GDv7-Ef for linux-arm-kernel@lists.infradead.org; Wed, 09 Feb 2022 04:52:05 +0000 Received: by mail-pf1-x429.google.com with SMTP id z35so2291542pfw.2 for ; Tue, 08 Feb 2022 20:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PR9huqMPKoKBRfN5n+K9Fdcj8rjbPiaTb5ftDSq6ZW8=; b=tQaAa/Eoya61ibJVdVxszqGG/UfmlZZiGR7xPsfkCDCEkdWlPtzGXjJApJX5e+FU9+ wmn39wUvZIjraVZ+MZFPURdjeDgkcL2Ky+XpOYKD90Qr2JSLE4h7QDc8WD8aboPNBK4z 74YHsm0O699dnj3zabAnBzANeZ0MyIJAj140UZqIxCqL5aOnbKkBgiAQ40c+6rjuzah7 Mih047zYSw7TfkZGwqxqvV7SeHajB7IsYZRetsE9/ZBa+GFsdGgdPyQyoxkbvYKat+jh OqHjGLs+zpREYER9xZHySaCZ1+bLpAFxt3vfiHtS2RL3UtVB/y9BrkN58Kh1nsUx25hr mbzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PR9huqMPKoKBRfN5n+K9Fdcj8rjbPiaTb5ftDSq6ZW8=; b=d3Hklf0Ji1+GL/BlpjS8R0VaK49t9FOb5WS4eLO9/QY1lTIOFu0WfNKYWEFBhQEPx1 vPTxwOkv5JGe8Y+s4tT/vNPkyHlqjLmav7Yso3rLECL1BFxM+HDYHsmDRrOoj1XakEIq fwS5DeAh8AZ5zLLvMbk6r+0QE9HtQZ3xE3mkSOp/pC1WDlxnSpDCLam8lmZqH8+2BRCk mvKkZVS6SvSULg8pmv8rsKTKH0R0jx3leNlv5ttJG5yDvsSPVVP4jGU1NPnHGZFAUh+C 32yzplUo0kQz30JDZleAC5fVRudouyccTcIc4R2sfOlzSpgPoVTvpuTl7idQX8LZ1og7 dMPQ== X-Gm-Message-State: AOAM5306ApoTDtfSCMBbPO0yKCP2vDk/a9whUerCzf4Aywtf9b6LwIgV g6I7TAUbbmoQymsp1CWU2SvLqPkRNq8ATRfv0pyzlA== X-Google-Smtp-Source: ABdhPJyJlqEofZ7FNvhCVWK/Fj3kLxyOD4l5cf2Tx4Vqf1uOnZGRpCs5oYUnLgprJaxq8w4j07PtbuNWc1rPBvp8/4I= X-Received: by 2002:a63:2b4d:: with SMTP id r74mr547546pgr.514.1644382323360; Tue, 08 Feb 2022 20:52:03 -0800 (PST) MIME-Version: 1.0 References: <20220106042708.2869332-1-reijiw@google.com> <20220106042708.2869332-24-reijiw@google.com> In-Reply-To: From: Reiji Watanabe Date: Tue, 8 Feb 2022 20:51:47 -0800 Message-ID: Subject: Re: [RFC PATCH v4 23/26] KVM: arm64: Trap disabled features of ID_AA64MMFR1_EL1 To: Fuad Tabba Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will Deacon , Peter Shier , Paolo Bonzini , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_205204_538014_26EEB512 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fuad, > > The series might be missing an entry for ID_AA64MMFR0_EL1, Debug > > Communications Channel registers, ID_AA64MMFR0_FGT -> MDCR_EL2_TDCC. Looking at Arm ARM, it appears any of the registers that can be trapped by MDCR_EL2_TDCC are present even when FEAT_FGT is not implemented (I understand MDCR_EL2_TDCC is available when FEAT_FGT is implemented though). So, this is not something that the framework is trying to address. Thanks, Reiji > > I will add them in v5 series. > Thank you so much for all the review comments! > > Thanks, > Reiji > > > > > > Cheers, > > /fuad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 803F3C4167D for ; Wed, 9 Feb 2022 05:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239825AbiBIFHm (ORCPT ); Wed, 9 Feb 2022 00:07:42 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:48182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242647AbiBIEwC (ORCPT ); Tue, 8 Feb 2022 23:52:02 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14893C0613CA for ; Tue, 8 Feb 2022 20:52:04 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id i21so755575pfd.13 for ; Tue, 08 Feb 2022 20:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PR9huqMPKoKBRfN5n+K9Fdcj8rjbPiaTb5ftDSq6ZW8=; b=tQaAa/Eoya61ibJVdVxszqGG/UfmlZZiGR7xPsfkCDCEkdWlPtzGXjJApJX5e+FU9+ wmn39wUvZIjraVZ+MZFPURdjeDgkcL2Ky+XpOYKD90Qr2JSLE4h7QDc8WD8aboPNBK4z 74YHsm0O699dnj3zabAnBzANeZ0MyIJAj140UZqIxCqL5aOnbKkBgiAQ40c+6rjuzah7 Mih047zYSw7TfkZGwqxqvV7SeHajB7IsYZRetsE9/ZBa+GFsdGgdPyQyoxkbvYKat+jh OqHjGLs+zpREYER9xZHySaCZ1+bLpAFxt3vfiHtS2RL3UtVB/y9BrkN58Kh1nsUx25hr mbzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PR9huqMPKoKBRfN5n+K9Fdcj8rjbPiaTb5ftDSq6ZW8=; b=6dXQG8B336B/gBlePu1T92aFIvxQmrt2koDbroFKjCAzr+fHNAe7PIv6VT3Lis/pA1 I7VOWoTavqczKk2CUo9Q9uo/yLaRECSalUyO63aFtDpJgM5mO08PNudirN715oYWiZXp sKJfPFC33FP8v1y83aALXyK1sXhj4EoHMSWfhXrMEp1OJfW5QVXMi7Zrx7o/3P3eXHiH GcYTYpVIK55L52EgCIa4ugHn53CuKUxGoC82gWptTV7C/azz2/HJjrbVF+1sFRV7S6mW YUJfGbnlLDRh4vtawtK3FwFqRD0aEMfS5oNkYnwgND70YYi/ZsOBh9REEDNq/SmcEBmY 5Uhw== X-Gm-Message-State: AOAM533zdQJKwxkofEEGgc2u9ge2gcq/Y0AFMiRxmHSPqVlCxj44O1RE n0H8CZBWy290z/cPbRNZvudEnChkWgDBNFIPHFDylg== X-Google-Smtp-Source: ABdhPJyJlqEofZ7FNvhCVWK/Fj3kLxyOD4l5cf2Tx4Vqf1uOnZGRpCs5oYUnLgprJaxq8w4j07PtbuNWc1rPBvp8/4I= X-Received: by 2002:a63:2b4d:: with SMTP id r74mr547546pgr.514.1644382323360; Tue, 08 Feb 2022 20:52:03 -0800 (PST) MIME-Version: 1.0 References: <20220106042708.2869332-1-reijiw@google.com> <20220106042708.2869332-24-reijiw@google.com> In-Reply-To: From: Reiji Watanabe Date: Tue, 8 Feb 2022 20:51:47 -0800 Message-ID: Subject: Re: [RFC PATCH v4 23/26] KVM: arm64: Trap disabled features of ID_AA64MMFR1_EL1 To: Fuad Tabba Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will Deacon , Peter Shier , Paolo Bonzini , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Fuad, > > The series might be missing an entry for ID_AA64MMFR0_EL1, Debug > > Communications Channel registers, ID_AA64MMFR0_FGT -> MDCR_EL2_TDCC. Looking at Arm ARM, it appears any of the registers that can be trapped by MDCR_EL2_TDCC are present even when FEAT_FGT is not implemented (I understand MDCR_EL2_TDCC is available when FEAT_FGT is implemented though). So, this is not something that the framework is trying to address. Thanks, Reiji > > I will add them in v5 series. > Thank you so much for all the review comments! > > Thanks, > Reiji > > > > > > Cheers, > > /fuad