All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang7@gmail.com>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: sc27xx_adc: Use DIV_ROUND_CLOSEST() instead of open-coding it
Date: Wed, 23 Dec 2020 13:39:24 +0800	[thread overview]
Message-ID: <CAAfSe-vy6Hv1Zxa+z+9dneGtamJOJ-_fu8VcJTm7EshnNfWTfw@mail.gmail.com> (raw)
In-Reply-To: <20201222191618.3433-1-lars@metafoo.de>

On Wed, 23 Dec 2020 at 03:16, Lars-Peter Clausen <lars@metafoo.de> wrote:
>
> Use DIV_ROUND_CLOSEST() instead of open-coding it. This makes it more clear
> what is going on for the casual reviewer.
>
> Generated using the following the Coccinelle semantic patch.
>
> // <smpl>
> @@
> expression x, y;
> @@
> -((x) + ((y) / 2)) / (y)
> +DIV_ROUND_CLOSEST(x, y)
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

Thanks,
Chunyan

> ---
>  drivers/iio/adc/sc27xx_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
> index aa32a1f385e2..301cf66de695 100644
> --- a/drivers/iio/adc/sc27xx_adc.c
> +++ b/drivers/iio/adc/sc27xx_adc.c
> @@ -307,7 +307,7 @@ static int sc27xx_adc_convert_volt(struct sc27xx_adc_data *data, int channel,
>
>         sc27xx_adc_volt_ratio(data, channel, scale, &numerator, &denominator);
>
> -       return (volt * denominator + numerator / 2) / numerator;
> +       return DIV_ROUND_CLOSEST(volt * denominator, numerator);
>  }
>
>  static int sc27xx_adc_read_processed(struct sc27xx_adc_data *data,
> --
> 2.20.1
>

  reply	other threads:[~2020-12-23  5:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 19:16 [PATCH] iio: sc27xx_adc: Use DIV_ROUND_CLOSEST() instead of open-coding it Lars-Peter Clausen
2020-12-23  5:39 ` Chunyan Zhang [this message]
2020-12-29 14:28   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAfSe-vy6Hv1Zxa+z+9dneGtamJOJ-_fu8VcJTm7EshnNfWTfw@mail.gmail.com \
    --to=zhang.lyra@gmail.com \
    --cc=baolin.wang7@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.