From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qa0-f50.google.com ([209.85.216.50]:64914 "EHLO mail-qa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759522AbbBIVH2 (ORCPT ); Mon, 9 Feb 2015 16:07:28 -0500 Received: by mail-qa0-f50.google.com with SMTP id f12so4676325qad.9 for ; Mon, 09 Feb 2015 13:07:28 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20150118050741.31866.36490.stgit@114-36-241-182.dynamic.hinet.net> <20150118051111.31866.39208.stgit@114-36-241-182.dynamic.hinet.net> Date: Tue, 10 Feb 2015 05:07:28 +0800 Message-ID: (sfid-20150209_220732_643856_7D77F026) Subject: Re: [PATCH 6/7] net: wireless: wcn36xx: remove powersaving for wcn3620 From: Andy Green To: Bjorn Andersson Cc: Kalle Valo , Eugene Krasnikov , wcn36xx , linux-wireless , netdev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10 February 2015 at 01:54, Bjorn Andersson wrote: > On Sat, Jan 17, 2015 at 9:11 PM, Andy Green wrote: >> WCN3620 powersaving mode is not stable. Disable it if we're >> on a wcn3620 chip type. >> >> Signed-off-by: Andy Green >> --- >> drivers/net/wireless/ath/wcn36xx/main.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c >> index c4178c7..569d45b 100644 >> --- a/drivers/net/wireless/ath/wcn36xx/main.c >> +++ b/drivers/net/wireless/ath/wcn36xx/main.c >> @@ -924,6 +924,10 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) >> IEEE80211_HW_AMPDU_AGGREGATION | >> IEEE80211_HW_TIMING_BEACON_ONLY; >> >> + /* 3620 powersaving currently unstable */ >> + if (wcn->chip_version == WCN36XX_CHIP_3620) >> + wcn->hw->flags &= ~IEEE80211_HW_SUPPORTS_PS; >> + > > Hi Andy, > > I have the same problem (Data Abort Exception in wcnss) on 3680, this > with my wip smd code and a hacked up remoteproc-pil. I haven't spent > any effort on debugging this, but it looks like it's something related > to what we have ported to mainline (or lack thereof) rather than a > 3620 specific issue. Makes sense since I only have 3620, I assumed it's related to that. However he can work for a while with powersaving on, but ping latencies are +600-800ms and he's shaky. Later I found something mac80211 generic scan preparation or post-scan code (for scan initiated by wpa_supplicant) is able to stop wlan traffic after a few goes even if the actual scan mode smd is not sent. At that point I think a nice solution would be a donation of time from guys who specialize in wcn for a living to come and hand out a pony or two... -Andy > Regards, > Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Green Subject: Re: [PATCH 6/7] net: wireless: wcn36xx: remove powersaving for wcn3620 Date: Tue, 10 Feb 2015 05:07:28 +0800 Message-ID: References: <20150118050741.31866.36490.stgit@114-36-241-182.dynamic.hinet.net> <20150118051111.31866.39208.stgit@114-36-241-182.dynamic.hinet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Kalle Valo , Eugene Krasnikov , wcn36xx , linux-wireless , netdev To: Bjorn Andersson Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 10 February 2015 at 01:54, Bjorn Andersson wrote: > On Sat, Jan 17, 2015 at 9:11 PM, Andy Green wrote: >> WCN3620 powersaving mode is not stable. Disable it if we're >> on a wcn3620 chip type. >> >> Signed-off-by: Andy Green >> --- >> drivers/net/wireless/ath/wcn36xx/main.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c >> index c4178c7..569d45b 100644 >> --- a/drivers/net/wireless/ath/wcn36xx/main.c >> +++ b/drivers/net/wireless/ath/wcn36xx/main.c >> @@ -924,6 +924,10 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) >> IEEE80211_HW_AMPDU_AGGREGATION | >> IEEE80211_HW_TIMING_BEACON_ONLY; >> >> + /* 3620 powersaving currently unstable */ >> + if (wcn->chip_version == WCN36XX_CHIP_3620) >> + wcn->hw->flags &= ~IEEE80211_HW_SUPPORTS_PS; >> + > > Hi Andy, > > I have the same problem (Data Abort Exception in wcnss) on 3680, this > with my wip smd code and a hacked up remoteproc-pil. I haven't spent > any effort on debugging this, but it looks like it's something related > to what we have ported to mainline (or lack thereof) rather than a > 3620 specific issue. Makes sense since I only have 3620, I assumed it's related to that. However he can work for a while with powersaving on, but ping latencies are +600-800ms and he's shaky. Later I found something mac80211 generic scan preparation or post-scan code (for scan initiated by wpa_supplicant) is able to stop wlan traffic after a few goes even if the actual scan mode smd is not sent. At that point I think a nice solution would be a donation of time from guys who specialize in wcn for a living to come and hand out a pony or two... -Andy > Regards, > Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html