From: Gurchetan Singh <gurchetansingh@chromium.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: hch@lst.de, ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/5] udmabuf: allow userspace to set map attributes
Date: Mon, 2 Dec 2019 17:48:17 -0800 [thread overview]
Message-ID: <CAAfnVBmaVS=KqVybDnZnJd2_ZbaL2Dh_BsA41VJFWgK4qougPg@mail.gmail.com> (raw)
In-Reply-To: <20191128114809.ukvsmuvzssxctvoe@sirius.home.kraxel.org>
On Thu, Nov 28, 2019 at 3:48 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Hi,
>
> > diff --git a/include/uapi/linux/udmabuf.h b/include/uapi/linux/udmabuf.h
> > index 46b6532ed855..f90831f2bb0d 100644
> > --- a/include/uapi/linux/udmabuf.h
> > +++ b/include/uapi/linux/udmabuf.h
> > @@ -6,6 +6,8 @@
> > #include <linux/ioctl.h>
> >
> > #define UDMABUF_FLAGS_CLOEXEC 0x01
> > +#define UDMABUF_FLAGS_WC 0x02
> > +#define UDMABUF_FLAGS_NONCACHED 0x04
> >
> > struct udmabuf_create {
> > __u32 memfd;
>
> This is a uapi change and should go to a separate patch,
> clearly flagging that in $subject.
>
> (new policy by airlied for the drm tree).
The new policy requires a non-toy userspace[1], which may take a
while. Removed the UAPI changes in the latest patch series.
[1] https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements
>
> Otherwise the series looks good to me.
>
> cheers,
> Gerd
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-03 1:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 1:10 [PATCH 1/5] udmabuf: use cache_sgt_mapping option Gurchetan Singh
2019-11-26 1:10 ` [PATCH 2/5] udmabuf: allow userspace to set map attributes Gurchetan Singh
2019-11-28 11:48 ` Gerd Hoffmann
2019-12-03 1:48 ` Gurchetan Singh [this message]
2019-11-26 1:10 ` [PATCH 3/5] udmabuf: add a pointer to the miscdevice in dma-buf private data Gurchetan Singh
2019-11-26 1:10 ` [PATCH 4/5] udmabuf: separate out creating/destroying scatter-table Gurchetan Singh
2019-11-26 1:10 ` [PATCH 5/5] udmabuf: implement begin_cpu_access/end_cpu_access hooks Gurchetan Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAfnVBmaVS=KqVybDnZnJd2_ZbaL2Dh_BsA41VJFWgK4qougPg@mail.gmail.com' \
--to=gurchetansingh@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.