From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Goldschmidt Date: Wed, 29 Jan 2020 15:16:01 +0100 Subject: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static In-Reply-To: <4a860cbf-2712-c1e2-91ed-9f878724a3a3@samsung.com> References: <20200124115252.15712-1-faiz_abbas@ti.com> <20200124115252.15712-5-faiz_abbas@ti.com> <4a860cbf-2712-c1e2-91ed-9f878724a3a3@samsung.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung wrote: > > On 1/24/20 8:52 PM, Faiz Abbas wrote: > > Expose sdhci_init() as non-static. > > Does it need to change to non-static? And even if it needs to, can we have a reason *why* in the commit message? Thanks, Simon > > Best Regards, > Jaehoon Chung > > > > > Signed-off-by: Faiz Abbas > > Signed-off-by: Lokesh Vutla > > --- > > drivers/mmc/sdhci.c | 2 +- > > include/sdhci.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > > index 01fa5a9d4d..4fce85a0ea 100644 > > --- a/drivers/mmc/sdhci.c > > +++ b/drivers/mmc/sdhci.c > > @@ -618,7 +618,7 @@ static int sdhci_set_ios(struct mmc *mmc) > > return 0; > > } > > > > -static int sdhci_init(struct mmc *mmc) > > +int sdhci_init(struct mmc *mmc) > > { > > struct sdhci_host *host = mmc->priv; > > #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_GPIO) > > diff --git a/include/sdhci.h b/include/sdhci.h > > index 01addb7a60..0830e05d53 100644 > > --- a/include/sdhci.h > > +++ b/include/sdhci.h > > @@ -487,6 +487,7 @@ void sdhci_set_uhs_timing(struct sdhci_host *host); > > #ifdef CONFIG_DM_MMC > > /* Export the operations to drivers */ > > int sdhci_probe(struct udevice *dev); > > +int sdhci_init(struct mmc *mmc); > > int sdhci_set_clock(struct mmc *mmc, unsigned int clock); > > extern const struct dm_mmc_ops sdhci_ops; > > #else > > >