From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Date: Fri, 6 Dec 2019 14:37:52 +0100
Subject: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr
In-Reply-To: <20191206133445.GH9549@bill-the-cat>
References: <20191125161820.32674-1-giulio.benetti@benettiengineering.com>
 <20191205220914.GW9549@bill-the-cat>
 <976a2aee-f85f-41fe-215c-17213adafefe@st.com>
 <CAAh8qswK4_JvAzO8v7LTvdJ7Zp5s-6aBx+KCD_vX4vzo9+tGuQ@mail.gmail.com>
 <20191206133445.GH9549@bill-the-cat>
Message-ID: <CAAh8qsycEvxrGDTirQaKGO3F_iuMLjJhjOVHUgMojX_Qf0MJiQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Dec 6, 2019 at 2:34 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote:
> > On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD <patrice.chotard@st.com> wrote:
> > >
> > > Hi
> > >
> > > This patch is breaking the STM32MP15 basic boot (spl => u-boot).
> >
> > Looking at socfpga gen5 u-boot.img, this is probably broken as well.
> >
> > And I don't even see any RB or TB tags here :-(
>
> Ugh, what the heck?  I applied this because I looked over the changes
> and they seemed correct.  I'm quite willing to just revert this but I
> would like to know how it's breaking.  Sorry all!

Looking at the branch a few lines up I can understand why this seemed
like a small change. I hadn't seen this before Patrice's mail, either.

Let me test this on socfpga_socrates tomorrow, I could still be wrong since
this is from reading the code and binary only. But entry_point should be 0
in my u-boot.img if I'm not mistaken, and that should break it.

Regards,
Simon