All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anup Patel <anup@brainfault.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "net: macb: Fixed reading MII_LPA register"
Date: Fri, 16 Aug 2019 08:16:34 +0530	[thread overview]
Message-ID: <CAAhSdy0EhJQmP7b8DL0s4f=q+yW86yBixYcxOMEHVjqtetHbZw@mail.gmail.com> (raw)
In-Reply-To: <1565778582-16750-1-git-send-email-bmeng.cn@gmail.com>

On Wed, Aug 14, 2019 at 4:01 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> This reverts commit 1b0c9914cc75d1570359181ebd493cd5746cb0ed.
>
> Commit 1b0c9914cc75 ("net: macb: Fixed reading MII_LPA register")
> causes 100Mbps does not work any more with SiFive FU540 GEM on the
> HiFive Unleashed board. Revert it.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  drivers/net/macb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index c99cf66..25f7913 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -643,7 +643,7 @@ static int macb_phy_init(struct macb_device *macb, const char *name)
>
>         /* First check for GMAC and that it is GiB capable */
>         if (gem_is_gigabit_capable(macb)) {
> -               lpa = macb_mdio_read(macb, MII_LPA);
> +               lpa = macb_mdio_read(macb, MII_STAT1000);

You can do this selectively by having boolean flag in macb_config which is
only set for SiFive Unleashed.

Regards,
Anup

>
>                 if (lpa & (LPA_1000FULL | LPA_1000HALF | LPA_1000XFULL |
>                                         LPA_1000XHALF)) {
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

  parent reply	other threads:[~2019-08-16  2:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 10:29 [U-Boot] [PATCH] Revert "net: macb: Fixed reading MII_LPA register" Bin Meng
2019-08-14 18:57 ` Joe Hershberger
2019-09-04 11:50   ` Bin Meng
2019-09-04 15:39     ` Joe Hershberger
2019-09-04 16:15       ` Bin Meng
2019-08-16  2:46 ` Anup Patel [this message]
2019-08-16 14:19   ` Bin Meng
2019-09-04 16:41 ` [U-Boot] " Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAhSdy0EhJQmP7b8DL0s4f=q+yW86yBixYcxOMEHVjqtetHbZw@mail.gmail.com' \
    --to=anup@brainfault.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.