From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E60C432C0 for ; Mon, 18 Nov 2019 06:12:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69ED220727 for ; Mon, 18 Nov 2019 06:12:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="zG0GfU55" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726246AbfKRGM2 (ORCPT ); Mon, 18 Nov 2019 01:12:28 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33190 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbfKRGM2 (ORCPT ); Mon, 18 Nov 2019 01:12:28 -0500 Received: by mail-wr1-f65.google.com with SMTP id w9so17961657wrr.0 for ; Sun, 17 Nov 2019 22:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AJsaT5DgrHtaCNma+B9BtLu3BvxW/8LIu7bVrOjvJcw=; b=zG0GfU55CfIq0bxqCfyIHFIxx3fvkMttFzS3Xkc1BHyNNxJ63t+K35DzNEi2QJdorL eAuy1vxsuQFq33tue6ItS9AVZgi0iP+xbGIJB+GW2xcHzbjsvNwcbSYUz31d+geX15Ko E31HfnnHnP8zKrOFKkMQJWguItFUW2eNV3A5Vy87q8PItuesaKxhwh5e/6IOhMMivIFG BiKyNMn8a2x0wFOqxXn3vGd4SMU/E78F9mBux91j2CvejF69EVbFQHzsDOsyQcL4PLrZ 6i+SU7I4c2Mapi4d1HWYuguHDBKtXedYFCWauGtiIXNvqBuP1tcZtHowTHGiVnAn6jyS rE6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AJsaT5DgrHtaCNma+B9BtLu3BvxW/8LIu7bVrOjvJcw=; b=Y15aEFS8YTga7cioWhknfqsVACYG0/0aSvWKJCEcd04F4rktMwHl4ZeYO4TT7aSxyq zcZa6zr+p7VuGl69nP3lRGVipep9NgbkaP26DJyDP7BsQ1iUNoz+60Pi8IzJ2ZSHsV4t lYX9UAqTQ6i94qifSd+0gtWpm491bCLnIHKVSVovu6F6JLVETz4l7WKIuyQL0cIaP7DB aPkg4E2Exv4tOcNYSL70jLgW3+x40VZiToaAQYWRr13bP7aJBUCIeyLFfeS1b6hd9xdV 2IKbw87JjhouOsVFhhzLNlB+HnDCFqta5MfYkP6D9mH6Uxf3baB8F2EF1imT6QDJs7AH QhRg== X-Gm-Message-State: APjAAAVw1oxqIpdg2UQejkZ33Ri9wizWNV9owGhdQcWUZMilDWkCIYp+ PiM4r7KvCvoEjwpzpR8m239CZbH8MHfyol1jHplFXw== X-Google-Smtp-Source: APXvYqwB3mALuF+xrfOFxo6FhxUJ3+/T3sFpcxYqdgA9qswdYF/EtXU0VTIbAKX+PRN8dPiqpo1l4F1iCFTwAIDgVcs= X-Received: by 2002:adf:b746:: with SMTP id n6mr27431556wre.65.1574057545931; Sun, 17 Nov 2019 22:12:25 -0800 (PST) MIME-Version: 1.0 References: <20191107212408.11857-1-hch@lst.de> In-Reply-To: From: Anup Patel Date: Mon, 18 Nov 2019 11:42:14 +0530 Message-ID: Subject: Re: QEMU RISC-V virt machine poweroff driver To: Nick Kossifidis Cc: Christoph Hellwig , Mark Rutland , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Sebastian Reichel , Rob Herring , Palmer Dabbelt , Paul Walmsley , linux-riscv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Nov 16, 2019 at 3:45 AM Nick Kossifidis wrote: > > =CE=A3=CF=84=CE=B9=CF=82 2019-11-07 23:24, Christoph Hellwig =CE=AD=CE=B3= =CF=81=CE=B1=CF=88=CE=B5: > > Hi all, > > > > this patch add a driver for the test device in the Qemu RISC-V > > virt machine which allows properly shutting down the VM. > > It also is added to the riscv defconfig given that qemu-virt > > is the most popular riscv platform. > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > We do this already through OpenSBI, I contributed a patch for this some > time ago. > > https://github.com/riscv/opensbi/commit/51e543511a7425da1a5378e149de0b459= 28c7111#diff-36ecc47313ff13e406c53b99471f294e > > Last time I checked I could just halt and the system would shut down > properly. We only have poweroff SBI call in SBI v0.1 spec. Also, we had proposed SBI v0.2 SRST extension having both Poweroff and Reboot SBI calls but before we can have this SBI extension we need to clarify scope of SBI interface in RISC-V privilege spec so that we can have system-level SBI calls defined in SBI spec. In future, we will bring back the proposal for SBI v0.2 SRST extension. There are two cases in which we might need SOC specific Poweroff and Reboot drivers in Linux: 1. SBI v0.2 onwards all SBI calls are optional so SOC vendor can choose to provide explicit driver instead of implementing SBI calls for Poweroff and Reboot. 2. The M-mode NOMMU Linux does not have SBI interface so for this case SOC vendors will have to provide explicit drivers. If SOC Poweroff and Reboot mechanisms are simple enough then SOC vendors can straight away use SYSCON Poweroff and SYSCON Reboot drivers instead of writing it from scratch. Regards, Anup From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C2A5C432C0 for ; Mon, 18 Nov 2019 06:12:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20F7420730 for ; Mon, 18 Nov 2019 06:12:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ipZIh3qV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="zG0GfU55" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20F7420730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QAaEKizRuLZCZ/w3dUla3CNgEAPycaSSq3pJoE8dNtk=; b=ipZIh3qVdNsY0g 1ltsTPDV318j8OBKObMsGcjIkqX4tIFZp9GOZszuUfbjB+MqLT95t87AAFS6MIuBfmNnNBtu2J+KG C9G7jUh+/5JWztkDACmcDb6QlQxm70AJeeDHFUBJo+IEUdIqlXqg3k4bVRzJsZy41QxpJbUI6m1Nq PtOXDHGjzNkxGqlMkALWewrt0+O1IbmzcVRBmW4wR4AOIFgB+EStt+1FB4BWSxtQgRFKEdlwI4wgj LUJnY6hEQ0AkwWQDfMpdpByMVky4ZtZlXLqtCtH8fxVc0FGUVlAs8y61lxWuNsWpM/Ty8HPXp5qnw KtXLUBifj6FrgSffWOHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWaH1-0007a0-2F; Mon, 18 Nov 2019 06:12:31 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWaGy-0007ZK-5C for linux-riscv@lists.infradead.org; Mon, 18 Nov 2019 06:12:29 +0000 Received: by mail-wr1-x442.google.com with SMTP id b3so17921933wrs.13 for ; Sun, 17 Nov 2019 22:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AJsaT5DgrHtaCNma+B9BtLu3BvxW/8LIu7bVrOjvJcw=; b=zG0GfU55CfIq0bxqCfyIHFIxx3fvkMttFzS3Xkc1BHyNNxJ63t+K35DzNEi2QJdorL eAuy1vxsuQFq33tue6ItS9AVZgi0iP+xbGIJB+GW2xcHzbjsvNwcbSYUz31d+geX15Ko E31HfnnHnP8zKrOFKkMQJWguItFUW2eNV3A5Vy87q8PItuesaKxhwh5e/6IOhMMivIFG BiKyNMn8a2x0wFOqxXn3vGd4SMU/E78F9mBux91j2CvejF69EVbFQHzsDOsyQcL4PLrZ 6i+SU7I4c2Mapi4d1HWYuguHDBKtXedYFCWauGtiIXNvqBuP1tcZtHowTHGiVnAn6jyS rE6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AJsaT5DgrHtaCNma+B9BtLu3BvxW/8LIu7bVrOjvJcw=; b=sSN5u2sqyTzpfhacvM9bUsuRhxFhbRuXbItxHg4IA8jcrpfF8AWmxHxOgwLLtTNbRA skejUtQ6MaFULcSRjJ3r/P+zlX1OCigLS6UFKInNlwLMNfffnOt3tAin9UnFMt22Jubf P7M0UPR6/1jGDqNTPrRAeoeB4DsYyA3H3QEtJHVe9KNfny34PdK5kPZMQ8krt6/8j38u 567rxny0UBLsYdTkdMNVeZEPh3ZOxqgfJnJfEYKBMJl6lbPeQH4ZAhP07vLNwC6lQ4Xq Q+3xXUGzputRHRbTlULHl24rviBEPudIjQi7H5RtZJhPDSmGFSedfg9RbQnFL1H9gvPv NVvw== X-Gm-Message-State: APjAAAVkHr/EaefguWPZDN1iy3OJ2g3D5JZFzTpnaTawHeImrgdDSw6h nSVmecLQu4XX1pm+JbddMyc3pFTzcyYeuVEzYHyMqw== X-Google-Smtp-Source: APXvYqwB3mALuF+xrfOFxo6FhxUJ3+/T3sFpcxYqdgA9qswdYF/EtXU0VTIbAKX+PRN8dPiqpo1l4F1iCFTwAIDgVcs= X-Received: by 2002:adf:b746:: with SMTP id n6mr27431556wre.65.1574057545931; Sun, 17 Nov 2019 22:12:25 -0800 (PST) MIME-Version: 1.0 References: <20191107212408.11857-1-hch@lst.de> In-Reply-To: From: Anup Patel Date: Mon, 18 Nov 2019 11:42:14 +0530 Message-ID: Subject: Re: QEMU RISC-V virt machine poweroff driver To: Nick Kossifidis X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191117_221228_334017_BCCBF665 X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Sebastian Reichel , Rob Herring , Palmer Dabbelt , Paul Walmsley , linux-riscv , Christoph Hellwig Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCBOb3YgMTYsIDIwMTkgYXQgMzo0NSBBTSBOaWNrIEtvc3NpZmlkaXMgPG1pY2tAaWNz LmZvcnRoLmdyPiB3cm90ZToKPgo+IM6jz4TOuc+CIDIwMTktMTEtMDcgMjM6MjQsIENocmlzdG9w aCBIZWxsd2lnIM6tzrPPgc6xz4jOtToKPiA+IEhpIGFsbCwKPiA+Cj4gPiB0aGlzIHBhdGNoIGFk ZCBhIGRyaXZlciBmb3IgdGhlIHRlc3QgZGV2aWNlIGluIHRoZSBRZW11IFJJU0MtVgo+ID4gdmly dCBtYWNoaW5lIHdoaWNoIGFsbG93cyBwcm9wZXJseSBzaHV0dGluZyBkb3duIHRoZSBWTS4KPiA+ IEl0IGFsc28gaXMgYWRkZWQgdG8gdGhlIHJpc2N2IGRlZmNvbmZpZyBnaXZlbiB0aGF0IHFlbXUt dmlydAo+ID4gaXMgdGhlIG1vc3QgcG9wdWxhciByaXNjdiBwbGF0Zm9ybS4KPiA+Cj4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gbGludXgtcmlz Y3YgbWFpbGluZyBsaXN0Cj4gPiBsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCj4gPiBo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cj4K PiBXZSBkbyB0aGlzIGFscmVhZHkgdGhyb3VnaCBPcGVuU0JJLCBJIGNvbnRyaWJ1dGVkIGEgcGF0 Y2ggZm9yIHRoaXMgc29tZQo+IHRpbWUgYWdvLgo+Cj4gaHR0cHM6Ly9naXRodWIuY29tL3Jpc2N2 L29wZW5zYmkvY29tbWl0LzUxZTU0MzUxMWE3NDI1ZGExYTUzNzhlMTQ5ZGUwYjQ1OTI4YzcxMTEj ZGlmZi0zNmVjYzQ3MzEzZmYxM2U0MDZjNTNiOTk0NzFmMjk0ZQo+Cj4gTGFzdCB0aW1lIEkgY2hl Y2tlZCBJIGNvdWxkIGp1c3QgaGFsdCBhbmQgdGhlIHN5c3RlbSB3b3VsZCBzaHV0IGRvd24KPiBw cm9wZXJseS4KCldlIG9ubHkgaGF2ZSBwb3dlcm9mZiBTQkkgY2FsbCBpbiBTQkkgdjAuMSBzcGVj LgoKQWxzbywgd2UgaGFkIHByb3Bvc2VkIFNCSSB2MC4yIFNSU1QgZXh0ZW5zaW9uIGhhdmluZyBi b3RoClBvd2Vyb2ZmIGFuZCBSZWJvb3QgU0JJIGNhbGxzIGJ1dCBiZWZvcmUgd2UgY2FuIGhhdmUg dGhpcyBTQkkKZXh0ZW5zaW9uIHdlIG5lZWQgdG8gY2xhcmlmeSBzY29wZSBvZiBTQkkgaW50ZXJm YWNlIGluIFJJU0MtVgpwcml2aWxlZ2Ugc3BlYyBzbyB0aGF0IHdlIGNhbiBoYXZlIHN5c3RlbS1s ZXZlbCBTQkkgY2FsbHMgZGVmaW5lZAppbiBTQkkgc3BlYy4gSW4gZnV0dXJlLCB3ZSB3aWxsIGJy aW5nIGJhY2sgdGhlIHByb3Bvc2FsIGZvciBTQkkgdjAuMgpTUlNUIGV4dGVuc2lvbi4KClRoZXJl IGFyZSB0d28gY2FzZXMgaW4gd2hpY2ggd2UgbWlnaHQgbmVlZCBTT0Mgc3BlY2lmaWMKUG93ZXJv ZmYgYW5kIFJlYm9vdCBkcml2ZXJzIGluIExpbnV4OgoxLiBTQkkgdjAuMiBvbndhcmRzIGFsbCBT QkkgY2FsbHMgYXJlIG9wdGlvbmFsIHNvIFNPQyB2ZW5kb3IKY2FuIGNob29zZSB0byBwcm92aWRl IGV4cGxpY2l0IGRyaXZlciBpbnN0ZWFkIG9mIGltcGxlbWVudGluZwpTQkkgY2FsbHMgZm9yIFBv d2Vyb2ZmIGFuZCBSZWJvb3QuCjIuIFRoZSBNLW1vZGUgTk9NTVUgTGludXggZG9lcyBub3QgaGF2 ZSBTQkkgaW50ZXJmYWNlCnNvIGZvciB0aGlzIGNhc2UgU09DIHZlbmRvcnMgd2lsbCBoYXZlIHRv IHByb3ZpZGUgZXhwbGljaXQKZHJpdmVycy4KCklmIFNPQyBQb3dlcm9mZiBhbmQgUmVib290IG1l Y2hhbmlzbXMgYXJlIHNpbXBsZSBlbm91Z2gKdGhlbiBTT0MgdmVuZG9ycyBjYW4gc3RyYWlnaHQg YXdheSB1c2UgU1lTQ09OIFBvd2Vyb2ZmCmFuZCBTWVNDT04gUmVib290IGRyaXZlcnMgaW5zdGVh ZCBvZiB3cml0aW5nIGl0IGZyb20gc2NyYXRjaC4KClJlZ2FyZHMsCkFudXAKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK