From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFE7C4708F for ; Wed, 2 Jun 2021 15:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 867E8611BF for ; Wed, 2 Jun 2021 15:07:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231657AbhFBPJh (ORCPT ); Wed, 2 Jun 2021 11:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232220AbhFBPJK (ORCPT ); Wed, 2 Jun 2021 11:09:10 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FEDCC061574 for ; Wed, 2 Jun 2021 08:07:13 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id c5so2638928wrq.9 for ; Wed, 02 Jun 2021 08:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vs3Wh4eIvni5P/DPP9QB7KFgHPP2DPvUYXX2oG5ziD8=; b=Jv8riBA6hdAzuqqKPOkSJ02ahdlNA9yVktgdWbigMUOdm6bpxDApG6IxbmI1fsDrV0 od+qctz8WdJpLMlg/dh65H26zKlKq18C9r5Id/gmGsm86frMckOC7EoWbt0ijn0eL0JF V2eoz1XbjOwarwofM8JZQSrsAfYcO3xSQaU0PbsEdI7qs5udvqBh0EPPIt9kv0811yzh Y1ACLtstrLSq5QF+c1a7+IJpO2MbffII4oH2s6027S/4EDlqAHuOV2aC7HPIfRM+H8i3 rqVEckU/2Srs13LwwfmSQVfXeu/H9S/Z6a100JTKutK+gu0RXflckQNcpZ0l/fPiK0Hv oNxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vs3Wh4eIvni5P/DPP9QB7KFgHPP2DPvUYXX2oG5ziD8=; b=M+J1SghQONefSI5ST8ar0FrbvOMVsSjQM9Z7vlcMI7HIFB/ydem4pJZtj+MzgtSX9F OgjyXbMNLIdQaZKfaA3geTRk6vzSkTgqWiXBtq+6yB/VVE9hz1uP4ROFQo0SFNt0tnRe yacF2PbdPueMio7n8Uc6P5Zt4Ff2t/FEj6DCPzeZuQ/xGBeCpvUgTv8tsMyET1sPR2eq ZiGr4BCCwezlSmbFkF3uYPaF/poLev3V651V1h3eMqDkt7GjAKgjh34TkiDagUtWwGum K7Uq3oEfbHP6eB6X/GWPwFpiLEyLOXZxv5RIzwiv4xbrdNonY8u0q6YrjRsVPvCR5iOh D7Ew== X-Gm-Message-State: AOAM533x+247s5McHd9dTV+dwqIpSLlMNLlY7eO8GssDF8tC54jtc760 JPnBWXRWakTzLflkIIVdbZ8ebhcFI/hTe1kK7WjTuA== X-Google-Smtp-Source: ABdhPJwg13/gEhL01WTUQpFs1K3FGrC8NR1Evds3qUYUCeEJOMNXDkC3cHVMY2cPzMBS6YuglZja7OitSEjs3ENc/Bs= X-Received: by 2002:a5d:58f6:: with SMTP id f22mr21961347wrd.128.1622646431784; Wed, 02 Jun 2021 08:07:11 -0700 (PDT) MIME-Version: 1.0 References: <20210602112321.2241566-1-anup.patel@wdc.com> <20210602112321.2241566-6-anup.patel@wdc.com> In-Reply-To: From: Anup Patel Date: Wed, 2 Jun 2021 20:36:59 +0530 Message-ID: Subject: Re: [PATCH v5 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Ulf Hansson Cc: Anup Patel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , DTML , linux-riscv , Linux Kernel Mailing List , Linux PM , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 2, 2021 at 6:47 PM Ulf Hansson wrote: > > On Wed, 2 Jun 2021 at 13:24, Anup Patel wrote: > > > > The generic power domain related code in PSCI domain driver is largely > > independent of PSCI and can be shared with RISC-V SBI domain driver > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > Signed-off-by: Anup Patel > > Reviewed-by: Ulf Hansson > > A small nitpick below. > > [...] > > > +EXPORT_SYMBOL_GPL(dt_idle_pd_free); > > Do we really need to export this symbol? Looks like there are only > built-in cpuidle drivers that are going to use it. At least for now. > > As a matter of fact, the same comment applies to all cases of > EXPORT_SYMBOL_GPL from $subject patch. Can we drop all of them? I had kept the EXPORT_SYMBOL_GPL() to be in-sync with the dt_idle_states.c but in this case I agree we don't need to export. I will drop all EXPORT_SYMBOL_GPL() in the next patch revision. Regards, Anup > > [...] > > Kind regards > Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 394CCC47083 for ; Wed, 2 Jun 2021 15:08:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA99961182 for ; Wed, 2 Jun 2021 15:08:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA99961182 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3rf0/k6wcw2ABrv07MTX1yJ617+er0z+J4aXgMmuMqM=; b=ItFAVoPgCb1yBU ORcF1OlOWzhCa7F4FBY+Vh/ZbhsQ7syplZUNNF+ggYfD7S6Ax9YCGafN+xL7yYh/vBw0djnQZzToP uoOoSVs7az9kVu5zXCAEpeIh4tsz+nTteZo79Cq1RAhHn/zSCGGaejiwVKXFS0vf5H0CAhDssQ10r ixGzw+q+jgCL1WrBKE73NcuI0zfRFGM0HfsyI5KZSfAJ7W+LE84MikHa6ztJIzvRewHyshgRrGfUm /z2jPBh+g+5i5J9gDG4/UAhPVFsLaJkpRXszQqjFNqQ/1TUOyvidKNV/7HZ3D270N0CDjCu+THkEA K5f6M59tVBH2wcoXGCTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loSTg-004lgS-BJ; Wed, 02 Jun 2021 15:08:16 +0000 Received: from mail-wr1-f48.google.com ([209.85.221.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loSTd-004lfO-7W for linux-riscv@lists.infradead.org; Wed, 02 Jun 2021 15:08:14 +0000 Received: by mail-wr1-f48.google.com with SMTP id q5so2682164wrm.1 for ; Wed, 02 Jun 2021 08:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vs3Wh4eIvni5P/DPP9QB7KFgHPP2DPvUYXX2oG5ziD8=; b=Jv8riBA6hdAzuqqKPOkSJ02ahdlNA9yVktgdWbigMUOdm6bpxDApG6IxbmI1fsDrV0 od+qctz8WdJpLMlg/dh65H26zKlKq18C9r5Id/gmGsm86frMckOC7EoWbt0ijn0eL0JF V2eoz1XbjOwarwofM8JZQSrsAfYcO3xSQaU0PbsEdI7qs5udvqBh0EPPIt9kv0811yzh Y1ACLtstrLSq5QF+c1a7+IJpO2MbffII4oH2s6027S/4EDlqAHuOV2aC7HPIfRM+H8i3 rqVEckU/2Srs13LwwfmSQVfXeu/H9S/Z6a100JTKutK+gu0RXflckQNcpZ0l/fPiK0Hv oNxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vs3Wh4eIvni5P/DPP9QB7KFgHPP2DPvUYXX2oG5ziD8=; b=n9GnCHAqPnWv9L6CSpxAstcbOJQXMCICMgLwJJRGaaZEqD0UVNPbkT/dydUaYRuHQT YLk4zcybQXSa1ARQEamieLIEq3RVPjcNsJp/WFRIFK16c/QirzeCiBt3YbBixs5AvIro 0ghe6/PRPkVNJ0mrp2vqF0ceG4mcTTnT9NG5ocOA28yppMFDZAuf3hTPRKsOspmiXEG/ xxTpVAhwLEnjXk0rU+nqr6gDkWiFLF7hUwSPDGRfzbIjEprAD/bUuxE7qG/fKtQIYH7I VtgR63lTMs111peHXUsZW68Y60Xi8kFl2wyW+Rq1XPX4kyzJETBtCz+WaBm1LV5sRvCh pgTg== X-Gm-Message-State: AOAM530+6LqGG7RPLLaOgKFu+acgsg38zGOp84An85NI9b1fKXFHdyEI mQixIQrHhyRuxg9dWQ4A2AsSgWktmXLA1Wyj59Nzaw== X-Google-Smtp-Source: ABdhPJwg13/gEhL01WTUQpFs1K3FGrC8NR1Evds3qUYUCeEJOMNXDkC3cHVMY2cPzMBS6YuglZja7OitSEjs3ENc/Bs= X-Received: by 2002:a5d:58f6:: with SMTP id f22mr21961347wrd.128.1622646431784; Wed, 02 Jun 2021 08:07:11 -0700 (PDT) MIME-Version: 1.0 References: <20210602112321.2241566-1-anup.patel@wdc.com> <20210602112321.2241566-6-anup.patel@wdc.com> In-Reply-To: From: Anup Patel Date: Wed, 2 Jun 2021 20:36:59 +0530 Message-ID: Subject: Re: [PATCH v5 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Ulf Hansson Cc: Anup Patel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , DTML , linux-riscv , Linux Kernel Mailing List , Linux PM , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_080813_284875_6363D85F X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Jun 2, 2021 at 6:47 PM Ulf Hansson wrote: > > On Wed, 2 Jun 2021 at 13:24, Anup Patel wrote: > > > > The generic power domain related code in PSCI domain driver is largely > > independent of PSCI and can be shared with RISC-V SBI domain driver > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > Signed-off-by: Anup Patel > > Reviewed-by: Ulf Hansson > > A small nitpick below. > > [...] > > > +EXPORT_SYMBOL_GPL(dt_idle_pd_free); > > Do we really need to export this symbol? Looks like there are only > built-in cpuidle drivers that are going to use it. At least for now. > > As a matter of fact, the same comment applies to all cases of > EXPORT_SYMBOL_GPL from $subject patch. Can we drop all of them? I had kept the EXPORT_SYMBOL_GPL() to be in-sync with the dt_idle_states.c but in this case I agree we don't need to export. I will drop all EXPORT_SYMBOL_GPL() in the next patch revision. Regards, Anup > > [...] > > Kind regards > Uffe _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B80C4708F for ; Wed, 2 Jun 2021 15:08:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A136E61246 for ; Wed, 2 Jun 2021 15:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A136E61246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qYS3xQ8ovmPXsLH/dE8tv2+Xp0nYqgGNCl//rqDGRuQ=; b=17ExG8NM+NvQax llL1FD5AffzaFiYKy4R1MnP8LCr60B/xGme2A09S41XyGeOaFkxGirq4qc2rhWPhDp0VQPAGuK8qL lU470RrC/6NCN7DbTRU8lVIHp5awGMjueCqgmkA+p5z+YYF0TCcV1PmL0mWi5bVR+1KmWb8KeM5j+ 4mYYeZ2CxqyFdZmX4wHmIgzW5vmbp4vbVsnchoi/9JnzV4xR71s+qNWAOd+6nMJs28udxaBKrLXRQ S+ipfhs+/C7AnE53acfE12PTAPb4s6GeiOxtB0M1M05OMiio+iKHOQv5wbPvpEy4YHDMPgLOkWif+ RUe6DW6WxnddcKKPgzAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loSSk-004lUN-4j; Wed, 02 Jun 2021 15:07:18 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loSSf-004lSt-Hj for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 15:07:15 +0000 Received: by mail-wr1-x436.google.com with SMTP id a20so2712429wrc.0 for ; Wed, 02 Jun 2021 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vs3Wh4eIvni5P/DPP9QB7KFgHPP2DPvUYXX2oG5ziD8=; b=Jv8riBA6hdAzuqqKPOkSJ02ahdlNA9yVktgdWbigMUOdm6bpxDApG6IxbmI1fsDrV0 od+qctz8WdJpLMlg/dh65H26zKlKq18C9r5Id/gmGsm86frMckOC7EoWbt0ijn0eL0JF V2eoz1XbjOwarwofM8JZQSrsAfYcO3xSQaU0PbsEdI7qs5udvqBh0EPPIt9kv0811yzh Y1ACLtstrLSq5QF+c1a7+IJpO2MbffII4oH2s6027S/4EDlqAHuOV2aC7HPIfRM+H8i3 rqVEckU/2Srs13LwwfmSQVfXeu/H9S/Z6a100JTKutK+gu0RXflckQNcpZ0l/fPiK0Hv oNxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vs3Wh4eIvni5P/DPP9QB7KFgHPP2DPvUYXX2oG5ziD8=; b=Gk4VeeACnwLW/1lfAb2kKBTmqHL1tKEKe7Aq3subEQg7kMOtE9+JPx8PGG7XV8Vb3K AXO2dL8Kecw3HNo8gK576iZYVBInTKEq806UVqAWFXocfr8y9cdiCnKS/0021HmVNIW0 z+e1p1oUm0cxXUddv0ep5NRspFQhQemBkHhDjjb0Pu/X8T1s3XPt8Xupf+zcJ5H6Wt8K f0na87m6+IA20GlHY+1XcxZUf4vivZyr+Sh6Yr8/6dwbX1x4pzjb3qkup6EPnqdA5zRf W1fuxzvCad7RvQ4aPNY3abNsIdH40qM1LEVeUNWEo4PrOVOceyTqzJSiemFSj/dJ1sJD l/oA== X-Gm-Message-State: AOAM533tIXCM2fuulV9tjUSFClEFhuVvYokzuy45zE62ZxZBBLufbGT0 y2dZsxYzfuwxvSE28wnlhJUX8ZkEtL9EwhUqvDuaZA== X-Google-Smtp-Source: ABdhPJwg13/gEhL01WTUQpFs1K3FGrC8NR1Evds3qUYUCeEJOMNXDkC3cHVMY2cPzMBS6YuglZja7OitSEjs3ENc/Bs= X-Received: by 2002:a5d:58f6:: with SMTP id f22mr21961347wrd.128.1622646431784; Wed, 02 Jun 2021 08:07:11 -0700 (PDT) MIME-Version: 1.0 References: <20210602112321.2241566-1-anup.patel@wdc.com> <20210602112321.2241566-6-anup.patel@wdc.com> In-Reply-To: From: Anup Patel Date: Wed, 2 Jun 2021 20:36:59 +0530 Message-ID: Subject: Re: [PATCH v5 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Ulf Hansson Cc: Anup Patel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , DTML , linux-riscv , Linux Kernel Mailing List , Linux PM , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_080714_474552_D50DE210 X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 2, 2021 at 6:47 PM Ulf Hansson wrote: > > On Wed, 2 Jun 2021 at 13:24, Anup Patel wrote: > > > > The generic power domain related code in PSCI domain driver is largely > > independent of PSCI and can be shared with RISC-V SBI domain driver > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > Signed-off-by: Anup Patel > > Reviewed-by: Ulf Hansson > > A small nitpick below. > > [...] > > > +EXPORT_SYMBOL_GPL(dt_idle_pd_free); > > Do we really need to export this symbol? Looks like there are only > built-in cpuidle drivers that are going to use it. At least for now. > > As a matter of fact, the same comment applies to all cases of > EXPORT_SYMBOL_GPL from $subject patch. Can we drop all of them? I had kept the EXPORT_SYMBOL_GPL() to be in-sync with the dt_idle_states.c but in this case I agree we don't need to export. I will drop all EXPORT_SYMBOL_GPL() in the next patch revision. Regards, Anup > > [...] > > Kind regards > Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel