From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5C7CA9ED0 for ; Sun, 3 Nov 2019 07:13:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A4C420848 for ; Sun, 3 Nov 2019 07:13:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="vtAFfr1W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A4C420848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRA4u-0000zb-6f for qemu-devel@archiver.kernel.org; Sun, 03 Nov 2019 02:13:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34134) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRA4E-0000Xp-Uz for qemu-devel@nongnu.org; Sun, 03 Nov 2019 02:12:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRA4D-00073G-PL for qemu-devel@nongnu.org; Sun, 03 Nov 2019 02:12:54 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:51188) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRA4D-00071o-CA for qemu-devel@nongnu.org; Sun, 03 Nov 2019 02:12:53 -0500 Received: by mail-wm1-x342.google.com with SMTP id 11so13387131wmk.0 for ; Sun, 03 Nov 2019 00:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=To4ycopByR2i8bwttYMBs8mMexxs8pgOxnlAHibyyIM=; b=vtAFfr1Wnc+T6BDvgQi9fW/2xRzc9cj3mJ6uZfJmV/Ckyva7ucywGQkzL8q6sUKWwh alVIViumsdfrYZWSpvAExWvOti/XpE9jUeYa/h3QIcQSzkKEVtbJQBJPv3+6gGN7g2mY vCYjrswmknleGRKTwkGiIyT8Sj7zWnO/CrBY7xbNJ3kOgOdxW8wHCuOOMJoDs9cgoD5S 3E8AW03+N+y+MollkgbOWzBuEyZ2psAJgqeuDM8Vg5+n8jgnhlBikvz7T1f7UlYtUWfl VLJVp4Q1IaV4jYfB86kIQ7k0pF36wK7Nd96aoWsuATkNWPmV0J4k9WeHUEQ9Aplyb4Iz 3cpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=To4ycopByR2i8bwttYMBs8mMexxs8pgOxnlAHibyyIM=; b=apSGjYOARCf3ZxJrtRAqogkj4KUlkQeeozaofg5funsf8I/+GxhFtBqsZXZv/P/n2u u7Yfhc0yOL8wTB8sWMMVjx6k29YqozkhiduQ0ghJ4t9XngYhhErQdq/fjUjdxhcmILTx hSd5ydQVK636qTu4GFKrKtu9NISUW4u/5IjOZHXBZhHpIdq5vNvfaF2G/eT+Ft3rP68l AjkUO5SUBzXQoWuU9rjbdKmUlEYUdqB146tK+AbUvqqyQLmI2y7VOhwXciTQmtqApyt/ b/bB8DAORNH2lXbtY5XJp3fTIc3uv3zquem82a7+Of2RgJydOV2kIjRPUINyOnONBmq+ Nj5A== X-Gm-Message-State: APjAAAX3MqAKHu+mvChQS3jgdwAvbPy612seC9sbOoov3bhXbLzGcWr8 njPWHCCzRsIS9FR6B6ieHdwKrqsGb95IDoxHcq+Eig== X-Google-Smtp-Source: APXvYqxiDSPWTLHOa7H8ENKceesLoxdE5B3embH6pAcFmZdwqSZat4nf1COuJmwpDE71Sz5F0ciQYaIj5IH78DV8N3A= X-Received: by 2002:a1c:4c10:: with SMTP id z16mr11885684wmf.24.1572765170534; Sun, 03 Nov 2019 00:12:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Anup Patel Date: Sun, 3 Nov 2019 12:42:38 +0530 Message-ID: Subject: Re: [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine To: Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "open list:RISC-V" , Sagar Karandikar , Bastian Koppelmann , Anup Patel , QEMU Developers , Atish Patra , Alistair Francis , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Nov 2, 2019 at 4:44 AM Palmer Dabbelt wrote: > > On Fri, 01 Nov 2019 08:40:24 PDT (-0700), anup@brainfault.org wrote: > > On Tue, Oct 29, 2019 at 6:55 PM Alistair Francis wrote: > >> > >> On Fri, Oct 25, 2019 at 6:28 AM Anup Patel wrote: > >> > > >> > This series adds RTC device to QEMU RISC-V virt machine. We have > >> > selected Goldfish RTC device model for this. It's a pretty simple > >> > synthetic device with few MMIO registers and no dependency external > >> > clock. The driver for Goldfish RTC is already available in Linux so > >> > we just need to enable it in Kconfig for RISCV and also update Linux > >> > defconfigs. > >> > > >> > We have tested this series with Linux-5.4-rc4 plus defconfig changes > >> > available in 'goldfish_rtc_v2' branch of: > >> > https://github.com/avpatel/linux.git > >> > >> @Peter Maydell this has been reviewed, do you mind taking this in you > >> next PR? I don't see a maintainer for hw/rtc. > > > > It would be great if this series can be taken for QEMU-4.2 > > It doesn't look like there's anyone who maintains hw/rtc, so maybe that's why > this has been going slowly? I'd happy to PR it, but I don't really have the > bandwidth to sign up to maintain more stuff right now. No problem, I will maintain Goldfish RTC emulation until someone else is willing to maintain it. Regards, Anup > > > > > Regards, > > Anup > > > >> > >> Alistair > >> > >> > > >> > Changes since v4: > >> > - Fixed typo in trace event usage > >> > - Moved goldfish_rtc.h to correct location > >> > > >> > Changes since v3: > >> > - Address all nit comments from Alistair > >> > > >> > Changes since v2: > >> > - Rebased on RTC code refactoring > >> > > >> > Changes since v1: > >> > - Implemented VMState save/restore callbacks > >> > > >> > Anup Patel (2): > >> > hw: rtc: Add Goldfish RTC device > >> > riscv: virt: Use Goldfish RTC device > >> > > >> > hw/riscv/Kconfig | 1 + > >> > hw/riscv/virt.c | 15 ++ > >> > hw/rtc/Kconfig | 3 + > >> > hw/rtc/Makefile.objs | 1 + > >> > hw/rtc/goldfish_rtc.c | 288 ++++++++++++++++++++++++++++++++++ > >> > hw/rtc/trace-events | 4 + > >> > include/hw/riscv/virt.h | 2 + > >> > include/hw/rtc/goldfish_rtc.h | 46 ++++++ > >> > 8 files changed, 360 insertions(+) > >> > create mode 100644 hw/rtc/goldfish_rtc.c > >> > create mode 100644 include/hw/rtc/goldfish_rtc.h > >> > > >> > -- > >> > 2.17.1 > >> >