From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE5CFC433EF for ; Wed, 29 Jun 2022 04:32:07 +0000 (UTC) Received: from localhost ([::1]:49338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6PN0-0007Sg-9N for qemu-devel@archiver.kernel.org; Wed, 29 Jun 2022 00:32:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6PLu-0006bF-9V for qemu-devel@nongnu.org; Wed, 29 Jun 2022 00:30:58 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:34713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6PLs-00020X-DM for qemu-devel@nongnu.org; Wed, 29 Jun 2022 00:30:58 -0400 Received: by mail-wr1-x42a.google.com with SMTP id r20so20531899wra.1 for ; Tue, 28 Jun 2022 21:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ORn/xm9l621G2gk438Ur7Zcqma3//YNjMnHfREHxlwE=; b=lAxCOTx7xIsZBnHmiklZml4ZzIlIX8EkWBWMZ+zWpJY2IdkVSJgE1fsutD7oC/xjhu cPRxr/cjqrV+aP6KMmPTjRBYzn36tv7VgywrdYsIp3p7OcKYzHXxotj/eR1Wwwb83CWO OhK3Ytwomb9xVekI2qV2VvvEOFTccLIfs/p0NLywBEFKt5Oe9Egka9Jgkh/ZLft6Vm6B T5+KoCngBrLtB9pw1GcLbezLDIMVK0gmQta5dQ1l0uR8r/ELIXwjojKh7AQ7IRNQLYRx msYI85QW6gZ/ewefvAKxVCagzeCLnpx6J/SMubHxusfEFGViMaqT/sapFldEFA7XfoG+ Y2+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ORn/xm9l621G2gk438Ur7Zcqma3//YNjMnHfREHxlwE=; b=XJ2zdaLW45VklQbOBxBkH5pcihl04OGZMDtHOeMtzc13KbW7gopvckFL1dxS/2uMSS XH/wiQCxnvTq1p7WTM7o7ekrsXFCtVzNUmr3GLjV+hS4+fBpQF8grHGB+e0PhexJZqTF fHFhdw/bci7KcUzQ8sOhiq+kj19/1g64TsnJJVBppuu2oQwvya0Gy+fkQm88bP1HUvel nDaMxYdgbWJiBINYQGAbk5jKZY96nSs+VCPYxN1bLgcStEBeaJ1YTbI3JAMgVmA3IdYK WOegaB5yPVu/I5lz38oWYjd/SRbJbNn1352qVXyExjNFtJDTRj3MlpzNKVPtZZnshOls 32Kg== X-Gm-Message-State: AJIora+f4pLWUX+wTntUOHZQ9Tc/ccF2fKXtNZ0GeytadE2W34CLViIS XWu5aT3F9dlipJbLg/e03bksRpyyurVFOEBil6kwBg== X-Google-Smtp-Source: AGRyM1t3Cgzt5BFB1AznOtxyJtlypPi4E0cuIEWVZpraSQAwYfIt5aFKWsIWUkiHRVm3Xw9k2vU4t98ME1TGocxSj1w= X-Received: by 2002:a5d:4532:0:b0:21b:ab1e:e9fa with SMTP id j18-20020a5d4532000000b0021bab1ee9famr1024528wra.214.1656477053826; Tue, 28 Jun 2022 21:30:53 -0700 (PDT) MIME-Version: 1.0 References: <20220627164044.1512862-1-rpathak@ventanamicro.com> In-Reply-To: From: Anup Patel Date: Wed, 29 Jun 2022 10:00:43 +0530 Message-ID: Subject: Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid To: Bin Meng Cc: Rahul Pathak , Alistair Francis , "open list:RISC-V" , "qemu-devel@nongnu.org Developers" , Alistair Francis , Palmer Dabbelt , Anup Patel , Rahul Pathak , =?UTF-8?Q?V=C3=ADctor_Colombo?= Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2a00:1450:4864:20::42a; envelope-from=anup@brainfault.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 29, 2022 at 9:27 AM Bin Meng wrote: > > Hi Rahul, > > On Wed, Jun 29, 2022 at 10:07 AM Rahul Pathak wrote: > > > > Hi Alistair > > > > My fix patch needs to be dropped since Anup took care of this issue > > in his yesterdays series update in this patch - > > [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec > > version does not match > > I don't understand. Each patch should keep bisectability. The patches are already bisectable. There was a compile error until v6 which was fixed in v7 by squashing this patch into PATCH4. > > This sounds like to me, that > [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec > version does not match > > has an issue that it does 2 things: one is to fix this bug, and the > other one is to force disable extensions. > > Which is not right. The bug is fixed as a result of force disabling extensions which don't match the priv spec version. Regards, Anup