From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8D41353EA for ; Fri, 16 Feb 2024 17:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103494; cv=none; b=DRaYbGrWKxqHuGA+WmMcsacpIqQasfjjT8RDnv3mp4GP6li6U74Gf74itR7ZkWdxS7K79aAMQii0XP0Ewi6mWpfS6nE8iWWssVIAMe2m0QtgkHEpHOP6f7u1u2bdRdEhf7o+3Iz/2vclj7H7zWm6IKiovArlNMOwdq1WyRgHMFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103494; c=relaxed/simple; bh=xjN1Txz0NRu+aYorD0V/0btXAZTtLNg0c38DLzxV7Y8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=fBMSEJPMmgaXaaz2yjXrf9VIgIpaSG7rzfChK2az1dFZtdjw8FpNrZOguNHm6VWmT5sNOBfm1mWDC8oPv2mvUqEMYI7FigvBNf6mEFOlunezPCRwNUc4kUnEl4XUP1lP7hr9Lb77vK0iU9dyzglnbab1YXKMAHxBJjqj61wbLnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org; spf=none smtp.mailfrom=brainfault.org; dkim=pass (2048-bit key) header.d=brainfault-org.20230601.gappssmtp.com header.i=@brainfault-org.20230601.gappssmtp.com header.b=qjIK0WI6; arc=none smtp.client-ip=209.85.166.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=brainfault.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20230601.gappssmtp.com header.i=@brainfault-org.20230601.gappssmtp.com header.b="qjIK0WI6" Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3642281e4a6so2703485ab.2 for ; Fri, 16 Feb 2024 09:11:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20230601.gappssmtp.com; s=20230601; t=1708103492; x=1708708292; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=havUKwIuQeWK4aYu8DNjs5scwGn6QvvJ9tZ1EDA7AU4=; b=qjIK0WI6BMRxFfvwDqX8CyiSktGjxnchTLXvFuvFM50SO9VGc6oogg2SiMT/WCbSeN uruxBlVZvibuavftiMZgd9ia1yV259xp2iVSXT7Ch5DUE5P+/mAk1WwDrkv9f8xagaD7 q+bQfXt7YqjWlG9KVJXhzUZVWlTfiOLQZgd8YV7jtP9TmBSh3roc+IZVCCQ5s4js2CSG ofBoqZtEksQv8CMrKmrqsYj14st/EYQ83jnaqNWzgaT9TM7VHr5gBUSjww7gbifaYc64 W52Q8B2JVB9LXV+JFVF/5nnPqMorqB1SjuM2wj1A90xrk59mJOl9NiaT+J8Bde/4VpoJ 0+ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708103492; x=1708708292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=havUKwIuQeWK4aYu8DNjs5scwGn6QvvJ9tZ1EDA7AU4=; b=G51spBlKiIM2CQThAGEhdyFsebowSAzsWjceqwi3HHIb1QbfXoCpDOPQ7mJacegvUF dZSOdRN8vrL1FbdSl+Zf3A12ToKDsFix5ErZzufKmSm0WLcgLhqpBDZBEHF86feauqPp j9F9yfxVWeJU9Gu+Uj4MxYLWYN4JBdB9t4ZeChG1lBDO5MXruNXquCqGuAAIrAr3pNH/ I9ZU1cnsXMaW0JLpRxAs6roIYB2JfDIg7K6s1UjIxQI5NF+mjmBBvnVe0Y3riltMEXB3 bf4FJPtoh7aoHv4DXOtRm2Y/KidWbA3sdCksTYtDt9MT6BwRl4/fkaGTw9yQHyLCaWh6 JvoA== X-Forwarded-Encrypted: i=1; AJvYcCWreKvxy9Me9WIMsgi8uxHJ066w23b243cxO9sMsHimPQJtYsbu/qaeCVkUSgV6YMjC3EBlJBoqPeOQDrn9kVSC+1+YlUcJrFEuz1Nj X-Gm-Message-State: AOJu0Yyo5rFZvNHnk68UcI53sw6nt9j1oB/1V4JK+ApmthfNZpRdyuSv AlAf/gqwz87/AlaKCOjwzA8k9nCEYsLGw17vVvQvTGLIYEiBvfh6E6yRY0ZEL+/q+NEcGEEtEh6 MHv2bHqnC/Dnd78GZ7rRhYHP5p5VhVWW1nr43qQ== X-Google-Smtp-Source: AGHT+IF3UAIIWYzEtaz8JDQbpsYiGjzgT5lx1iMPisr8gmFJym7YV9W/quLrJxzPRfygtku2OzFcTAaXVtDz1/yCGVc= X-Received: by 2002:a92:c5a6:0:b0:364:1984:f10f with SMTP id r6-20020a92c5a6000000b003641984f10fmr4861690ilt.30.1708103492171; Fri, 16 Feb 2024 09:11:32 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-15-apatel@ventanamicro.com> <87jzn4ctks.ffs@tglx> In-Reply-To: <87jzn4ctks.ffs@tglx> From: Anup Patel Date: Fri, 16 Feb 2024 22:41:20 +0530 Message-ID: Subject: Re: [PATCH v12 14/25] irqchip/sifive-plic: Convert PLIC driver into a platform driver To: Thomas Gleixner Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 16, 2024 at 9:03=E2=80=AFPM Thomas Gleixner wrote: > > On Sat, Jan 27 2024 at 21:47, Anup Patel wrote: > > + priv->irqdomain =3D irq_domain_create_linear(dev->fwnode, nr_irqs= + 1, > > + &plic_irqdomain_ops, p= riv); > > + if (WARN_ON(!priv->irqdomain)) > > + return -ENOMEM; > > While some of the stuff is cleaned up by devm, the error handling in > this code looks pretty fragile as it leaves initialized contexts, > hardware state, chained handlers etc. around. Sure, let me try to improve the error handling. > > The question is whether the system can actually boot or work at all if > any of this fails. On platforms with PLIC, the PLIC only manages wired interrupts whereas IPIs are provided through SBI (firmware interface) so a system can actually continue and boot further without PLIC. In fact, we do have a synthetic platform (namely QEMU spike) where there is no PLIC instance and Linux boots using SBI based polling console. > > > + > > /* > > * We can have multiple PLIC instances so setup cpuhp state > > - * and register syscore operations only when context handler > > - * for current/boot CPU is present. > > + * and register syscore operations only after context handlers > > + * of all online CPUs are initialized. > > */ > > - handler =3D this_cpu_ptr(&plic_handlers); > > - if (handler->present && !plic_cpuhp_setup_done) { > > + cpuhp_setup =3D true; > > + for_each_online_cpu(cpu) { > > + handler =3D per_cpu_ptr(&plic_handlers, cpu); > > + if (!handler->present) { > > + cpuhp_setup =3D false; > > + break; > > + } > > + } > > + if (cpuhp_setup) { > > cpuhp_setup_state(CPUHP_AP_IRQ_SIFIVE_PLIC_STARTING, > > "irqchip/sifive/plic:starting", > > plic_starting_cpu, plic_dying_cpu); > > register_syscore_ops(&plic_irq_syscore_ops); > > - plic_cpuhp_setup_done =3D true; > > I don't think that removing the setup protection is correct. > > Assume you have maxcpus=3DN on the kernel command line, then the above > for_each_online_cpu() loop would result in cpuhp_setup =3D=3D true when t= he > instances for the not onlined CPUs are set up, no? A platform can have multiple PLIC instances where each PLIC instance targets a subset of HARTs (or CPUs). Previously (before this patch), we were probing PLIC very early so on a platform with multiple PLIC instances, we need to ensure that cpuhp setup is done only after PLIC context associated with boot CPU is initialized hence the plic_cpuhp_setup_done check. This patch converts PLIC driver into a platform driver so now PLIC instances are probed after all available CPUs are brought-up. In this case, the cpuhp setup must be done only after PLIC context of all available CPUs are initialized otherwise some of the CPUs crash in plic_starting_cpu() due to lack of PLIC context initialization. Regards, Anup From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0ACBC48260 for ; Fri, 16 Feb 2024 17:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C8XqFLwxpFO4KPx0cCDb+Z1d4Yzr3Rbo1mhebxSIT+4=; b=Q5Nr7enwGhUVFf c4c78cMx7yZM/Q00qSvd0JO1P3YpUG9F3Ix8FcpcA0eMe0Hc4cYg4E9K5ys7dlytfQil04BmEJ5bz tZJbbtrLj3FwW60IMfkyYyd+gxyCBAdhLV9SmnH/Sfz7ntpWFCqo5iB08OLpscopMrIqCjrYrhuZL uWExg7AS5nY2wNAVksulqHDDLL6+ODhyjoQdMf641H01q3NRXkX4OW9YxUG6PToAPIqB6bxTBODnB i3c27TRNzug1zMY0ufjnP29kfyC4PCsQNPy7rUb43BHMDmQgWbyYLGrZD+UwASo+fUzOhDnR+vcpD EPnwU5tZBQgd0Ax8drbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb1kU-000000038dS-20Le; Fri, 16 Feb 2024 17:11:42 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb1kR-000000038WF-1d6X for linux-riscv@lists.infradead.org; Fri, 16 Feb 2024 17:11:40 +0000 Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-363bd37434dso2411805ab.1 for ; Fri, 16 Feb 2024 09:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20230601.gappssmtp.com; s=20230601; t=1708103492; x=1708708292; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=havUKwIuQeWK4aYu8DNjs5scwGn6QvvJ9tZ1EDA7AU4=; b=e915OAxS9lO6LNBzpNjj/JdajCKIzuYVAB7SJsiR29ICvLGGwNAay/6l31krmxNz32 Ny7uFQLUAMAwaxBr1vcdW0Ef0CYMtM2hHgE9MnHuclmesUfcmBHprL9IrT7U2uWGMt5F F1UrAfwPNPCpkxYLBKHdfftOo4giw+RAEJSkv1F+JFSidlvOGW2m2nb3wKKwCxlXIYSd q0/kGWRzfM+ss0FEVkT512ERI53b9QPaZCmca19GiU54WzCF+8erATqs+bsuOyGRfVqp SRnmmQLdRJWoPRVuV13PnIWWLONs79Skhot5QiioD+5xVjADL64INrh65QUxpzpS8oE+ lTvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708103492; x=1708708292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=havUKwIuQeWK4aYu8DNjs5scwGn6QvvJ9tZ1EDA7AU4=; b=o8Sr0Aw4c6eG6wrAgmAleLM1j+TWRRBO9LGySQz4UO5XenLx0qSQkt8ZB5jzCxzMLS vyRFap2Q4nvlaFrcvsuXhK0UNMW0riwexTrmLRToWAoMNbkhcj2ViVshB4FslD++9uaj D4bulT9+NV2o64aWtDv9qYBKXudE3aga6aeJahm/5a8ABb7HGFzcqgHtdVdZQFewls3q eDbkKQ7OvGjXSv74SvM/elB2IxDmOd0h/gYMg0Jvpbu/NnmsrVBzYRANEWFKyLhgYk/l hasO1hsOzCJirsE4nWY+HEfrAI6f4leH/4F6k2xz/RxSx2PhWXTh4N4XpYz10z9RGp3Q 0nEA== X-Forwarded-Encrypted: i=1; AJvYcCX5vWWTxcxmMQnLRW9PmbGpynzlM5CCNKbd96N+B0oXxpPE4L4RljcVI+suDwjL8emsGNEuzNAhBILT/ASo0KL6G4+X5kdU0qF6ev9EJzFQ X-Gm-Message-State: AOJu0YxxUM+qQIChu9aLoYs9/ynyjbT7Pc2v9l+t24GH2yi1rw1waOtp H9gbE5v2bDsF4gunnefdb7crB3LCDA+8wrda+XX4ZcvK7OZ1X1vqWMRfGMO2U5Bn30CzvtnNlI7 zScqfRpn+Zfh1RF3W11VwvtYq3xSJIDav4XIz/A== X-Google-Smtp-Source: AGHT+IF3UAIIWYzEtaz8JDQbpsYiGjzgT5lx1iMPisr8gmFJym7YV9W/quLrJxzPRfygtku2OzFcTAaXVtDz1/yCGVc= X-Received: by 2002:a92:c5a6:0:b0:364:1984:f10f with SMTP id r6-20020a92c5a6000000b003641984f10fmr4861690ilt.30.1708103492171; Fri, 16 Feb 2024 09:11:32 -0800 (PST) MIME-Version: 1.0 References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-15-apatel@ventanamicro.com> <87jzn4ctks.ffs@tglx> In-Reply-To: <87jzn4ctks.ffs@tglx> From: Anup Patel Date: Fri, 16 Feb 2024 22:41:20 +0530 Message-ID: Subject: Re: [PATCH v12 14/25] irqchip/sifive-plic: Convert PLIC driver into a platform driver To: Thomas Gleixner X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_091139_643137_611A68EB X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , devicetree@vger.kernel.org, Conor Dooley , Saravana Kannan , Marc Zyngier , Atish Patra , linux-kernel@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Rob Herring , Palmer Dabbelt , Krzysztof Kozlowski , Paul Walmsley , linux-riscv@lists.infradead.org, Frank Rowand , linux-arm-kernel@lists.infradead.org, Andrew Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBGZWIgMTYsIDIwMjQgYXQgOTowM+KAr1BNIFRob21hcyBHbGVpeG5lciA8dGdseEBs aW51dHJvbml4LmRlPiB3cm90ZToKPgo+IE9uIFNhdCwgSmFuIDI3IDIwMjQgYXQgMjE6NDcsIEFu dXAgUGF0ZWwgd3JvdGU6Cj4gPiArICAgICBwcml2LT5pcnFkb21haW4gPSBpcnFfZG9tYWluX2Ny ZWF0ZV9saW5lYXIoZGV2LT5md25vZGUsIG5yX2lycXMgKyAxLAo+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwbGljX2lycWRvbWFpbl9vcHMsIHBy aXYpOwo+ID4gKyAgICAgaWYgKFdBUk5fT04oIXByaXYtPmlycWRvbWFpbikpCj4gPiArICAgICAg ICAgICAgIHJldHVybiAtRU5PTUVNOwo+Cj4gV2hpbGUgc29tZSBvZiB0aGUgc3R1ZmYgaXMgY2xl YW5lZCB1cCBieSBkZXZtLCB0aGUgZXJyb3IgaGFuZGxpbmcgaW4KPiB0aGlzIGNvZGUgbG9va3Mg cHJldHR5IGZyYWdpbGUgYXMgaXQgbGVhdmVzIGluaXRpYWxpemVkIGNvbnRleHRzLAo+IGhhcmR3 YXJlIHN0YXRlLCBjaGFpbmVkIGhhbmRsZXJzIGV0Yy4gYXJvdW5kLgoKU3VyZSwgbGV0IG1lIHRy eSB0byBpbXByb3ZlIHRoZSBlcnJvciBoYW5kbGluZy4KCj4KPiBUaGUgcXVlc3Rpb24gaXMgd2hl dGhlciB0aGUgc3lzdGVtIGNhbiBhY3R1YWxseSBib290IG9yIHdvcmsgYXQgYWxsIGlmCj4gYW55 IG9mIHRoaXMgZmFpbHMuCgpPbiBwbGF0Zm9ybXMgd2l0aCBQTElDLCB0aGUgUExJQyBvbmx5IG1h bmFnZXMgd2lyZWQgaW50ZXJydXB0cwp3aGVyZWFzIElQSXMgYXJlIHByb3ZpZGVkIHRocm91Z2gg U0JJIChmaXJtd2FyZSBpbnRlcmZhY2UpIHNvIGEKc3lzdGVtIGNhbiBhY3R1YWxseSBjb250aW51 ZSBhbmQgYm9vdCBmdXJ0aGVyIHdpdGhvdXQgUExJQy4KCkluIGZhY3QsIHdlIGRvIGhhdmUgYSBz eW50aGV0aWMgcGxhdGZvcm0gKG5hbWVseSBRRU1VIHNwaWtlKQp3aGVyZSB0aGVyZSBpcyBubyBQ TElDIGluc3RhbmNlIGFuZCBMaW51eCBib290cyB1c2luZyBTQkkgYmFzZWQKcG9sbGluZyBjb25z b2xlLgoKPgo+ID4gKwo+ID4gICAgICAgLyoKPiA+ICAgICAgICAqIFdlIGNhbiBoYXZlIG11bHRp cGxlIFBMSUMgaW5zdGFuY2VzIHNvIHNldHVwIGNwdWhwIHN0YXRlCj4gPiAtICAgICAgKiBhbmQg cmVnaXN0ZXIgc3lzY29yZSBvcGVyYXRpb25zIG9ubHkgd2hlbiBjb250ZXh0IGhhbmRsZXIKPiA+ IC0gICAgICAqIGZvciBjdXJyZW50L2Jvb3QgQ1BVIGlzIHByZXNlbnQuCj4gPiArICAgICAgKiBh bmQgcmVnaXN0ZXIgc3lzY29yZSBvcGVyYXRpb25zIG9ubHkgYWZ0ZXIgY29udGV4dCBoYW5kbGVy cwo+ID4gKyAgICAgICogb2YgYWxsIG9ubGluZSBDUFVzIGFyZSBpbml0aWFsaXplZC4KPiA+ICAg ICAgICAqLwo+ID4gLSAgICAgaGFuZGxlciA9IHRoaXNfY3B1X3B0cigmcGxpY19oYW5kbGVycyk7 Cj4gPiAtICAgICBpZiAoaGFuZGxlci0+cHJlc2VudCAmJiAhcGxpY19jcHVocF9zZXR1cF9kb25l KSB7Cj4gPiArICAgICBjcHVocF9zZXR1cCA9IHRydWU7Cj4gPiArICAgICBmb3JfZWFjaF9vbmxp bmVfY3B1KGNwdSkgewo+ID4gKyAgICAgICAgICAgICBoYW5kbGVyID0gcGVyX2NwdV9wdHIoJnBs aWNfaGFuZGxlcnMsIGNwdSk7Cj4gPiArICAgICAgICAgICAgIGlmICghaGFuZGxlci0+cHJlc2Vu dCkgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgIGNwdWhwX3NldHVwID0gZmFsc2U7Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gPiArICAgICAgICAgICAgIH0KPiA+ICsgICAg IH0KPiA+ICsgICAgIGlmIChjcHVocF9zZXR1cCkgewo+ID4gICAgICAgICAgICAgICBjcHVocF9z ZXR1cF9zdGF0ZShDUFVIUF9BUF9JUlFfU0lGSVZFX1BMSUNfU1RBUlRJTkcsCj4gPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJpcnFjaGlwL3NpZml2ZS9wbGljOnN0YXJ0aW5nIiwK PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGxpY19zdGFydGluZ19jcHUsIHBs aWNfZHlpbmdfY3B1KTsKPiA+ICAgICAgICAgICAgICAgcmVnaXN0ZXJfc3lzY29yZV9vcHMoJnBs aWNfaXJxX3N5c2NvcmVfb3BzKTsKPiA+IC0gICAgICAgICAgICAgcGxpY19jcHVocF9zZXR1cF9k b25lID0gdHJ1ZTsKPgo+IEkgZG9uJ3QgdGhpbmsgdGhhdCByZW1vdmluZyB0aGUgc2V0dXAgcHJv dGVjdGlvbiBpcyBjb3JyZWN0Lgo+Cj4gQXNzdW1lIHlvdSBoYXZlIG1heGNwdXM9TiBvbiB0aGUg a2VybmVsIGNvbW1hbmQgbGluZSwgdGhlbiB0aGUgYWJvdmUKPiBmb3JfZWFjaF9vbmxpbmVfY3B1 KCkgbG9vcCB3b3VsZCByZXN1bHQgaW4gY3B1aHBfc2V0dXAgPT0gdHJ1ZSB3aGVuIHRoZQo+IGlu c3RhbmNlcyBmb3IgdGhlIG5vdCBvbmxpbmVkIENQVXMgYXJlIHNldCB1cCwgbm8/CgpBIHBsYXRm b3JtIGNhbiBoYXZlIG11bHRpcGxlIFBMSUMgaW5zdGFuY2VzIHdoZXJlIGVhY2ggUExJQwppbnN0 YW5jZSB0YXJnZXRzIGEgc3Vic2V0IG9mIEhBUlRzIChvciBDUFVzKS4KClByZXZpb3VzbHkgKGJl Zm9yZSB0aGlzIHBhdGNoKSwgd2Ugd2VyZSBwcm9iaW5nIFBMSUMgdmVyeSBlYXJseSBzbyBvbgph IHBsYXRmb3JtIHdpdGggbXVsdGlwbGUgUExJQyBpbnN0YW5jZXMsIHdlIG5lZWQgdG8gZW5zdXJl IHRoYXQgY3B1aHAKc2V0dXAgaXMgZG9uZSBvbmx5IGFmdGVyIFBMSUMgY29udGV4dCBhc3NvY2lh dGVkIHdpdGggYm9vdCBDUFUgaXMKaW5pdGlhbGl6ZWQgaGVuY2UgdGhlIHBsaWNfY3B1aHBfc2V0 dXBfZG9uZSBjaGVjay4KClRoaXMgcGF0Y2ggY29udmVydHMgUExJQyBkcml2ZXIgaW50byBhIHBs YXRmb3JtIGRyaXZlciBzbyBub3cgUExJQwppbnN0YW5jZXMgYXJlIHByb2JlZCBhZnRlciBhbGwg YXZhaWxhYmxlIENQVXMgYXJlIGJyb3VnaHQtdXAuIEluIHRoaXMKY2FzZSwgdGhlIGNwdWhwIHNl dHVwIG11c3QgYmUgZG9uZSBvbmx5IGFmdGVyIFBMSUMgY29udGV4dCBvZiBhbGwKYXZhaWxhYmxl IENQVXMgYXJlIGluaXRpYWxpemVkIG90aGVyd2lzZSBzb21lIG9mIHRoZSBDUFVzIGNyYXNoCmlu IHBsaWNfc3RhcnRpbmdfY3B1KCkgZHVlIHRvIGxhY2sgb2YgUExJQyBjb250ZXh0IGluaXRpYWxp emF0aW9uLgoKUmVnYXJkcywKQW51cAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF093C48BC4 for ; Fri, 16 Feb 2024 17:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ald6ALly0Nrzt6+P40kGJISTuvAnaagADEdIAMhVCtQ=; b=wGyw7Lp1IJTsKx 9O57hqdZq6Di6dN2j/VVlIUkJAL1LhlBJkfqNkIMd2cA0a8Q1urjm7x8wtQ9H3lfuZEs1dqsf0YEI lKrDt5hwVdMjJf7AxmFhmllNPPg6tbBWH3F+rzav7cv+C0l5+5u5Y6v+3TVB8csz28eEKhouCWCD2 MEN/sco6WP7NktOSLgfIGO1mDO8kZBbS+ZbADh0RaGnRKAKbru4q/m2QrB8QtcM10aKSot/yBOVW7 9a1TrmYkPPajnd5yiNf4wU0wYK7KLWhSgylvv9dag6I5NgHtW1LXr9ZwNfUwHrMCzNRfRjIYSk1Po MWIYk8EIO+457Uekktog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb1kW-000000038fO-1T3o; Fri, 16 Feb 2024 17:11:44 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb1kR-000000038WG-2Gve for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 17:11:41 +0000 Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-363b5ce4260so3253135ab.0 for ; Fri, 16 Feb 2024 09:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20230601.gappssmtp.com; s=20230601; t=1708103492; x=1708708292; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=havUKwIuQeWK4aYu8DNjs5scwGn6QvvJ9tZ1EDA7AU4=; b=e915OAxS9lO6LNBzpNjj/JdajCKIzuYVAB7SJsiR29ICvLGGwNAay/6l31krmxNz32 Ny7uFQLUAMAwaxBr1vcdW0Ef0CYMtM2hHgE9MnHuclmesUfcmBHprL9IrT7U2uWGMt5F F1UrAfwPNPCpkxYLBKHdfftOo4giw+RAEJSkv1F+JFSidlvOGW2m2nb3wKKwCxlXIYSd q0/kGWRzfM+ss0FEVkT512ERI53b9QPaZCmca19GiU54WzCF+8erATqs+bsuOyGRfVqp SRnmmQLdRJWoPRVuV13PnIWWLONs79Skhot5QiioD+5xVjADL64INrh65QUxpzpS8oE+ lTvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708103492; x=1708708292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=havUKwIuQeWK4aYu8DNjs5scwGn6QvvJ9tZ1EDA7AU4=; b=apjleHmbVEV3inBu+iOMMDEibWaJreMmSkHypTsHE0bfRqdTB86zF/uID0OfYomFI5 Ut6z8CeQYmlQVxiLzC1qGc576u0bkmJTg+NJv0gEwX/8DkR07PuxkAnKg5I0HvyXnnWe OesYC7C2Isae0Nnua5hGCF+We9sP5GUf7tv31+NTDIyzk5Elm9ktSshULmMspe/I4aMh /gVRaCHZX43WlVsVkss2EvX7a0rVGs0+4NaxvckIQ+MCLWYQYpFmjSkUHJ4ZiAQdhmwL Q9HUrbUSh3CEA810a+sO2b7I4qxzyIqbr8zB+1AOBTHdT5E1m+vAXGVv11NYuLUwe4nQ eO0Q== X-Forwarded-Encrypted: i=1; AJvYcCUQTK1Sxpw+srpbBORTcYw1IUwasQ2wlBZb6OGH6Qu6+yu5frDBbPrJ5/2Rj+Lf1nXUF+9LJlZEBgZoQ4xyBtqoUTECDReMz6BK0k6IEYLHuWBsqJY= X-Gm-Message-State: AOJu0YxlkJrKl8eLLNgvou8YAYWcJZobei9UGO0BoEyBm30paOHEuyYe sWYuyKQaR5hWNx0z15H21LEAr99PsfQsKw80i3a5jXoFu+iYZ2X0sL9e6pXomyjE8+BLEP9CGm3 rbvMtdgQvxGPJuz2N8zqmoh1u3QrBCzeFeLq3iw== X-Google-Smtp-Source: AGHT+IF3UAIIWYzEtaz8JDQbpsYiGjzgT5lx1iMPisr8gmFJym7YV9W/quLrJxzPRfygtku2OzFcTAaXVtDz1/yCGVc= X-Received: by 2002:a92:c5a6:0:b0:364:1984:f10f with SMTP id r6-20020a92c5a6000000b003641984f10fmr4861690ilt.30.1708103492171; Fri, 16 Feb 2024 09:11:32 -0800 (PST) MIME-Version: 1.0 References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-15-apatel@ventanamicro.com> <87jzn4ctks.ffs@tglx> In-Reply-To: <87jzn4ctks.ffs@tglx> From: Anup Patel Date: Fri, 16 Feb 2024 22:41:20 +0530 Message-ID: Subject: Re: [PATCH v12 14/25] irqchip/sifive-plic: Convert PLIC driver into a platform driver To: Thomas Gleixner Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_091139_643134_7FE44D3E X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBGZWIgMTYsIDIwMjQgYXQgOTowM+KAr1BNIFRob21hcyBHbGVpeG5lciA8dGdseEBs aW51dHJvbml4LmRlPiB3cm90ZToKPgo+IE9uIFNhdCwgSmFuIDI3IDIwMjQgYXQgMjE6NDcsIEFu dXAgUGF0ZWwgd3JvdGU6Cj4gPiArICAgICBwcml2LT5pcnFkb21haW4gPSBpcnFfZG9tYWluX2Ny ZWF0ZV9saW5lYXIoZGV2LT5md25vZGUsIG5yX2lycXMgKyAxLAo+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwbGljX2lycWRvbWFpbl9vcHMsIHBy aXYpOwo+ID4gKyAgICAgaWYgKFdBUk5fT04oIXByaXYtPmlycWRvbWFpbikpCj4gPiArICAgICAg ICAgICAgIHJldHVybiAtRU5PTUVNOwo+Cj4gV2hpbGUgc29tZSBvZiB0aGUgc3R1ZmYgaXMgY2xl YW5lZCB1cCBieSBkZXZtLCB0aGUgZXJyb3IgaGFuZGxpbmcgaW4KPiB0aGlzIGNvZGUgbG9va3Mg cHJldHR5IGZyYWdpbGUgYXMgaXQgbGVhdmVzIGluaXRpYWxpemVkIGNvbnRleHRzLAo+IGhhcmR3 YXJlIHN0YXRlLCBjaGFpbmVkIGhhbmRsZXJzIGV0Yy4gYXJvdW5kLgoKU3VyZSwgbGV0IG1lIHRy eSB0byBpbXByb3ZlIHRoZSBlcnJvciBoYW5kbGluZy4KCj4KPiBUaGUgcXVlc3Rpb24gaXMgd2hl dGhlciB0aGUgc3lzdGVtIGNhbiBhY3R1YWxseSBib290IG9yIHdvcmsgYXQgYWxsIGlmCj4gYW55 IG9mIHRoaXMgZmFpbHMuCgpPbiBwbGF0Zm9ybXMgd2l0aCBQTElDLCB0aGUgUExJQyBvbmx5IG1h bmFnZXMgd2lyZWQgaW50ZXJydXB0cwp3aGVyZWFzIElQSXMgYXJlIHByb3ZpZGVkIHRocm91Z2gg U0JJIChmaXJtd2FyZSBpbnRlcmZhY2UpIHNvIGEKc3lzdGVtIGNhbiBhY3R1YWxseSBjb250aW51 ZSBhbmQgYm9vdCBmdXJ0aGVyIHdpdGhvdXQgUExJQy4KCkluIGZhY3QsIHdlIGRvIGhhdmUgYSBz eW50aGV0aWMgcGxhdGZvcm0gKG5hbWVseSBRRU1VIHNwaWtlKQp3aGVyZSB0aGVyZSBpcyBubyBQ TElDIGluc3RhbmNlIGFuZCBMaW51eCBib290cyB1c2luZyBTQkkgYmFzZWQKcG9sbGluZyBjb25z b2xlLgoKPgo+ID4gKwo+ID4gICAgICAgLyoKPiA+ICAgICAgICAqIFdlIGNhbiBoYXZlIG11bHRp cGxlIFBMSUMgaW5zdGFuY2VzIHNvIHNldHVwIGNwdWhwIHN0YXRlCj4gPiAtICAgICAgKiBhbmQg cmVnaXN0ZXIgc3lzY29yZSBvcGVyYXRpb25zIG9ubHkgd2hlbiBjb250ZXh0IGhhbmRsZXIKPiA+ IC0gICAgICAqIGZvciBjdXJyZW50L2Jvb3QgQ1BVIGlzIHByZXNlbnQuCj4gPiArICAgICAgKiBh bmQgcmVnaXN0ZXIgc3lzY29yZSBvcGVyYXRpb25zIG9ubHkgYWZ0ZXIgY29udGV4dCBoYW5kbGVy cwo+ID4gKyAgICAgICogb2YgYWxsIG9ubGluZSBDUFVzIGFyZSBpbml0aWFsaXplZC4KPiA+ICAg ICAgICAqLwo+ID4gLSAgICAgaGFuZGxlciA9IHRoaXNfY3B1X3B0cigmcGxpY19oYW5kbGVycyk7 Cj4gPiAtICAgICBpZiAoaGFuZGxlci0+cHJlc2VudCAmJiAhcGxpY19jcHVocF9zZXR1cF9kb25l KSB7Cj4gPiArICAgICBjcHVocF9zZXR1cCA9IHRydWU7Cj4gPiArICAgICBmb3JfZWFjaF9vbmxp bmVfY3B1KGNwdSkgewo+ID4gKyAgICAgICAgICAgICBoYW5kbGVyID0gcGVyX2NwdV9wdHIoJnBs aWNfaGFuZGxlcnMsIGNwdSk7Cj4gPiArICAgICAgICAgICAgIGlmICghaGFuZGxlci0+cHJlc2Vu dCkgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgIGNwdWhwX3NldHVwID0gZmFsc2U7Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gPiArICAgICAgICAgICAgIH0KPiA+ICsgICAg IH0KPiA+ICsgICAgIGlmIChjcHVocF9zZXR1cCkgewo+ID4gICAgICAgICAgICAgICBjcHVocF9z ZXR1cF9zdGF0ZShDUFVIUF9BUF9JUlFfU0lGSVZFX1BMSUNfU1RBUlRJTkcsCj4gPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJpcnFjaGlwL3NpZml2ZS9wbGljOnN0YXJ0aW5nIiwK PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGxpY19zdGFydGluZ19jcHUsIHBs aWNfZHlpbmdfY3B1KTsKPiA+ICAgICAgICAgICAgICAgcmVnaXN0ZXJfc3lzY29yZV9vcHMoJnBs aWNfaXJxX3N5c2NvcmVfb3BzKTsKPiA+IC0gICAgICAgICAgICAgcGxpY19jcHVocF9zZXR1cF9k b25lID0gdHJ1ZTsKPgo+IEkgZG9uJ3QgdGhpbmsgdGhhdCByZW1vdmluZyB0aGUgc2V0dXAgcHJv dGVjdGlvbiBpcyBjb3JyZWN0Lgo+Cj4gQXNzdW1lIHlvdSBoYXZlIG1heGNwdXM9TiBvbiB0aGUg a2VybmVsIGNvbW1hbmQgbGluZSwgdGhlbiB0aGUgYWJvdmUKPiBmb3JfZWFjaF9vbmxpbmVfY3B1 KCkgbG9vcCB3b3VsZCByZXN1bHQgaW4gY3B1aHBfc2V0dXAgPT0gdHJ1ZSB3aGVuIHRoZQo+IGlu c3RhbmNlcyBmb3IgdGhlIG5vdCBvbmxpbmVkIENQVXMgYXJlIHNldCB1cCwgbm8/CgpBIHBsYXRm b3JtIGNhbiBoYXZlIG11bHRpcGxlIFBMSUMgaW5zdGFuY2VzIHdoZXJlIGVhY2ggUExJQwppbnN0 YW5jZSB0YXJnZXRzIGEgc3Vic2V0IG9mIEhBUlRzIChvciBDUFVzKS4KClByZXZpb3VzbHkgKGJl Zm9yZSB0aGlzIHBhdGNoKSwgd2Ugd2VyZSBwcm9iaW5nIFBMSUMgdmVyeSBlYXJseSBzbyBvbgph IHBsYXRmb3JtIHdpdGggbXVsdGlwbGUgUExJQyBpbnN0YW5jZXMsIHdlIG5lZWQgdG8gZW5zdXJl IHRoYXQgY3B1aHAKc2V0dXAgaXMgZG9uZSBvbmx5IGFmdGVyIFBMSUMgY29udGV4dCBhc3NvY2lh dGVkIHdpdGggYm9vdCBDUFUgaXMKaW5pdGlhbGl6ZWQgaGVuY2UgdGhlIHBsaWNfY3B1aHBfc2V0 dXBfZG9uZSBjaGVjay4KClRoaXMgcGF0Y2ggY29udmVydHMgUExJQyBkcml2ZXIgaW50byBhIHBs YXRmb3JtIGRyaXZlciBzbyBub3cgUExJQwppbnN0YW5jZXMgYXJlIHByb2JlZCBhZnRlciBhbGwg YXZhaWxhYmxlIENQVXMgYXJlIGJyb3VnaHQtdXAuIEluIHRoaXMKY2FzZSwgdGhlIGNwdWhwIHNl dHVwIG11c3QgYmUgZG9uZSBvbmx5IGFmdGVyIFBMSUMgY29udGV4dCBvZiBhbGwKYXZhaWxhYmxl IENQVXMgYXJlIGluaXRpYWxpemVkIG90aGVyd2lzZSBzb21lIG9mIHRoZSBDUFVzIGNyYXNoCmlu IHBsaWNfc3RhcnRpbmdfY3B1KCkgZHVlIHRvIGxhY2sgb2YgUExJQyBjb250ZXh0IGluaXRpYWxp emF0aW9uLgoKUmVnYXJkcywKQW51cAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=