All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huacai Chen <chenhuacai@kernel.org>
To: Xi Ruoyao <xry111@xry111.site>
Cc: WANG Xuerui <kernel@xen0n.name>,
	loongarch@lists.linux.dev,  linux-kernel@vger.kernel.org,
	Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: Re: [PATCH] LoongArch: Select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
Date: Fri, 26 Apr 2024 12:00:12 +0800	[thread overview]
Message-ID: <CAAhV-H5EZ=7OF7CSiYyZ8_+wWuenpo=K2WT8-6mAT4CvzUC_4g@mail.gmail.com> (raw)
In-Reply-To: <20240327171737.27622-1-xry111@xry111.site>

Hi, Ruoyao,

If enable CONFIG_DEBUG_INFO_BTF, we get:

loongarch64-unknown-linux-gnu-ld: kernel/sched/fair.o: in function
`mul_u64_u32_shr':
/home/chenhuacai/linux-test.git/./include/linux/math64.h:161:(.text+0x5e4):
undefined reference to `__lshrti3'

So, could you please implement _ashlti3(), __ashrti3(), and
__lshrti3() as commit fbac266f095de92b93e7 ("s390: select
ARCH_SUPPORTS_INT128") does?

Huacai

On Thu, Mar 28, 2024 at 1:18 AM Xi Ruoyao <xry111@xry111.site> wrote:
>
> This allows compiling a full 128-bit product of two 64-bit integers as
> a mul/mulh pair, instead of a nasty long sequence of 20+ instructions.
>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
>  arch/loongarch/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index a5f300ec6f28..5a769bb92d7c 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -56,6 +56,7 @@ config LOONGARCH
>         select ARCH_SUPPORTS_ACPI
>         select ARCH_SUPPORTS_ATOMIC_RMW
>         select ARCH_SUPPORTS_HUGETLBFS
> +       select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
>         select ARCH_SUPPORTS_LTO_CLANG
>         select ARCH_SUPPORTS_LTO_CLANG_THIN
>         select ARCH_SUPPORTS_NUMA_BALANCING
> --
> 2.44.0
>
>

  parent reply	other threads:[~2024-04-26  4:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 17:17 [PATCH] LoongArch: Select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 Xi Ruoyao
2024-03-29  2:09 ` Huacai Chen
2024-04-26  4:00 ` Huacai Chen [this message]
2024-04-26  5:53   ` Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAhV-H5EZ=7OF7CSiYyZ8_+wWuenpo=K2WT8-6mAT4CvzUC_4g@mail.gmail.com' \
    --to=chenhuacai@kernel.org \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=xry111@xry111.site \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.