From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A474C2D0E4 for ; Wed, 25 Nov 2020 01:18:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90A6120665 for ; Wed, 25 Nov 2020 01:18:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xb55MfWC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90A6120665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khjRu-0004av-Ob for qemu-devel@archiver.kernel.org; Tue, 24 Nov 2020 20:18:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khjQh-0003p0-1C for qemu-devel@nongnu.org; Tue, 24 Nov 2020 20:17:07 -0500 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]:38379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khjQf-0001ta-AF for qemu-devel@nongnu.org; Tue, 24 Nov 2020 20:17:06 -0500 Received: by mail-il1-x142.google.com with SMTP id v3so622281ilo.5 for ; Tue, 24 Nov 2020 17:17:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pkgRQIlWtsQme1mndqUIKP0IbTrQx2NtqFydE7qZ6P4=; b=Xb55MfWC98QkJp9PTnlmI3b8ibaxHhDUz2Sn8tUEfJiLY5SvRWa5w0wvrCoNuSMJZi C4ZKshMaIGiD0sO52zNO/gpW+vES4FuVSUTzCcj6UJmvSUS4ZmRwoBPxv/SaITeBkCnh ogtbuZGMKOxq8e6I07oCiAo6wIE/15eSAoiGFM76mVgBKrxnxFwCMfwew4gkVmd4Kbsl skjbVM5V1Glwvqbe/kvRNJtUX16cNG2AZtT66iB6SR3vszLD8LKdfaVr9cWUV0/Fq6yd lUDci0DAaNDtaGSrO3CRNkJGxY7ThZ4SOoKWruUoz13jfRo651peuOlSx7CjcqIozZ78 OLXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pkgRQIlWtsQme1mndqUIKP0IbTrQx2NtqFydE7qZ6P4=; b=ZNre+gH6w6trw0xjnENmWDNf153U9KutFG44tJ6BOVdYANkftvVmjDPaZoL9Uph1qA CbcmNNFQb8rTKf8hiL4aTxYMhowyS6MtaIKadcuLnoNGGr8OEqbkrh3aq4HypSjq0viw nbFjKjFH/gkQOBRgD3R4B0cZSh2MRNM4SGw0whMpxMp3s66kZp2LH65jqgfv6miQjmI6 2TLibVlkUfVYP6PyF5Y9wfXHSjRbUz4Qc2coGaFtXamEgFglNKy/yImtOt/WiKbEazYB ZNlx8Qu599vpaia80Hv8EaFnVkrnj29RIeEKltjuEB66CA69heIpYNJhzr7WNCGzJnlA gItQ== X-Gm-Message-State: AOAM533W1w1YthLDDAQWmnLTfFngZ0HKlIPAOp4g0cR9TRUo6iCEwYc8 oPkeoNiJwmaVeA1//ayVvWx4cehoW29H9evA3vo= X-Google-Smtp-Source: ABdhPJzQdPitPtr7KyjstDJXowOfoYWgQBvAI0UpVP+xSIZvPo6IFFLLtp/cN+cnBDO0B34BmLL6HGHbt9mNNeoRYv8= X-Received: by 2002:a05:6e02:14ca:: with SMTP id o10mr999779ilk.143.1606267023870; Tue, 24 Nov 2020 17:17:03 -0800 (PST) MIME-Version: 1.0 References: <20200429082916.10669-1-f4bug@amsat.org> <20200429082916.10669-3-f4bug@amsat.org> In-Reply-To: From: Huacai Chen Date: Wed, 25 Nov 2020 09:16:52 +0800 Message-ID: Subject: Re: [PATCH 2/2] target/mips/kvm: Assert unreachable code is not used To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::142; envelope-from=chenhuacai@gmail.com; helo=mail-il1-x142.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Aleksandar Markovic , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Huacai Chen On Tue, Nov 24, 2020 at 6:42 PM Philippe Mathieu-Daud=C3=A9 wrote: > > Huacai, ping? > > On 5/12/20 9:09 AM, Philippe Mathieu-Daud=C3=A9 wrote: > > +Paolo > > > > On 4/29/20 10:29 AM, Philippe Mathieu-Daud=C3=A9 wrote: > >> This code must not be used outside of KVM. Abort if it is. > >> > >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >> --- > >> target/mips/kvm.c | 8 ++------ > >> 1 file changed, 2 insertions(+), 6 deletions(-) > >> > >> diff --git a/target/mips/kvm.c b/target/mips/kvm.c > >> index de3e26ef1f..050bfbd7fa 100644 > >> --- a/target/mips/kvm.c > >> +++ b/target/mips/kvm.c > >> @@ -196,9 +196,7 @@ int kvm_mips_set_interrupt(MIPSCPU *cpu, int irq, > >> int level) > >> CPUState *cs =3D CPU(cpu); > >> struct kvm_mips_interrupt intr; > >> - if (!kvm_enabled()) { > >> - return 0; > >> - } > >> + assert(kvm_enabled()); > >> intr.cpu =3D -1; > >> @@ -219,9 +217,7 @@ int kvm_mips_set_ipi_interrupt(MIPSCPU *cpu, int > >> irq, int level) > >> CPUState *dest_cs =3D CPU(cpu); > >> struct kvm_mips_interrupt intr; > >> - if (!kvm_enabled()) { > >> - return 0; > >> - } > >> + assert(kvm_enabled()); > >> intr.cpu =3D dest_cs->cpu_index; > >> > >