All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huacai Chen <chenhc@lemote.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: James Hogan <jhogan@kernel.org>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Linux MIPS Mailing List <linux-mips@linux-mips.org>,
	"open list:MIPS" <linux-mips@vger.kernel.org>,
	Paul Burton <paul.burton@mips.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	wu zhangjin <wuzhangjin@gmail.com>, zhangfx <zhangfx@lemote.com>
Subject: Re: [PATCH] MIPS: Loongson: Fix GENMASK misuse
Date: Wed, 23 Oct 2019 09:09:01 +0800	[thread overview]
Message-ID: <CAAhV-H5aTTcwBVQrVOuQ_0FZ=6q0paZ=5bAyijnRshJVdESg+w@mail.gmail.com> (raw)
In-Reply-To: <20191022192547.480095-1-rikard.falkeborn@gmail.com>

Reviewd-by: Huacai Chen <chenhc@lemote.com>

Hi, Paul,

I remember that the original patch has a typo "CFUCFG", and you said
that you don't want to rewrite the history to just fix a typo. But now
Rikard has found a real bug, could rewrite be possible?

Huacai

On Wed, Oct 23, 2019 at 3:26 AM Rikard Falkeborn
<rikard.falkeborn@gmail.com> wrote:
>
> Arguments are supposed to be ordered high then low.
>
> Fixes: 6a6f9b7dafd50efc1b2 ("MIPS: Loongson: Add CFUCFG&CSR support")
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>  arch/mips/include/asm/mach-loongson64/loongson_regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/mach-loongson64/loongson_regs.h b/arch/mips/include/asm/mach-loongson64/loongson_regs.h
> index 6e3569ab8936..363a47a5d26e 100644
> --- a/arch/mips/include/asm/mach-loongson64/loongson_regs.h
> +++ b/arch/mips/include/asm/mach-loongson64/loongson_regs.h
> @@ -86,7 +86,7 @@ static inline u32 read_cpucfg(u32 reg)
>  #define LOONGSON_CFG2_LGFTP    BIT(19)
>  #define LOONGSON_CFG2_LGFTPREV GENMASK(22, 20)
>  #define LOONGSON_CFG2_LLFTP    BIT(23)
> -#define LOONGSON_CFG2_LLFTPREV GENMASK(24, 26)
> +#define LOONGSON_CFG2_LLFTPREV GENMASK(26, 24)
>  #define LOONGSON_CFG2_LCSRP    BIT(27)
>  #define LOONGSON_CFG2_LDISBLIKELY      BIT(28)
>
> --
> 2.23.0
>

  reply	other threads:[~2019-10-23  1:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-21 13:50 [PATCH V2 1/3] MIPS: Loongson: Add CFUCFG&CSR support Huacai Chen
2019-09-21 13:50 ` [PATCH V2 2/3] MIPS: Loongson: Add Loongson-3A R4 basic support Huacai Chen
2019-09-21 13:50 ` [PATCH V2 3/3] MIPS: Loongson-3: Add CSR IPI support Huacai Chen
2019-10-07 17:51 ` [PATCH V2 1/3] MIPS: Loongson: Add CFUCFG&CSR support Paul Burton
2019-10-08  7:09   ` Huacai Chen
2019-10-08 18:00     ` Paul Burton
2019-10-09  1:10       ` Jiaxun Yang
2019-10-09  1:37         ` Paul Burton
2019-10-22 19:25 ` [PATCH] MIPS: Loongson: Fix GENMASK misuse Rikard Falkeborn
2019-10-23  1:09   ` Huacai Chen [this message]
2019-10-24  3:57     ` Paul Burton
2019-10-23  6:03   ` rb532, Kernel panic - not syncing: Fatal exception in interrupt Carlo Pisani
2019-10-24  5:02   ` [PATCH] MIPS: Loongson: Fix GENMASK misuse Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAhV-H5aTTcwBVQrVOuQ_0FZ=6q0paZ=5bAyijnRshJVdESg+w@mail.gmail.com' \
    --to=chenhc@lemote.com \
    --cc=jhogan@kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=ralf@linux-mips.org \
    --cc=rikard.falkeborn@gmail.com \
    --cc=wuzhangjin@gmail.com \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.