All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huacai Chen <chenhuacai@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Zhou Yanjie <zhouyu@wanyeetech.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips <linux-mips@vger.kernel.org>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Huacai Chen <chenhuacai@loongson.cn>,
	Ralf Baechle <ralf@linux-mips.org>,
	stable <stable@vger.kernel.org>,
	Discussions about the Letux Kernel 
	<letux-kernel@openphoenux.org>
Subject: Re: [PATCH] MIPS: Fix a longstanding error in div64.h
Date: Wed, 7 Apr 2021 09:27:55 +0800	[thread overview]
Message-ID: <CAAhV-H7V2ykFqCv8n8pYs1ujbUYNy5UqPu21VPyj_Qzx5y8upQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2104062343250.65251@angie.orcam.me.uk>

Hi, Maciej,

On Wed, Apr 7, 2021 at 6:22 AM Maciej W. Rozycki <macro@orcam.me.uk> wrote:
>
> On Tue, 6 Apr 2021, Zhou Yanjie wrote:
>
> > So it seems not a compiler problem.
>
>  This code is rather broken in an obvious way, starting from:
>
>         unsigned long long __n;                                         \
>                                                                         \
>         __high = *__n >> 32;                                            \
>         __low = __n;                                                    \
>
> where `__n' is used uninitialised.  Since this is my code originally I'll
> look into it; we may want to reinstate `do_div' too, which didn't have to
> be removed in the first place.
I think we can reuse the generic do_div().

>
>  Also commit e8e4eb0fbeda ("asm-generic/div64: Fix documentation of
> do_div() parameter") was an incomplete documentation fix.
>
>  Huacai, thanks for your investigation!  Please be more careful in
> verifying your future submissions however.
Sorry, I thought there is only one bug in div64.h, but in fact there
are three...

Huacai
>
>   Maciej

  reply	other threads:[~2021-04-07  1:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 11:24 [PATCH] MIPS: Fix a longstanding error in div64.h Huacai Chen
2021-04-06 12:42 ` H. Nikolaus Schaller
2021-04-06 14:49   ` Zhou Yanjie
2021-04-06 22:22     ` Maciej W. Rozycki
2021-04-07  1:27       ` Huacai Chen [this message]
2021-04-07 13:38         ` Maciej W. Rozycki
2021-04-08  4:56           ` Huacai Chen
2021-04-09  7:17             ` YunQiang Su
2021-04-06 13:06 ` Thomas Bogendoerfer
2021-04-07  0:40   ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAhV-H7V2ykFqCv8n8pYs1ujbUYNy5UqPu21VPyj_Qzx5y8upQ@mail.gmail.com \
    --to=chenhuacai@kernel.org \
    --cc=chenhuacai@loongson.cn \
    --cc=hns@goldelico.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=ralf@linux-mips.org \
    --cc=stable@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=zhouyu@wanyeetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.