From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52112C433E6 for ; Fri, 5 Feb 2021 13:34:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE09464FBC for ; Fri, 5 Feb 2021 13:34:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE09464FBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l81FV-00043C-Dr for qemu-devel@archiver.kernel.org; Fri, 05 Feb 2021 08:34:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l81E7-0003Nq-G6 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 08:32:49 -0500 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:33699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l81E4-0004Rh-O2 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 08:32:47 -0500 Received: by mail-pg1-x530.google.com with SMTP id j2so4580796pgl.0 for ; Fri, 05 Feb 2021 05:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L+iyGWaAQs+cG649Us3GVhl0V0SFFOnCZd7RZcTGzmY=; b=bZIzHzNUbM54kLw1hebfoqnFbYl+yiUqbj0NZp1KoZwKSGUiU0tLinCguwIgpSCGer plPFfunzl1sSOqSEr1R1RIGvBXpxIybWE8GXlrAyuPc0/RCU5dBQB1HpwnXV1QjSvlmL 7WEd7Nib8tqDRiGVSisDzYWauU1ZH6H7zGMKp5Zo7psIkmuHSNFPWmIXn9TtVlpsEIfq y0bjelQ+TGpc5I71BOjDzOAs54pQtuuQIAwIcJem8YzbsnPh3PC8SQJN14gEaoENo4hY xKrRbTFjXsbFpm7CMueBHC2VQk5kZPw9x8cZDVP8pCHLlKrHpdiJjeYkFA9Ykkod/equ xg8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L+iyGWaAQs+cG649Us3GVhl0V0SFFOnCZd7RZcTGzmY=; b=OZW6cNd4/n0oWcfENeHOBTLVobubGlLb3buwHYWpOAraNplLuyEvAiZwjfAm17gxr3 O3ENkWGly5U8mqN3fOw8Nk1/QhcpiZ3gRyMaW0FfsDIETe55bAQ0TKWeW1RRSAKLgfyT 7q/OofwT4+kbHMzD32dIZFcVTm7kmcH0NeDI7KRcP0+TJLexenJa7yNv/c/w7R7aD9+6 VFb5MOVRDda7Y1YC5+BBm7ZJi6y7OphttXiVau8VmEcyF4lkU145y9X7z69zXDBR3cUM Mru24VH9rq2utgwQj3rP+UF/Hlcf1Y3xc3lkLHqmCcZoGPkeVESt/m9xgIhfudZg/JWu cSzQ== X-Gm-Message-State: AOAM531NYRDE+lQLoDQmnrCnHcvcapwRGidY3YsIUuq4evCWLZ9Yq7mv VEBaHXPPjiualWpgQsXwQnhrGAP5I8ic6oFAgP0= X-Google-Smtp-Source: ABdhPJxGsx1kgigStaeU3u2silTZvW7zJWs/HZX1t5h8tB42KTY9HDgplIY24tfEwRkhKqGxnhLJMNe2ymjFv2dxQPg= X-Received: by 2002:a63:4444:: with SMTP id t4mr4305293pgk.329.1612531962930; Fri, 05 Feb 2021 05:32:42 -0800 (PST) MIME-Version: 1.0 References: <20210204162544.65439-1-phillip.ennen@gmail.com> <20210204162544.65439-2-phillip.ennen@gmail.com> In-Reply-To: From: Phillip Tennen Date: Fri, 5 Feb 2021 14:32:31 +0100 Message-ID: Subject: Re: [PATCH 1/2] build: add configure flag to indicate when the host is Darwin To: Thomas Huth Content-Type: multipart/alternative; boundary="000000000000d6e8b605ba96da50" Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=phillip.ennen@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Hajnoczi , jasowang@redhat.com, qemu-devel@nongnu.org, Phillip Tennen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000d6e8b605ba96da50 Content-Type: text/plain; charset="UTF-8" Hrm, good catch. I'm not sure how I missed that. I'm removing this patch for my next round. Thanks! Phillip On Fri, Feb 5, 2021 at 6:56 AM Thomas Huth wrote: > On 04/02/2021 17.25, phillip.ennen@gmail.com wrote: > > From: Phillip Tennen > > > > Although we already have CONFIG_BSD, I added this flag to be sure that > we could rely on various macOS-specific subsystems, such as vmnet.framework. > > > > Signed-off-by: Phillip Tennen > > --- > > configure | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/configure b/configure > > index 87de49e2c2..4afd22bdf5 100755 > > --- a/configure > > +++ b/configure > > @@ -5825,6 +5825,10 @@ if [ "$bsd" = "yes" ] ; then > > echo "CONFIG_BSD=y" >> $config_host_mak > > fi > > > > +if [ "$darwin" = "yes" ] ; then > > + echo "CONFIG_DARWIN=y" >> $config_host_mak > > +fi > > Hi! > > We already have these lines in "configure": > > if test "$darwin" = "yes" ; then > echo "CONFIG_DARWIN=y" >> $config_host_mak > fi > > ... so your patch here looks pretty redundant? > > Thomas > > --000000000000d6e8b605ba96da50 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hrm, good catch. I'm not sure how I missed that.
<= br>
I'm removing this patch for my next round.

=
Thanks!
Phillip

On Fri, Feb 5, 2021 at 6:56 AM Th= omas Huth <thuth@redhat.com> = wrote:
On 04/02/2021 17.25, phillip.ennen@gmail.com wrote:<= br> > From: Phillip Tennen <phillip@axleos.com>
>
> Although we already have CONFIG_BSD, I added this flag to be sure that= we could rely on various macOS-specific subsystems, such as vmnet.framewor= k.
>
> Signed-off-by: Phillip Tennen <phillip@axleos.com>
> ---
>=C2=A0 =C2=A0configure | 4 ++++
>=C2=A0 =C2=A01 file changed, 4 insertions(+)
>
> diff --git a/configure b/configure
> index 87de49e2c2..4afd22bdf5 100755
> --- a/configure
> +++ b/configure
> @@ -5825,6 +5825,10 @@ if [ "$bsd" =3D "yes" ] ; t= hen
>=C2=A0 =C2=A0 =C2=A0echo "CONFIG_BSD=3Dy" >> $config_ho= st_mak
>=C2=A0 =C2=A0fi
>=C2=A0 =C2=A0
> +if [ "$darwin" =3D "yes" ] ; then
> +=C2=A0 echo "CONFIG_DARWIN=3Dy" >> $config_host_mak > +fi

=C2=A0 Hi!

We already have these lines in "configure":

if test "$darwin" =3D "yes" ; then
=C2=A0 =C2=A0echo "CONFIG_DARWIN=3Dy" >> $config_host_mak fi

... so your patch here looks pretty redundant?

=C2=A0 Thomas

--000000000000d6e8b605ba96da50--