From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 2EB69E00D3A; Fri, 5 Apr 2019 14:44:50 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no * trust * [209.85.222.176 listed in list.dnswl.org] * 0.0 HTML_MESSAGE BODY: HTML included in message * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id CA270E00872 for ; Fri, 5 Apr 2019 14:44:48 -0700 (PDT) Received: by mail-qk1-f176.google.com with SMTP id y5so4734390qkc.11 for ; Fri, 05 Apr 2019 14:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sirius-es-it.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uwNbc6Y0A+mMgKv+MByZc1TWF/4Ywh4OysytfIP5A2Q=; b=HZvFNrsWqUD+sihviz0ynFZ3Qb8p0P7cUxI4Sc62zui3UV25xuEmENkDdhu1uv8ggx NlfROBGxEKszfykSUiLv2TOSH2Okhett4oaBbIWkDPW76Mp+Dy8XxsM8We17u9kuJ3tC pP+jQV4u+BifvV24jMcetXTQwG/z5WSic1YXbXsr5v0XY4egLLaGL2mxS4Ke6YcasoX2 jmchqI2ABj3BtOa9wwgwUNy+mzVe4INPLoEBrVQGpb4IADeBHE1J+jSRE+jyXOjW22d6 tce6124Tzl8p7vLZ0XY2PdluntG0F02fx3tzO4gqSskbkkkTuMMaq/UUrg642sA5S1yA si2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uwNbc6Y0A+mMgKv+MByZc1TWF/4Ywh4OysytfIP5A2Q=; b=ngY/ncXUuUzqfBF//O9UiXxjOK2FNl/vOK2WI/V/JusEuE1OP6A1VvrtKQ9BJhqU0X qR1t6qIBDn3tFqioZLrZpeun3rKlgIZKe98Mv1vKLfbaJySZjbtD6/CHpPukofxSUPC/ Rygojs2THD68RwDNG3yWhvdx7crrAntcNzkZrZXJ+GDsFgrHp4zUEDItT6323U5NepB6 mzz9jWVXj36fnmD8z8a0eSxdPWWkKzc+43nRwFEpPuq5XThSZM7fmpa20bacAzXWqc4K 7/8OrVEIQif/+M11Uj4cUImnivKRpq4x42mG8TPqHJnnPkt9h4CVxIQAyPFJkYWW2VM+ 7uUQ== X-Gm-Message-State: APjAAAWW2FdWVXzLCgcJMcpH0Wjw0MWoCit6ThnyQ087o1D9bdRsAzoA bpMdZADjWt4yj86Bftcr+JTVZjc+DyG0fDZNlQfgvJ/x1LXpLZmB X-Google-Smtp-Source: APXvYqwze4CdeL1pBzW6EMQAAxqwdL7OsIH0jvFI1In3YKuzzV5B23nK8DwU3q2tCqBoXkODTmCEHKw/C2NhudMwKtw= X-Received: by 2002:ae9:ef07:: with SMTP id d7mr12845664qkg.100.1554500687782; Fri, 05 Apr 2019 14:44:47 -0700 (PDT) MIME-Version: 1.0 References: <036ebe30-ce24-9e66-9e00-b6431023946c@denx.de> In-Reply-To: From: Matteo Facchinetti Date: Fri, 5 Apr 2019 23:44:36 +0200 Message-ID: To: Stefano Babic Cc: yocto@yoctoproject.org Subject: Re: require and image.bbappend X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 21:44:50 -0000 Content-Type: multipart/alternative; boundary="0000000000004c76ff0585cf6577" --0000000000004c76ff0585cf6577 Content-Type: text/plain; charset="UTF-8" Hi Stefano, Il giorno ven 5 apr 2019 alle ore 18:33 Stefano Babic ha scritto: > Hi Matteo, > > On 05/04/19 17:54, Matteo Facchinetti wrote: > > > > Hi Stefano, > > > > Il giorno gio 4 apr 2019 alle ore 17:32 Stefano Babic > > ha scritto: > > > > Hi Matteo, > > > > On 04/04/19 15:35, Matteo Facchinetti wrote: > > > Hi, > > > > > > I encountered a problem when try to add packages in my image > > recipe, but > > > I don't understernd if I wrong something or I have to do it in > > another way. > > > > > > In detail, in my common_layer there are: > > > - image_base.bb : > > yocto base image > > > - image_with_graphicsupport.bb > > > > > > > : where include image_base.bb > > (require > > > image_base.bb ) > > > > > > Now, in my BSP layer, I want to add some packages to the > > image_base.bb > > > , so I create here the image_base.bbappend > file. > > > But when I try to compile image_with_graphicsupport.bb > > > > > the result is not how > expected. > > > Image_with_graphicsupport.bb doesn't add packages contained in > > > image_base.bbappend but only the packages contained in > > image_base.bb > > > . > > > > > > Is true that when include an image to another with require > statement, > > > you can't extend the base image with a bbappend? > > > > Yes, it is true, because the file is included and it is not anymore > like > > a recipe that can be extend. It will be searched for a > > image_with_graphicsupport.bb > > append, not image_base.bbappend. > > > > > > Ok, understood. > > > > > > IMHO you can easy reach your goal if you write a packagegroup recipe > > where you put all packages you have in the IMAGE_INSTALL of your > > image_base.bb . You can then have a .bbappend > > for the packagegroup in > > your BSP layer (and this then works) and you put the packagegroup in > the > > IMAGE_INSTALL directive of both image_base.bb > and > > Image_with_graphicsupport.bb. > > > > > > Thank you very much for this tip. > > I have done exactly in this way and works perfectly and it's easy to > manage. > > > > :-) > > > However there's a part containded in the image_base.bb > > recipe: > > inherit core-image > > IMAGE_FEATURE_append = "..." > > > > that I had to duplicate into the Image_with_graphicsupport.bb too. > > > > It's not a problem but is it possible to put them in a common recipe > > like packagegroup? > > Then simply write a image_base.inc to factorize what is common and in > both recipes you can include it with "require image_base.inc" > > Oh yes, I didn't think about that. These parts are statics and the "require image_base.inc" statement into the both images recipes is the simplest way and solve the problem... :-) Thanks again. Regards, Matteo Facchinetti Sirius Electronic Systems --0000000000004c76ff0585cf6577 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefano,

Il giorno ven 5 apr 2019 = alle ore 18:33 Stefano Babic <sbabic@d= enx.de> ha scritto:
Hi Matteo,

On 05/04/19 17:54, Matteo Facchinetti wrote:
>
> Hi Stefano,
>
> Il giorno gio 4 apr 2019 alle ore 17:32 Stefano Babic <sbabic@denx.de
> <mailto:sbabic@= denx.de>> ha scritto:
>
>=C2=A0 =C2=A0 =C2=A0Hi Matteo,
>
>=C2=A0 =C2=A0 =C2=A0On 04/04/19 15:35, Matteo Facchinetti wrote:
>=C2=A0 =C2=A0 =C2=A0> Hi,
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> I encountered a problem when try to add packag= es in my image
>=C2=A0 =C2=A0 =C2=A0recipe, but
>=C2=A0 =C2=A0 =C2=A0> I don't understernd if I wrong something o= r I have to do it in
>=C2=A0 =C2=A0 =C2=A0another way.
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> In detail, in my common_layer there are:
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 =C2=A0- image_base.bb <http://image_base.b= b> <http://image_base.bb> :
>=C2=A0 =C2=A0 =C2=A0yocto base image=C2=A0
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 =C2=A0- image_with_graphicsup= port.bb
>=C2=A0 =C2=A0 =C2=A0<http://image_with_graphicsupport.bb>
>=C2=A0 =C2=A0 =C2=A0<http://image_with_graphicsupport.bb>
>=C2=A0 =C2=A0 =C2=A0> : where include image_base.bb <http://image_base.= bb>
>=C2=A0 =C2=A0 =C2=A0<http://image_base.bb> (require
>=C2=A0 =C2=A0 =C2=A0> image_base.bb <http://image_base.bb> <<= a href=3D"http://image_base.bb" rel=3D"noreferrer" target=3D"_blank">http:/= /image_base.bb>)
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> Now, in my BSP layer, I want to add some packa= ges to the
>=C2=A0 =C2=A0 =C2=A0image_base.bb <http://image_base.bb>
>=C2=A0 =C2=A0 =C2=A0> <http://image_base.bb>, so I create here = the image_base.bbappend file.
>=C2=A0 =C2=A0 =C2=A0> But when I try to compile image_with= _graphicsupport.bb
>=C2=A0 =C2=A0 =C2=A0<http://image_with_graphicsupport.bb>
>=C2=A0 =C2=A0 =C2=A0> <http://image_with_graphicsupport= .bb> the result is not how expected.
>=C2=A0 =C2=A0 =C2=A0> Image_with_graphicsupport.bb doesn't add p= ackages contained in
>=C2=A0 =C2=A0 =C2=A0> image_base.bbappend but only the packages cont= ained in
>=C2=A0 =C2=A0 =C2=A0image_base.bb <http://image_base.bb>
>=C2=A0 =C2=A0 =C2=A0> <http://image_base.bb>.
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> Is true that when include an image to another = with require statement,
>=C2=A0 =C2=A0 =C2=A0> you can't extend the base image with a bba= ppend?
>
>=C2=A0 =C2=A0 =C2=A0Yes, it is true, because the file is included and i= t is not anymore like
>=C2=A0 =C2=A0 =C2=A0a recipe that can be extend. It will be searched fo= r a
>=C2=A0 =C2=A0 =C2=A0image_with_graphicsupport.bb <http://image_with_graphicsupport.bb>
>=C2=A0 =C2=A0 =C2=A0append, not image_base.bbappend.
>
>
> Ok, understood.
> =C2=A0
>
>=C2=A0 =C2=A0 =C2=A0IMHO you can easy reach your goal if you write a pa= ckagegroup recipe
>=C2=A0 =C2=A0 =C2=A0where you put all packages you have in the IMAGE_IN= STALL of your
>=C2=A0 =C2=A0 =C2=A0image_base.bb <http://image_base.bb>. You can t= hen have a .bbappend
>=C2=A0 =C2=A0 =C2=A0for the packagegroup in
>=C2=A0 =C2=A0 =C2=A0your BSP layer (and this then works) and you put th= e packagegroup in the
>=C2=A0 =C2=A0 =C2=A0IMAGE_INSTALL directive of both image_base.bb <http://= image_base.bb> and
>=C2=A0 =C2=A0 =C2=A0Image_with_graphicsupport.bb.
>
>
> Thank you very much for this tip.
> I have done exactly in this way and works perfectly and it's easy = to manage.
>

:-)

> However there's a part containded in the image_base.bb
> <http://image_base.bb> recipe:
> =C2=A0 =C2=A0 inherit core-image
> =C2=A0 =C2=A0 IMAGE_FEATURE_append =3D "..."
>
> that I had to duplicate into the Image_with_graphicsupport.bb too.
>
> It's not a problem but is it possible to put them in a common reci= pe
> like packagegroup?

Then simply write a image_base.inc to factorize what is common and in
both recipes you can include it with "require image_base.inc"
=
=C2=A0
=C2=A0Oh yes, I didn't think abo= ut that.
These parts are statics and the "require image_base= .inc" statement into the both images recipes is the simplest way and s= olve the problem... :-)

Thanks again.
Regards,

Matteo Facchinetti
Sirius Electronic Systems
--0000000000004c76ff0585cf6577--