From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFAE8C433E5 for ; Thu, 23 Jul 2020 01:42:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D40620781 for ; Thu, 23 Jul 2020 01:42:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D7L/ZNI6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387527AbgGWBm5 (ORCPT ); Wed, 22 Jul 2020 21:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729198AbgGWBm4 (ORCPT ); Wed, 22 Jul 2020 21:42:56 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7340DC0619DC; Wed, 22 Jul 2020 18:42:56 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id l6so3986539qkc.6; Wed, 22 Jul 2020 18:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Hgi93fl+d8Jztwv9C8gs6eaqKANcCITr2o5G6xotyng=; b=D7L/ZNI66qtNV5JuQnNjl0SDMvevUM3dgtVUc3cnxUfKR6te7KrNdPlqKJ1Ein65u9 N3BUT+aba14tAPV8r5EpRwSBTrSOidxRu0tvFHicS1i3b4rrrQwuI/zatq6iRtoAdOP1 n4nBfsIgNrvXpejJPUSk82EtwqoZ+RIErwzhBvTmUsz+l2ppEp4TzbUHNMvg3Ggs51yp 4ULdTCZBIuAcRu5fauMdldzyk8J8okz06GyatZcdIUvF/WIoW8yNM770AYGD8hcJxXNl jFYaxrifYlQsd8MJkXraL5j9bZzTynkTH/5eCRfgu2WzVfSSAPTh3OW6JdckQUl5XoJT 6Q6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Hgi93fl+d8Jztwv9C8gs6eaqKANcCITr2o5G6xotyng=; b=WIuaKZ99t6+07TnOGMVKsaKeAk+dRfelT4vYl2zq+z3MCvxjjV+JzS/RsFkbBO9WjK 2o+0xqzfeON3X3t8q6nD6ZOytHtSpNVtu9BRYO2x4C6LXN29GFej8UoKQyNVUFH3fVVU FUh6I9WTQVbhCw4iCNkU8QEA/48ahgQHX5994adVL5KJKNtwjEp7DUshTyFz26uGDbRX bBiZ2QWBtDZwqtHaK2lSoiKVVsz8nXnDMfAN83QiOzrez4pRZkjq8DLX4MQr0jKigZhX 6C+ayP4iCg4AJcloOUZxpKf45w8JuVyuwFCEXon/daOyY2J6xFBPqfMMH3GQAHZG9jva ogvA== X-Gm-Message-State: AOAM531UqRucIacbVi1dnlvlK4GWzdhM4kdXxF0o8sDenz3S4QMLl8Sx yI3WTMc1jhNyXHDSjM/+jTJFuKmahK7SA/LK7fQ= X-Google-Smtp-Source: ABdhPJx8VAfEHMvN7Qs5nLr0PCFEisdQTFTIrLgCPq5V5asR/gkL6ddOABn+KhrG/fW8UMQSRzNi5vC/24zVqfQ9BWc= X-Received: by 2002:a37:6d2:: with SMTP id 201mr2782563qkg.187.1595468575726; Wed, 22 Jul 2020 18:42:55 -0700 (PDT) MIME-Version: 1.0 References: <1595302129-23895-1-git-send-email-iamjoonsoo.kim@lge.com> <20200721120533.GD15516@casper.infradead.org> <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz> <20200721124312.GE15516@casper.infradead.org> In-Reply-To: <20200721124312.GE15516@casper.infradead.org> From: Joonsoo Kim Date: Thu, 23 Jul 2020 10:42:44 +0900 Message-ID: Subject: Re: [PATCH] mm/page_alloc: fix memalloc_nocma_{save/restore} APIs To: Matthew Wilcox Cc: Vlastimil Babka , Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Michal Hocko , "Aneesh Kumar K . V" , Joonsoo Kim , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2020=EB=85=84 7=EC=9B=94 21=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 9:43, M= atthew Wilcox =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Tue, Jul 21, 2020 at 02:38:56PM +0200, Vlastimil Babka wrote: > > On 7/21/20 2:05 PM, Matthew Wilcox wrote: > > > On Tue, Jul 21, 2020 at 12:28:49PM +0900, js1304@gmail.com wrote: > > >> @@ -4619,8 +4631,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsign= ed int order, > > >> wake_all_kswapds(order, gfp_mask, ac); > > >> > > >> reserve_flags =3D __gfp_pfmemalloc_flags(gfp_mask); > > >> - if (reserve_flags) > > >> + if (reserve_flags) { > > >> alloc_flags =3D reserve_flags; > > >> + alloc_flags =3D current_alloc_flags(gfp_mask, alloc_flags= ); > > >> + } > > > > > > Is this right? Shouldn't you be passing reserve_flags to > > > current_alloc_flags() here? Also, there's no need to add { } here. > > > > Note the "alloc_flags =3D reserve_flags;" line is not being deleted her= e. But if > > it was, your points would be true, and yeah it would be a bit more tidy= . > > Oh ... I should wake up a little more. > > Yeah, I'd recommend just doing this: > > - alloc_flags =3D reserve_flags; > + alloc_flags =3D current_alloc_flags(gfp_mask, reserve_fla= gs); Okay. I will change it. Just note that the reason that I added it separately is that I think that separation is more readable since we can easily notice that alloc_flags is changed to reserve_flags without inspecting currect_alloc_flags() functi= on. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54EB6C433E3 for ; Thu, 23 Jul 2020 01:42:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F164220781 for ; Thu, 23 Jul 2020 01:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D7L/ZNI6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F164220781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 558116B0002; Wed, 22 Jul 2020 21:42:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 509916B0005; Wed, 22 Jul 2020 21:42:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D2286B0006; Wed, 22 Jul 2020 21:42:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 276346B0002 for ; Wed, 22 Jul 2020 21:42:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C96D7181EC488 for ; Thu, 23 Jul 2020 01:42:56 +0000 (UTC) X-FDA: 77067641952.20.pies94_5e0b63c26f3a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 9ADA9181969FC for ; Thu, 23 Jul 2020 01:42:56 +0000 (UTC) X-HE-Tag: pies94_5e0b63c26f3a X-Filterd-Recvd-Size: 4839 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Jul 2020 01:42:56 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id u64so3956427qka.12 for ; Wed, 22 Jul 2020 18:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Hgi93fl+d8Jztwv9C8gs6eaqKANcCITr2o5G6xotyng=; b=D7L/ZNI66qtNV5JuQnNjl0SDMvevUM3dgtVUc3cnxUfKR6te7KrNdPlqKJ1Ein65u9 N3BUT+aba14tAPV8r5EpRwSBTrSOidxRu0tvFHicS1i3b4rrrQwuI/zatq6iRtoAdOP1 n4nBfsIgNrvXpejJPUSk82EtwqoZ+RIErwzhBvTmUsz+l2ppEp4TzbUHNMvg3Ggs51yp 4ULdTCZBIuAcRu5fauMdldzyk8J8okz06GyatZcdIUvF/WIoW8yNM770AYGD8hcJxXNl jFYaxrifYlQsd8MJkXraL5j9bZzTynkTH/5eCRfgu2WzVfSSAPTh3OW6JdckQUl5XoJT 6Q6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Hgi93fl+d8Jztwv9C8gs6eaqKANcCITr2o5G6xotyng=; b=YGNrJkoiockN1cjpC9oH3ylqljTAcX1SCbUQMiqW0eeOax5Vs2X75t/AjKrmAe9yDB dGsyMffXHM3ljB/V0CTMq9hIt8+JTM8Ou3vPvA6FhQfQ2h9YsjCKObO3Ag5MKE/KJ/iM CAA+meNS0qkwNyK0mAUzYL8z5HJ2ReIu+NLiupkwugLy2IOMR6ube8715pX3PKPj0T9V vDpr/DzcUJPhOVlSm0Mhn96WN0aTkmTWp+MJE6a6x4Wem3RqxPGZzMEZe8xso6Hw5xqG CLW9vl0CoNcJhXYD4Q9Eng8miFb5zU9XQj74l0dNp7feSCNEp3Vmh0PaRtyGWDMX9iZ+ 6hQA== X-Gm-Message-State: AOAM532vx1drjV9Kx5Rh+z8qdRn453B3ORfnTEzxBkq7MWW4ADf20t0t FftOFlSq1KXLRdqApWwpGpd1RQ1gKGD7QLZ3nLo= X-Google-Smtp-Source: ABdhPJx8VAfEHMvN7Qs5nLr0PCFEisdQTFTIrLgCPq5V5asR/gkL6ddOABn+KhrG/fW8UMQSRzNi5vC/24zVqfQ9BWc= X-Received: by 2002:a37:6d2:: with SMTP id 201mr2782563qkg.187.1595468575726; Wed, 22 Jul 2020 18:42:55 -0700 (PDT) MIME-Version: 1.0 References: <1595302129-23895-1-git-send-email-iamjoonsoo.kim@lge.com> <20200721120533.GD15516@casper.infradead.org> <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz> <20200721124312.GE15516@casper.infradead.org> In-Reply-To: <20200721124312.GE15516@casper.infradead.org> From: Joonsoo Kim Date: Thu, 23 Jul 2020 10:42:44 +0900 Message-ID: Subject: Re: [PATCH] mm/page_alloc: fix memalloc_nocma_{save/restore} APIs To: Matthew Wilcox Cc: Vlastimil Babka , Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Michal Hocko , "Aneesh Kumar K . V" , Joonsoo Kim , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9ADA9181969FC X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 7=EC=9B=94 21=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 9:43, M= atthew Wilcox =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Tue, Jul 21, 2020 at 02:38:56PM +0200, Vlastimil Babka wrote: > > On 7/21/20 2:05 PM, Matthew Wilcox wrote: > > > On Tue, Jul 21, 2020 at 12:28:49PM +0900, js1304@gmail.com wrote: > > >> @@ -4619,8 +4631,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsign= ed int order, > > >> wake_all_kswapds(order, gfp_mask, ac); > > >> > > >> reserve_flags =3D __gfp_pfmemalloc_flags(gfp_mask); > > >> - if (reserve_flags) > > >> + if (reserve_flags) { > > >> alloc_flags =3D reserve_flags; > > >> + alloc_flags =3D current_alloc_flags(gfp_mask, alloc_flags= ); > > >> + } > > > > > > Is this right? Shouldn't you be passing reserve_flags to > > > current_alloc_flags() here? Also, there's no need to add { } here. > > > > Note the "alloc_flags =3D reserve_flags;" line is not being deleted her= e. But if > > it was, your points would be true, and yeah it would be a bit more tidy= . > > Oh ... I should wake up a little more. > > Yeah, I'd recommend just doing this: > > - alloc_flags =3D reserve_flags; > + alloc_flags =3D current_alloc_flags(gfp_mask, reserve_fla= gs); Okay. I will change it. Just note that the reason that I added it separately is that I think that separation is more readable since we can easily notice that alloc_flags is changed to reserve_flags without inspecting currect_alloc_flags() functi= on. Thanks.