From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E188AC433E1 for ; Thu, 23 Jul 2020 01:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAB27208E4 for ; Thu, 23 Jul 2020 01:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WUAK93Py" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387516AbgGWBi3 (ORCPT ); Wed, 22 Jul 2020 21:38:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728914AbgGWBi2 (ORCPT ); Wed, 22 Jul 2020 21:38:28 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5338C0619DC; Wed, 22 Jul 2020 18:38:28 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id j187so3949592qke.11; Wed, 22 Jul 2020 18:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YZZc8tkRzFODbKr19PJHEkff/Ao3Y0B9UKvSStxkk20=; b=WUAK93PyKvCgFkmf5Q+ixIMgxah07B/C0uAthIE/DzScCc+w8IR30LCq1mYDz6LfpH 1kOMw5ip73ylC2ovfZfd+IorBh3E0ezinrSrm4wUS7en6CApNbl5AAAuwlRjCNprNYjY a2j+nVQyF8A7JHdd8vW4FkB7zykVjT7KL8/maqPetPanjWHbr4DnbEYBgGz3P4nmxTqh L8dFReXq+kVNsAs1inGVG+sRoGzsbJ52VC0WXJzDum3MCFbF8XCYvBvXwtuNyG1BGlv7 PpFz9jK9CS75DEL9XdEfB64fm2wws0swbFGwiWoK0HFQvKV8GyQMrNFbb/ueYvmIKt+b M3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YZZc8tkRzFODbKr19PJHEkff/Ao3Y0B9UKvSStxkk20=; b=LLX+lvlSYy5bWaXoUlCSXzGKXRSucOcesvL19Tw8aN/dP64zI21lAUCIyDIgCP2v89 NLwtBruHw7cobbIExNPMPPMENfN8WxSX1RQIdx6lgoyKFLBbCyEvq3AR5tT0/2aZ0rHg u8KJJpSenYVeTxdKHbfe5Qww91RzIE61VlZ1ehsKL7HDIqG+fGdD2gUFFPxh43aa0S00 mLdgrk1yx5o+744BvRBHEB+mWuP/T1UDRP5llaQ7OieYnjQtJM4YmnuUeTLiF2WOdxu4 YsNAeWvJuQn/Vbg3F12o3gnJpxOn2Q75kcMZIjX9F2yntwsXNzHeePs7cZKPijvvowgZ 9Mbg== X-Gm-Message-State: AOAM530hYpKL3n0hsXOIlPX01NS+1SCZ2A8UgEDwpZs7Ws1Qh/3kGi9k 2zV/OTJyDuJEsAB3WUf9oZ2N2rU3IzCITl4k1sQ= X-Google-Smtp-Source: ABdhPJzEPNS6XZft4HQw4J9+FY04X6wifZJcaeJ9gK+GPmo4Kkrtg1rJ0VNFEiFCXwfeMMXPSn2gWbM+MF4x+PinGKE= X-Received: by 2002:a37:6d2:: with SMTP id 201mr2771283qkg.187.1595468307797; Wed, 22 Jul 2020 18:38:27 -0700 (PDT) MIME-Version: 1.0 References: <1595302129-23895-1-git-send-email-iamjoonsoo.kim@lge.com> <20200721120533.GD15516@casper.infradead.org> <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz> In-Reply-To: <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz> From: Joonsoo Kim Date: Thu, 23 Jul 2020 10:38:16 +0900 Message-ID: Subject: Re: [PATCH] mm/page_alloc: fix memalloc_nocma_{save/restore} APIs To: Vlastimil Babka Cc: Matthew Wilcox , Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Michal Hocko , "Aneesh Kumar K . V" , Joonsoo Kim , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2020=EB=85=84 7=EC=9B=94 21=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 9:39, V= lastimil Babka =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On 7/21/20 2:05 PM, Matthew Wilcox wrote: > > On Tue, Jul 21, 2020 at 12:28:49PM +0900, js1304@gmail.com wrote: > >> +static inline unsigned int current_alloc_flags(gfp_t gfp_mask, > >> + unsigned int alloc_flags) > >> +{ > >> +#ifdef CONFIG_CMA > >> + unsigned int pflags =3D current->flags; > >> + > >> + if (!(pflags & PF_MEMALLOC_NOCMA) && > >> + gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE) > >> + alloc_flags |=3D ALLOC_CMA; > > > > Please don't indent by one tab when splitting a line because it looks l= ike > > the second line and third line are part of the same block. Either do > > this: > > > > if (!(pflags & PF_MEMALLOC_NOCMA) && > > gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE) > > alloc_flags |=3D ALLOC_CMA; > > > > or this: > > if (!(pflags & PF_MEMALLOC_NOCMA) && > > gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE) > > alloc_flags |=3D ALLOC_CMA; > > Ah, good point. Will change it. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799D7C433E3 for ; Thu, 23 Jul 2020 01:38:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3ED202080D for ; Thu, 23 Jul 2020 01:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WUAK93Py" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ED202080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B27646B0002; Wed, 22 Jul 2020 21:38:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD6E86B0005; Wed, 22 Jul 2020 21:38:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EC006B0006; Wed, 22 Jul 2020 21:38:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 8CE096B0002 for ; Wed, 22 Jul 2020 21:38:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1A2BE18024E03 for ; Thu, 23 Jul 2020 01:38:29 +0000 (UTC) X-FDA: 77067630738.04.stone64_0602a0526f3a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id D879281892D2 for ; Thu, 23 Jul 2020 01:38:28 +0000 (UTC) X-HE-Tag: stone64_0602a0526f3a X-Filterd-Recvd-Size: 4447 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Jul 2020 01:38:28 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id u64so3949682qka.12 for ; Wed, 22 Jul 2020 18:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YZZc8tkRzFODbKr19PJHEkff/Ao3Y0B9UKvSStxkk20=; b=WUAK93PyKvCgFkmf5Q+ixIMgxah07B/C0uAthIE/DzScCc+w8IR30LCq1mYDz6LfpH 1kOMw5ip73ylC2ovfZfd+IorBh3E0ezinrSrm4wUS7en6CApNbl5AAAuwlRjCNprNYjY a2j+nVQyF8A7JHdd8vW4FkB7zykVjT7KL8/maqPetPanjWHbr4DnbEYBgGz3P4nmxTqh L8dFReXq+kVNsAs1inGVG+sRoGzsbJ52VC0WXJzDum3MCFbF8XCYvBvXwtuNyG1BGlv7 PpFz9jK9CS75DEL9XdEfB64fm2wws0swbFGwiWoK0HFQvKV8GyQMrNFbb/ueYvmIKt+b M3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YZZc8tkRzFODbKr19PJHEkff/Ao3Y0B9UKvSStxkk20=; b=m5Vdy39GTId1qQHMCpkvL2FPZbwSLhIXwLVjyBJJBGTQl+jGxUAPxjn6jsioEJ/GI+ eyvGbjvVf0obU5N2gyYE2v8m4XAESU+k5z2oydFgzdQk37yOlhc6O0kQciX1BOjICIhf fcQ+bSnVc/qzfGYSFfmR0/i79nL7cxSMpoIKOVRQ5Wv/kem2M+QVxjDq3v9+onbJuc8l O9yd3TlCcK+Diw78pSJGSl0bXR6/mgW+uh1p0+HpvHGbq/fcHJT+H89lbezxy1IspeFc tvC6E4CpC8PYGKpa5S/eZaXRRKpAJ4N7QT+psypcMPHryU1OZ0/5htanx6RJnx19Mdeo rFOg== X-Gm-Message-State: AOAM5329dNgMm5DULUfcATvwIiq1LEbRA1ihUkszOxaQRe/JqwDCnNfc V9MWLjZdR9GV9tgtyRjDL1fKR03MW/D24GQ1kUc= X-Google-Smtp-Source: ABdhPJzEPNS6XZft4HQw4J9+FY04X6wifZJcaeJ9gK+GPmo4Kkrtg1rJ0VNFEiFCXwfeMMXPSn2gWbM+MF4x+PinGKE= X-Received: by 2002:a37:6d2:: with SMTP id 201mr2771283qkg.187.1595468307797; Wed, 22 Jul 2020 18:38:27 -0700 (PDT) MIME-Version: 1.0 References: <1595302129-23895-1-git-send-email-iamjoonsoo.kim@lge.com> <20200721120533.GD15516@casper.infradead.org> <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz> In-Reply-To: <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz> From: Joonsoo Kim Date: Thu, 23 Jul 2020 10:38:16 +0900 Message-ID: Subject: Re: [PATCH] mm/page_alloc: fix memalloc_nocma_{save/restore} APIs To: Vlastimil Babka Cc: Matthew Wilcox , Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Michal Hocko , "Aneesh Kumar K . V" , Joonsoo Kim , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D879281892D2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000047, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 7=EC=9B=94 21=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 9:39, V= lastimil Babka =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On 7/21/20 2:05 PM, Matthew Wilcox wrote: > > On Tue, Jul 21, 2020 at 12:28:49PM +0900, js1304@gmail.com wrote: > >> +static inline unsigned int current_alloc_flags(gfp_t gfp_mask, > >> + unsigned int alloc_flags) > >> +{ > >> +#ifdef CONFIG_CMA > >> + unsigned int pflags =3D current->flags; > >> + > >> + if (!(pflags & PF_MEMALLOC_NOCMA) && > >> + gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE) > >> + alloc_flags |=3D ALLOC_CMA; > > > > Please don't indent by one tab when splitting a line because it looks l= ike > > the second line and third line are part of the same block. Either do > > this: > > > > if (!(pflags & PF_MEMALLOC_NOCMA) && > > gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE) > > alloc_flags |=3D ALLOC_CMA; > > > > or this: > > if (!(pflags & PF_MEMALLOC_NOCMA) && > > gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE) > > alloc_flags |=3D ALLOC_CMA; > > Ah, good point. Will change it. Thanks.