All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ross Burton" <ross@burtonini.com>
To: Khasim Mohammed <khasim.mohammed@arm.com>
Cc: "jdmason@kudzu.us" <jdmason@kudzu.us>,
	Diego Sueiro <Diego.Sueiro@arm.com>,
	 "meta-arm@lists.yoctoproject.org"
	<meta-arm@lists.yoctoproject.org>
Subject: Re: [meta-arm] [PATCH] meta-arm: Add UEFI EDK2 support for Arm platforms
Date: Thu, 11 Jun 2020 17:21:40 +0100	[thread overview]
Message-ID: <CAAnfSTtDg=dqLOh1q_x-RYoZkgg_R-8V5FMx3qEo4r--M8EAqA@mail.gmail.com> (raw)
In-Reply-To: <DB8PR08MB4969C10F23F416CF55ADD288FA800@DB8PR08MB4969.eurprd08.prod.outlook.com>

On Thu, 11 Jun 2020 at 16:46, Khasim Mohammed <khasim.mohammed@arm.com> wrote:
> Please apply this patch to dunfell branch as well.

Let's not just yet.

| gcc  -o ../bin/DevicePath   DevicePath.o UefiDevicePathLib.o
DevicePathFromText.o  DevicePathUtilities.o -L../libs -lCommon -luuid
| /home/ross/Yocto/build/tmp/hosttools/ld: cannot find -luuid
ERROR: Task (/home/ross/Yocto/meta-arm/meta-arm/recipes-bsp/uefi/edk2-firmware_git.bb:do_compile)
failed with exit code '1'

Note how it's not passing any of the linker flags that would be needed
to compile native code correctly.  This only works for people who it
has worked for because they have util-linux-dev installed on their
host.

oe-core already has a EDK2 recipe of sorts, ovmf_git.bb.  Brace
yourself before looking at this, because the twists it goes through to
build EDK2 correctly is not pretty.  Specifically fix_toolchain() and
friends look relevant.  My hunch is that it's time oe-core has a
common EDK2 include file or skeleton recipe that everyone else can
extend.

Also, can we please stop creating separate bb/inc files unless there's
a good reason.  It just complicates reading the recipe without any
advantages.

Ross

      reply	other threads:[~2020-06-11 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 16:07 [PATCH] meta-arm: Add UEFI EDK2 support for Arm platforms Khasim Mohammed
2020-06-11 12:20 ` Diego Sueiro
2020-06-11 14:03   ` [meta-arm] " Jon Mason
2020-06-11 15:46     ` Khasim Mohammed
2020-06-11 16:21       ` Ross Burton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAnfSTtDg=dqLOh1q_x-RYoZkgg_R-8V5FMx3qEo4r--M8EAqA@mail.gmail.com' \
    --to=ross@burtonini.com \
    --cc=Diego.Sueiro@arm.com \
    --cc=jdmason@kudzu.us \
    --cc=khasim.mohammed@arm.com \
    --cc=meta-arm@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.