From: "Ross Burton" <ross@burtonini.com>
To: Ben Horgan <ben.horgan@arm.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [oe] [meta-oe][PATCH] cpputest: Add initial recipe. Version 4.0.
Date: Fri, 16 Jul 2021 12:48:02 +0100 [thread overview]
Message-ID: <CAAnfSTtQLewmg-yYv9JWdY57vzccFL3aSQBAZvbrkeVuf5v+Yw@mail.gmail.com> (raw)
In-Reply-To: <20210716103353.4318-1-ben.horgan@arm.com>
On Fri, 16 Jul 2021 at 11:34, Ben Horgan <ben.horgan@arm.com> wrote:
> +SECTIONS = "libs"
SECTION, not SECTIONS. Arguably, this is 'devel'.
> +PV = "4.0+git${SRCPV}"
The SRVREV is the 4.0 tag, so there's no need to put the SHA in the
PV. Remove this line.
> +OECMAKE_GENERATOR = "Unix Makefiles"
Is this actually needed? If so, is a bug filed upstream?
> +FILES_${PN} += "${libdir}/CppUTest/*"
There doesn't appear to be anything in this directory, or even this
package as there's only a static library built and no shared library.
Remove?
> +FILES_${PN}-dev += "${libdir}/CppUTest/cmake/*"
Really need to get cmake.bbclass to do this...
Ross
prev parent reply other threads:[~2021-07-16 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 10:33 [meta-oe][PATCH] cpputest: Add initial recipe. Version 4.0 Ben Horgan
2021-07-16 11:48 ` Ross Burton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAnfSTtQLewmg-yYv9JWdY57vzccFL3aSQBAZvbrkeVuf5v+Yw@mail.gmail.com \
--to=ross@burtonini.com \
--cc=ben.horgan@arm.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.