All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ross Burton" <ross@burtonini.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/2] bitbake.conf: ensure BUILD_* tools match target tools
Date: Wed, 24 Mar 2021 09:41:37 +0000	[thread overview]
Message-ID: <CAAnfSTuPcUV3FSThU_Zbs2Bn2vKJykFboGmiH+ZsOAHvj2VP0w@mail.gmail.com> (raw)
In-Reply-To: <CAJ86T=UsfzS0KMHVpyXkeL3aio9mU-9hszabKq56EBeZ+RxEuw@mail.gmail.com>

On Tue, 23 Mar 2021 at 21:53, Andre McCurdy <armccurdy@gmail.com> wrote:
> > @@ -541,7 +541,10 @@ export BUILD_AR = "${BUILD_PREFIX}ar"
> >  export BUILD_AS = "${BUILD_PREFIX}as ${BUILD_AS_ARCH}"
> >  export BUILD_RANLIB = "${BUILD_PREFIX}ranlib"
> >  export BUILD_STRIP = "${BUILD_PREFIX}strip"
> > +export BUILD_OBJCOPY = "${BUILD_PREFIX}objcopy"
> > +export BUILD_OBJDUMP = "${BUILD_PREFIX}objdump"
> >  export BUILD_NM = "${BUILD_PREFIX}nm"
> > +export BUILD_READELF = "${BUILD_PREFIX}readelf"
>
> Do these new variables need to be exported?
>
> As far as I remember a few of the BUILD_xxx variables are "official"
> autotools variables which some autotools packages may expect to find
> in the environment (although googling now doesn't find any
> references).
>
> If so then the rest (i.e. most of them, and certainly these newly
> added ones) are OE specific and only used in OE recipes and classes...
> and therefore don't need to be exported here.

It was all in the name of consistency.

The Meson cross-file sets readelf, so to mirror the new native-file
also sets readelf.  There wasn't a BUILD_READELF and if someone is
changing BUILD_CC there's a good chance they'll be changing the entire
toochain, so I added any missing entries.

Yes, BUILD_* are effectively OE-specific so we could unexport the
entire set.  I'd prefer to do that than have some exported and some
not.

Ross

  reply	other threads:[~2021-03-24  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 21:28 [PATCH 1/2] bitbake.conf: ensure BUILD_* tools match target tools Ross Burton
2021-03-23 21:28 ` [PATCH 2/2] meson: use native-file instead of environment variables Ross Burton
2021-03-25 19:05   ` [OE-core] " Ross Burton
2021-03-23 21:52 ` [OE-core] [PATCH 1/2] bitbake.conf: ensure BUILD_* tools match target tools Andre McCurdy
2021-03-24  9:41   ` Ross Burton [this message]
2021-03-24 10:37     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAnfSTuPcUV3FSThU_Zbs2Bn2vKJykFboGmiH+ZsOAHvj2VP0w@mail.gmail.com \
    --to=ross@burtonini.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.