From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbZhl-0000iu-Uq for qemu-devel@nongnu.org; Wed, 08 Feb 2017 16:23:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbZhl-0001fK-8l for qemu-devel@nongnu.org; Wed, 08 Feb 2017 16:23:09 -0500 Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]:36547) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbZhl-0001eo-3X for qemu-devel@nongnu.org; Wed, 08 Feb 2017 16:23:09 -0500 Received: by mail-io0-x244.google.com with SMTP id q20so212077ioi.3 for ; Wed, 08 Feb 2017 13:23:09 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170202100856.GA22164@stefanha-x1.localdomain> References: <20161115124417.GC9226@lemon> <20161115144551.GB17672@stefanha-x1.localdomain> <20161115150016.GD9226@lemon> <20161115192026.GA26428@stefanha-x1.localdomain> <87eg2bokx0.fsf@dusky.pond.sub.org> <20161116094901.GA31999@lemon> <20170202100856.GA22164@stefanha-x1.localdomain> From: ashish mittal Date: Wed, 8 Feb 2017 13:23:07 -0800 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel , Fam Zheng , Markus Armbruster , Kevin Wolf , Peter Maydell , "Venkatesha M.G." , Ashish Mittal , Jeff Cody , Rakesh Ranjan , Ketan Nilangekar , Abhijit Dey , Paolo Bonzini , Buddhi Madhav , John Ferlan , "Daniel P. Berrange" , Nitin Jerath , Suraj Singh , Peter Krempa We have retained the original syntax in v7 per the following suggestion on libvirt thread - >> That is correct. Above syntax would also work for us. I will pose this >> suggestion to the qemu community and update with their response. >> It's not that important... I was looking for a simplification and generation of only what's required. You can continue using the server syntax - perhaps just leave a note/comment in the code indicating the decision point and move on. On Thu, Feb 2, 2017 at 2:08 AM, Stefan Hajnoczi wrote: > On Tue, Jan 31, 2017 at 05:55:47PM -0800, ashish mittal wrote: >> Hi, >> >> There has been some work going on on the VxHS libvirt patches and we >> are making good progress. >> >> A suggestion has been made on the libvirt community to check if we can >> change the qemu VxHS device specification syntax as follows. >> >> Replace >> >> (a) +file.server.host=192.168.0.1,file.server.port=9999 >> >> with >> >> (b) +file.host=192.168.0.1,file.port=9999 >> >> The reasoning being that since we have only one host (true as the >> failover is now being handled completely/transparently) within the >> libqnio library), the "server" part is redundant. > > Sounds good to me. > > Stefan