From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25CCC433F5 for ; Thu, 17 Mar 2022 12:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233400AbiCQMFh (ORCPT ); Thu, 17 Mar 2022 08:05:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233333AbiCQMFe (ORCPT ); Thu, 17 Mar 2022 08:05:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0ADDD19315E for ; Thu, 17 Mar 2022 05:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647518657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FdTSBCWZfRB7gl4NcFBlztb/OOGHep3RIbzmatr6VFQ=; b=doYa7O7SpvTlH0Wc3RixiVHVUzdCBa6XZU2S79U6dO8d989sNw1XMgkeizivEjoIyTQrWj Hed6gl91pKO7Jv6Kmu71hTUKqaaTy8qO69S9mrs3IxoUhduJw1yPGQW3LwJnECXuo5ebU4 B9j1cAbqii6JCc1WlmPsWMEJS5yp4cQ= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-2LY7Ws31N6SK2Wq2T1FOJA-1; Thu, 17 Mar 2022 08:04:16 -0400 X-MC-Unique: 2LY7Ws31N6SK2Wq2T1FOJA-1 Received: by mail-lf1-f72.google.com with SMTP id y5-20020ac255a5000000b00448bc398d34so1363701lfg.15 for ; Thu, 17 Mar 2022 05:04:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FdTSBCWZfRB7gl4NcFBlztb/OOGHep3RIbzmatr6VFQ=; b=oyd2ra6/jRnI+bhHwSbiaP14NGSCVTHD/t87dHgGbEGW78ViLxgl44pMoJXaxWwjv8 YoEcB6pOGwxprlFQxVIOENA7X2ItTkPVaFmBp9WM/2RIlDqkEbZaMt991c4fqpz+ZWZ+ TKnNfYegI5Bm6GVoJ8VrbHT0KV7b4YTqHLPn98iH6iqLhXuK2wk+rWrETSV7onEDashK MEs2x1BbHDOnu3E7Yc/sWO1vSELiDdy3TKM7YWW5InkbG165LthvXAxDl7tSSETqehWf 9VmJzJSoxSK3mG6KPg6AW2fBEC9S4PLUBvKuTQn3d7n+UCyVTPioKGBcmOCnCsVR37X4 aIjA== X-Gm-Message-State: AOAM531zZIV37l68bNiuCKh6l0DyWT8m1kZNlMxEihcVw9MOuWfPrtvV 1hlPUHIat9ebbTDfFuujBrMEwasCp0KAAi2TGOZRnOP7cIzjSVKSUsKzk9rqUaHXk2O8LfLtEld nX5kbOyvZzyWDUpsV1tG3f/R3uj8V34ltbluLQiwb X-Received: by 2002:a05:6512:44f:b0:449:b929:a301 with SMTP id y15-20020a056512044f00b00449b929a301mr2699657lfk.180.1647518649511; Thu, 17 Mar 2022 05:04:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwn2/gammYMEhSTgjHb3uCUKDlyraLf9N+wqpMA6XqrZ9+XtOOCoVlma0IkJ0zgfZJMfBknwy+BxtFxUgrIIYI= X-Received: by 2002:a05:6512:44f:b0:449:b929:a301 with SMTP id y15-20020a056512044f00b00449b929a301mr2699643lfk.180.1647518649298; Thu, 17 Mar 2022 05:04:09 -0700 (PDT) MIME-Version: 1.0 References: <20220316143646.13301-1-wander@redhat.com> <20220316143646.13301-3-wander@redhat.com> In-Reply-To: From: Wander Costa Date: Thu, 17 Mar 2022 09:03:55 -0300 Message-ID: Subject: Re: [PATCH v4 2/5] serial/8250: Use the cache value of the FCR register To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Wander Lairson Costa , Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , "Maciej W. Rozycki" , Serge Semin , Lukas Wunner , =?UTF-8?Q?Pali_Roh=C3=A1r?= , "open list:SERIAL DRIVERS" , open list , Steven Rostedt , Sergey Senozhatsky , =?UTF-8?Q?Andr=C3=A9_Goddard_Rosa?= , Sudip Mukherjee , Andy Shevchenko , David Laight , Jon Hunter , phil@raspberrypi.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2022 at 5:31 AM Ilpo J=C3=A4rvinen wrote: > > On Wed, 16 Mar 2022, Wander Lairson Costa wrote: > > > commit 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") > > erroneous tries to read the FCR register content, but this register is > > write-only. > > > > This patch fixes that by reading the content from the port struct fcr > > field. > > > > Thanks to Jon Hunter and Jiri Slaby. > > > > Suggested-by: Jiri Slaby > > Reported-by: Jon Hunter > > Signed-off-by: Wander Lairson Costa > > --- > > drivers/tty/serial/8250/8250_port.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8= 250/8250_port.c > > index 2abb3de11a48..9f3fa9fe2a4e 100644 > > --- a/drivers/tty/serial/8250/8250_port.c > > +++ b/drivers/tty/serial/8250/8250_port.c > > @@ -3410,7 +3410,7 @@ void serial8250_console_write(struct uart_8250_po= rt *up, const char *s, > > > > use_fifo =3D (up->capabilities & UART_CAP_FIFO) && > > port->fifosize > 1 && > > - (serial_port_in(port, UART_FCR) & UART_FCR_ENABLE_FIFO) &= & > > + (up->fcr & UART_FCR_ENABLE_FIFO) && > > Didn't you just add this line in 1/5? Please merge this kind of fixes tha= t > are due to development history of a change to the main patch itself. > The reason is that 1/5 has been applied in 5.17 and then reverted, so I thought it would make it easier for reviewers if I sent the new fixes in different commits. If that's not the case, I can send a squashed version with the changelog described in 0/5.