From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54785)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <riku.voipio@linaro.org>) id 1UF4DZ-0005Qs-Mc
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 11:00:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <riku.voipio@linaro.org>) id 1UF4DT-0007iN-5n
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 11:00:49 -0400
Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:41043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <riku.voipio@linaro.org>) id 1UF4DS-0007i4-SB
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 11:00:42 -0400
Received: by mail-qc0-f180.google.com with SMTP id v28so1523478qcm.25
	for <qemu-devel@nongnu.org>; Mon, 11 Mar 2013 08:00:42 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CABoDooOSM8HrNz+AHE7Xm64kfShLdVFWg4OsNqJ-ss_np0Aevw@mail.gmail.com>
References: <cover.1328280144.git.riku.voipio@linaro.org>
	<d0fd11ffd3e2cb65234da354f14d745e5fbfce67.1328280144.git.riku.voipio@linaro.org>
	<CABoDooPGx1ZJ_df+uTGim49oo2Epe_gv7gkzSgx=mPDj2NkHfg@mail.gmail.com>
	<CABoDooOSM8HrNz+AHE7Xm64kfShLdVFWg4OsNqJ-ss_np0Aevw@mail.gmail.com>
Date: Mon, 11 Mar 2013 17:00:41 +0200
Message-ID: <CAAqcGH=KKOTZeyM2uNntOn9jfy1EFdkuCOjxGYgeN9R_3SY3pg@mail.gmail.com>
From: Riku Voipio <riku.voipio@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now
 mandatory on all targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-devel@nongnu.org

>>>  #if defined(TARGET_ARM) || defined(TARGET_M68K) || defined(TARGET_UNICORE32)
>>>     /* Extra fields for semihosted binaries.  */
>>> -    uint32_t stack_base;
>>>     uint32_t heap_base;
>>>     uint32_t heap_limit;
>>>  #endif
>>> +    uint32_t stack_base;

>> Shouldn't this be abi_ulong instead of uint32_t?

> Ping...

> Yes it's more than a year old, but if Aarch64 support with semihosting
> ever comes to life :)

You are right, but we need to change the other variables as well, and
the tswap32 code in semihosting code while at it? I think the change
is probable better done in the patches that actually add aarch64
semihosting support to qemu.

Riku