From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933065AbdBPSLx (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Feb 2017 13:11:53 -0500
Received: from mail-qt0-f177.google.com ([209.85.216.177]:34225 "EHLO
        mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932739AbdBPSLv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Feb 2017 13:11:51 -0500
MIME-Version: 1.0
In-Reply-To: <20170216175621.GB17067@obsidianresearch.com>
References: <20170215180612.GB3317@obsidianresearch.com> <CANk1AXSTMynxMrDZ=aHsoX4naqByJnsRXPBvRGTSBpv2_5WptQ@mail.gmail.com>
 <alpine.DEB.2.20.1702151133150.2458@mgerlach-VirtualBox> <20170215203734.GC5531@obsidianresearch.com>
 <CAAtXAHfDXCcKutuLOWq0cK3zBp2ujV+GcvC9bYSFw==guOzBdA@mail.gmail.com>
 <20170215211528.GA9125@obsidianresearch.com> <CAAtXAHev7VdUNeHbBEfRu-3oVMXvhkL2wKBFw1JUefaMTsWE+g@mail.gmail.com>
 <CANk1AXSCpyU=wKx1Fz_6inW7J5syX1zwx8BRD3Ar3XuXDkfuyA@mail.gmail.com>
 <CAAtXAHdG9GP_0LffHMyJ9T=cVuZMJrR8JNTwXXVuYQGj1y=3KQ@mail.gmail.com>
 <CANk1AXQmcUO4YpWq9qVg6_MQdpWWQ+94NM0Y0pcd__ZwfV91OQ@mail.gmail.com> <20170216175621.GB17067@obsidianresearch.com>
From: Moritz Fischer <moritz.fischer@ettus.com>
Date: Thu, 16 Feb 2017 10:11:49 -0800
Message-ID: <CAAtXAHdy+0A3+r2HtSXgupBG60cji2cFQ_ynnX4dGhMb+x1vgQ@mail.gmail.com>
Subject: Re: [RFC 7/8] fpga-region: add sysfs interface
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Alan Tull <delicious.quinoa@gmail.com>,
        matthew.gerlach@linux.intel.com,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-fpga@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2017 at 9:56 AM, Jason Gunthorpe
<jgunthorpe@obsidianresearch.com> wrote:
> On Thu, Feb 16, 2017 at 11:47:08AM -0600, Alan Tull wrote:
>
>> > Just to clarify: I was proposing using the binary format of dts,
>> > not actually requiring devicetree for it to work. There's plenty
>> > of people running u-boot on x86 using FIT images to boot.
>>
>> The FPGA images should not be required to have OS specific parts.
>> Some ahem non-Linux OS's that use FPGAs don't use device tree, so that
>> adds an extra complication for them unnecessarily.

That's a good point, I had assumed that pulling in a C library shouldn't
be an issue for any OS (u-boot can do it, BSD can do it, Linux can do it).
I have to admit I didn't think about Windows :)

> Not just that, but we parse the bitfile headers in user space as well.
>
> Requiring people to use libfdt pretty much kills the idea because of
> its GPL license.

<snip>

libfdt, however, is GPL/BSD dual-licensed.  That is, it may be used
either under the terms of the GPL, or under the terms of the 2-clause
BSD license (aka the ISC license).  The full terms of that license are
given in the copyright banners of each of the libfdt source files.
This is, in practice, equivalent to being BSD licensed, since the
terms of the BSD license are strictly more permissive than the GPL.

</snip>

> As I've shown the plain text headers can be produced in a scripting
> langauge, and are trivially consumed without much trouble. IHMO this
> makes it more likely there would be adoption..

If you provide a reasonably well documented format and make your tools
easy to use and integrate, I don't think that would be an issue.

I was really mainly concerned about the parsing userspace provided
strings in kernel being a security issue.

If everyone else feels http style plain text is the best we can do, so be it.

I wanted to look around and see how far I get with fdt, but anyway I'm quite
busy with other work at the moment. If someone comes around and writes
code that we can review, maybe that's better than not having a solution.

I'll see how far I get, maybe it turns out my proposal is a bad idea anyways
once I start writing actual code :)

Moritz