From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750954AbdEERIS (ORCPT <rfc822;w@1wt.eu>);
        Fri, 5 May 2017 13:08:18 -0400
Received: from mail.kernel.org ([198.145.29.136]:59210 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750767AbdEERIR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 May 2017 13:08:17 -0400
MIME-Version: 1.0
In-Reply-To: <1492697401-11211-7-git-send-email-atull@kernel.org>
References: <1492697401-11211-1-git-send-email-atull@kernel.org> <1492697401-11211-7-git-send-email-atull@kernel.org>
From: Moritz Fischer <mdf@kernel.org>
Date: Fri, 5 May 2017 10:08:11 -0700
X-Gmail-Original-Message-ID: <CAAtXAHeAs02CKjb4z3RM29nzk58q_rN7f4GvdExSfd=vsLZQqQ@mail.gmail.com>
Message-ID: <CAAtXAHeAs02CKjb4z3RM29nzk58q_rN7f4GvdExSfd=vsLZQqQ@mail.gmail.com>
Subject: Re: [PATCH v2 06/16] fpga: region: remove unneeded of_node_get and put
To: Alan Tull <atull@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-fpga@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 20, 2017 at 7:09 AM, Alan Tull <atull@kernel.org> wrote:
> Remove of_node_get/put in fpga_region_get/put.  Not
> needed and will get in the way when I separate out
> the common FPGA region code from Device Tree support
> code.
>
> Signed-off-by: Alan Tull <atull@kernel.org>

Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
> v2: split out from another patch
> ---
>  drivers/fpga/fpga-region.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
> index eaea9d4..6784357 100644
> --- a/drivers/fpga/fpga-region.c
> +++ b/drivers/fpga/fpga-region.c
> @@ -94,9 +94,7 @@ static struct fpga_region *fpga_region_get(struct fpga_region *region)
>         }
>
>         get_device(dev);
> -       of_node_get(dev->of_node);
>         if (!try_module_get(dev->parent->driver->owner)) {
> -               of_node_put(dev->of_node);
>                 put_device(dev);
>                 mutex_unlock(&region->mutex);
>                 return ERR_PTR(-ENODEV);
> @@ -119,7 +117,6 @@ static void fpga_region_put(struct fpga_region *region)
>         dev_dbg(dev, "put\n");
>
>         module_put(dev->parent->driver->owner);
> -       of_node_put(dev->of_node);
>         put_device(dev);
>         mutex_unlock(&region->mutex);
>  }
> --
> 2.7.4
>