From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935659AbcJGCxe (ORCPT ); Thu, 6 Oct 2016 22:53:34 -0400 Received: from mail-vk0-f42.google.com ([209.85.213.42]:36511 "EHLO mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcJGCx0 (ORCPT ); Thu, 6 Oct 2016 22:53:26 -0400 MIME-Version: 1.0 In-Reply-To: <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> From: Moritz Fischer Date: Thu, 6 Oct 2016 19:53:25 -0700 Message-ID: Subject: Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document To: Joshua Clayton Cc: Alan Tull , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Devicetree List , Linux Kernel Mailing List , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joshua, On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton wrote: > Describe a cyclonespi devicetree entry, required features > > Signed-off-by: Joshua Clayton > --- > .../bindings/fpga/cyclone-spi-fpga-mgr.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > > diff --git a/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > new file mode 100644 > index 0000000..8de34db > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > @@ -0,0 +1,23 @@ > +Altera SOCFPGA FPGA Manager Copy & Paste? :) > +Altera cyclone FPGAs support a method of loading the bitstream over what is cyclone->Cyclone > +referred to as "passive serial". > +The passive serial link is not technically spi, and might require extra > +circuits in order to play nicely with other spi slaves on the same bus. > + > +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf > + > +Required properties: > +- compatible : should contain "altr,cyclonespi-fpga-mgr" Alan, do you guys have any input on the compat string? I think generally the bindings should go before the actual usage in your patch series. Meaning you wanna document the binding before you use it. I think this patch should be [1/3]. Cheers, Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Moritz Fischer Subject: Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document Date: Thu, 6 Oct 2016 19:53:25 -0700 Message-ID: References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joshua Clayton Cc: Alan Tull , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Devicetree List , Linux Kernel Mailing List , linux-arm-kernel List-Id: devicetree@vger.kernel.org Hi Joshua, On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton wrote: > Describe a cyclonespi devicetree entry, required features > > Signed-off-by: Joshua Clayton > --- > .../bindings/fpga/cyclone-spi-fpga-mgr.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > > diff --git a/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > new file mode 100644 > index 0000000..8de34db > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > @@ -0,0 +1,23 @@ > +Altera SOCFPGA FPGA Manager Copy & Paste? :) > +Altera cyclone FPGAs support a method of loading the bitstream over what is cyclone->Cyclone > +referred to as "passive serial". > +The passive serial link is not technically spi, and might require extra > +circuits in order to play nicely with other spi slaves on the same bus. > + > +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf > + > +Required properties: > +- compatible : should contain "altr,cyclonespi-fpga-mgr" Alan, do you guys have any input on the compat string? I think generally the bindings should go before the actual usage in your patch series. Meaning you wanna document the binding before you use it. I think this patch should be [1/3]. Cheers, Moritz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: moritz.fischer@ettus.com (Moritz Fischer) Date: Thu, 6 Oct 2016 19:53:25 -0700 Subject: [PATCH 2/3] doc: dt: add cyclone-spi binding document In-Reply-To: <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Joshua, On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton wrote: > Describe a cyclonespi devicetree entry, required features > > Signed-off-by: Joshua Clayton > --- > .../bindings/fpga/cyclone-spi-fpga-mgr.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > > diff --git a/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > new file mode 100644 > index 0000000..8de34db > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt > @@ -0,0 +1,23 @@ > +Altera SOCFPGA FPGA Manager Copy & Paste? :) > +Altera cyclone FPGAs support a method of loading the bitstream over what is cyclone->Cyclone > +referred to as "passive serial". > +The passive serial link is not technically spi, and might require extra > +circuits in order to play nicely with other spi slaves on the same bus. > + > +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf > + > +Required properties: > +- compatible : should contain "altr,cyclonespi-fpga-mgr" Alan, do you guys have any input on the compat string? I think generally the bindings should go before the actual usage in your patch series. Meaning you wanna document the binding before you use it. I think this patch should be [1/3]. Cheers, Moritz