From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932453AbcJGSnA (ORCPT ); Fri, 7 Oct 2016 14:43:00 -0400 Received: from mail-vk0-f44.google.com ([209.85.213.44]:35694 "EHLO mail-vk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932238AbcJGSmv (ORCPT ); Fri, 7 Oct 2016 14:42:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> From: Moritz Fischer Date: Fri, 7 Oct 2016 11:42:23 -0700 Message-ID: Subject: Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas To: atull Cc: Joshua Clayton , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Devicetree List , Linux Kernel Mailing List , linux-arm-kernel , julia@ni.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan, On Fri, Oct 7, 2016 at 11:21 AM, atull wrote: > Moritz, Can you remind me what that issue was there (or point me to > that email, I can't find it)? I don't think I had a problem with that > in your case. In general I think if these drivers can take the > bitstream that comes from the manufacturer's tools and stuff it into > the FPGA, then we are accomplishing what we want. So I am OK with > this here. The intent of the driver is to load a standard rbf, same > as the other Altera FPGA drivers. My first version of the zynq fpga manager had byte swapping in there and detection of which format was used. Greg even (accidentially) merged my initial code which I then cleaned up in 4d10eaff5bfc69997a769f9c83b749f0a8c542fa ("fpga: zynq-fpga: Change fw format to handle bin instead of bit.") to address the review comments. I do see your point about useability, and if this is something that keeps coming up we could pull that into the framework with a flag to SWAP or as part of the image_information struct. Thoughts? Cheers, Moritz [1] https://mail-archive.com/linux-kernel@vger.kernel.org/msg995245.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Moritz Fischer Subject: Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas Date: Fri, 7 Oct 2016 11:42:23 -0700 Message-ID: References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: atull Cc: Joshua Clayton , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Devicetree List , Linux Kernel Mailing List , linux-arm-kernel , julia-acOepvfBmUk@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Alan, On Fri, Oct 7, 2016 at 11:21 AM, atull wrote: > Moritz, Can you remind me what that issue was there (or point me to > that email, I can't find it)? I don't think I had a problem with that > in your case. In general I think if these drivers can take the > bitstream that comes from the manufacturer's tools and stuff it into > the FPGA, then we are accomplishing what we want. So I am OK with > this here. The intent of the driver is to load a standard rbf, same > as the other Altera FPGA drivers. My first version of the zynq fpga manager had byte swapping in there and detection of which format was used. Greg even (accidentially) merged my initial code which I then cleaned up in 4d10eaff5bfc69997a769f9c83b749f0a8c542fa ("fpga: zynq-fpga: Change fw format to handle bin instead of bit.") to address the review comments. I do see your point about useability, and if this is something that keeps coming up we could pull that into the framework with a flag to SWAP or as part of the image_information struct. Thoughts? Cheers, Moritz [1] https://mail-archive.com/linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg995245.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: moritz.fischer@ettus.com (Moritz Fischer) Date: Fri, 7 Oct 2016 11:42:23 -0700 Subject: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas In-Reply-To: References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Alan, On Fri, Oct 7, 2016 at 11:21 AM, atull wrote: > Moritz, Can you remind me what that issue was there (or point me to > that email, I can't find it)? I don't think I had a problem with that > in your case. In general I think if these drivers can take the > bitstream that comes from the manufacturer's tools and stuff it into > the FPGA, then we are accomplishing what we want. So I am OK with > this here. The intent of the driver is to load a standard rbf, same > as the other Altera FPGA drivers. My first version of the zynq fpga manager had byte swapping in there and detection of which format was used. Greg even (accidentially) merged my initial code which I then cleaned up in 4d10eaff5bfc69997a769f9c83b749f0a8c542fa ("fpga: zynq-fpga: Change fw format to handle bin instead of bit.") to address the review comments. I do see your point about useability, and if this is something that keeps coming up we could pull that into the framework with a flag to SWAP or as part of the image_information struct. Thoughts? Cheers, Moritz [1] https://mail-archive.com/linux-kernel at vger.kernel.org/msg995245.html