From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyqqe-0006z1-Qz for qemu-devel@nongnu.org; Wed, 31 Aug 2011 15:53:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qyqqd-0000s2-OR for qemu-devel@nongnu.org; Wed, 31 Aug 2011 15:53:20 -0400 Received: from mail-qw0-f47.google.com ([209.85.216.47]:39935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyqqd-0000ry-Kd for qemu-devel@nongnu.org; Wed, 31 Aug 2011 15:53:19 -0400 Received: by qwh5 with SMTP id 5so854957qwh.34 for ; Wed, 31 Aug 2011 12:53:19 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4E5E8A1D.6020103@codemonkey.ws> References: <4E5E3789.3010603@codemonkey.ws> <4E5E39DF.3080609@codemonkey.ws> <4E5E4540.5030408@codemonkey.ws> <4E5E5BF3.50801@codemonkey.ws> <20110831175934.GA17959@zapo> <4E5E8202.1040109@codemonkey.ws> <20110831191206.GD17959@zapo> <4E5E8A1D.6020103@codemonkey.ws> From: Blue Swirl Date: Wed, 31 Aug 2011 19:52:59 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "Edgar E. Iglesias" , qemu-devel@nongnu.org, bifferos On Wed, Aug 31, 2011 at 7:23 PM, Anthony Liguori wr= ote: > On 08/31/2011 02:12 PM, Edgar E. Iglesias wrote: >> >> On Wed, Aug 31, 2011 at 01:48:34PM -0500, Anthony Liguori wrote: >>>> >>>> etc, etc. IMO, those bring codingstyle issues into the pretty much >>>> neglectable space. >>> >>> I don't think we lack contributors. =C2=A0Documentation and tests are >>> really about discipline. =C2=A0If we can't even be bothered to maintain >>> consistency in variable naming, do you really expected that we can >>> be disciplined in writing documentation and tests? >> >> Yes I do. It's not white and black, it's not about making the code >> completely inconsistent or 100 consistent. It's about find a level >> of consistency that is acceptable and doesn't cost too much to >> maintain. > > I actually agree. =C2=A0I don't like the idea of absolutely enforcing a c= oding > style that demands no white space at the end of a line (if you can't see = it, > why in the world would you care?). Because then the patches for the line could be mangled by e-mail transport. Actually git apply.whitespace=3Dfix handles this nicely. > But coding style deviations that make the code look foreign, like using > CamelCase for field names, seems important to me. > > And I respect that other things seem important to other people (even > invisible things like trailing white space). =C2=A0So even though I would= n't want > to reject a patch because of coding style in some cases, I think it's > important that we do our best to enforce it. If the rules are enforced in some case but not in others, this is not fair on submitters.