From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Sm8VV-0006pr-Gu
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 15:11:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Sm8VP-0001V6-B2
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 15:11:29 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:55288)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Sm8VP-0001UX-4L
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 15:11:23 -0400
Received: by yenl1 with SMTP id l1so6112897yen.4
	for <qemu-devel@nongnu.org>; Tue, 03 Jul 2012 12:11:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAJSP0QVDDYdymD3Lk-VVmSS9uPQ5RVahT4=s-qDv8EF2JSjJgA@mail.gmail.com>
References: <1340984094-5451-1-git-send-email-armbru@redhat.com>
	<1340984094-5451-19-git-send-email-armbru@redhat.com>
	<20120702125515.GA16482@stefanha-thinkpad.localdomain>
	<4FF19D21.20005@suse.de> <m3wr2m5jwz.fsf@blackfin.pond.sub.org>
	<CAJSP0QVDDYdymD3Lk-VVmSS9uPQ5RVahT4=s-qDv8EF2JSjJgA@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Tue, 3 Jul 2012 19:11:01 +0000
Message-ID: <CAAu8pHs4ejBMTkaMGGPtcUuKVsRq_HGrMz9tEJj7JjR4BVt0dA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to
 match BlockConf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, pbonzini@redhat.com, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>

On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster <armbru@redhat.com> wro=
te:
>> Andreas F=C3=A4rber <afaerber@suse.de> writes:
>>
>>> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
>>>> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
>>>>> Best to use the same type, to avoid unwanted truncation or sign
>>>>> extension.
>>>>>
>>>>> BlockConf can't use plain int for cyls, heads and secs, because
>>>>> integer properties require an exact width.
>>>>>
>>>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>>>> ---
>>>>>  blockdev.h       |    2 +-
>>>>>  hw/hd-geometry.c |    4 ++--
>>>>>  hw/ide/core.c    |    2 +-
>>>>>  hw/scsi-disk.c   |    2 +-
>>>>>  hw/virtio-blk.c  |    2 +-
>>>>>  5 files changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> It would be nice to update the hd_geometry_lchs_guess() trace event th=
at
>>>> you added to use uint32_t + %u instead of int + %d.
>>>
>>> PRIu32?
>>
>> uint32_t: Good point, will do.
>>
>> Conversion specifier: trace-events routinely prints uint32_t with %d and
>> %x, never with PRI*32.  I'm happy to change from %d to %u, but reluctant
>> to add the first use of PRIu32.
>
> Either is fine by me although we might as well continue to do %u.

I'd also vote for %u. PRI*32 do not seem very useful compared to plain
int versions.

>
> Stefan
>