From mboxrd@z Thu Jan 1 00:00:00 1970 From: Blue Swirl Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Wed, 5 Sep 2012 19:09:42 +0000 Message-ID: References: <503C74DD.3020307@msgid.tls.msk.ru> <20120828172838.GD3661@redhat.com> <87fw76ak5l.fsf@codemonkey.ws> <878vcyrtlz.fsf@blackfin.pond.sub.org> <5044D75A.3000406@redhat.com> <5045BC96.5070806@redhat.com> <20120904212816.GE3602@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Avi Kivity , Markus Armbruster , Anthony Liguori , kvm@vger.kernel.org, Marcelo Tosatti , Michael Tokarev , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka To: "Michael S. Tsirkin" Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:56812 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753955Ab2IETKD (ORCPT ); Wed, 5 Sep 2012 15:10:03 -0400 Received: by ieje11 with SMTP id e11so1667713iej.19 for ; Wed, 05 Sep 2012 12:10:02 -0700 (PDT) In-Reply-To: <20120904212816.GE3602@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 4, 2012 at 9:28 PM, Michael S. Tsirkin wrote: > On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: >> > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >> >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: >> >>>> >> >>>> I don't see a point in making contributors avoid non-problems that might >> >>>> conceivably become trivial problems some day. Especially when there's >> >>>> no automated help with the avoiding. >> >>> >> >>> -Wpointer-arith >> >> >> >> +1 >> > >> > FWIW, I'm not in favour of enabling it, just pointing out that it >> > exists. In general I prefer avoiding unnecessary use of extensions, but >> > in this case the extension is trivial and improves readability. >> >> Void pointers are not so type safe as uint8_t pointers. > > casts are even worse. > >> There's also >> little difference in readability between those in my opinion. > > here too, casts are worse for readability. I agree they are bad in both accounts, but in most cases it is possible to use different types consistently (like uint8_t * or char * instead of void *) without adding casts. > >> > >> > >> > -- >> > error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9KzI-0000Rd-F7 for qemu-devel@nongnu.org; Wed, 05 Sep 2012 15:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9KzF-0005fy-O0 for qemu-devel@nongnu.org; Wed, 05 Sep 2012 15:10:08 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:63334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9KzF-0005ZB-IP for qemu-devel@nongnu.org; Wed, 05 Sep 2012 15:10:05 -0400 Received: by iakx26 with SMTP id x26so1059575iak.4 for ; Wed, 05 Sep 2012 12:10:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120904212816.GE3602@redhat.com> References: <503C74DD.3020307@msgid.tls.msk.ru> <20120828172838.GD3661@redhat.com> <87fw76ak5l.fsf@codemonkey.ws> <878vcyrtlz.fsf@blackfin.pond.sub.org> <5044D75A.3000406@redhat.com> <5045BC96.5070806@redhat.com> <20120904212816.GE3602@redhat.com> From: Blue Swirl Date: Wed, 5 Sep 2012 19:09:42 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, Marcelo Tosatti , Michael Tokarev , Markus Armbruster , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Avi Kivity , Anthony Liguori On Tue, Sep 4, 2012 at 9:28 PM, Michael S. Tsirkin wrote: > On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: >> > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >> >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: >> >>>> >> >>>> I don't see a point in making contributors avoid non-problems that might >> >>>> conceivably become trivial problems some day. Especially when there's >> >>>> no automated help with the avoiding. >> >>> >> >>> -Wpointer-arith >> >> >> >> +1 >> > >> > FWIW, I'm not in favour of enabling it, just pointing out that it >> > exists. In general I prefer avoiding unnecessary use of extensions, but >> > in this case the extension is trivial and improves readability. >> >> Void pointers are not so type safe as uint8_t pointers. > > casts are even worse. > >> There's also >> little difference in readability between those in my opinion. > > here too, casts are worse for readability. I agree they are bad in both accounts, but in most cases it is possible to use different types consistently (like uint8_t * or char * instead of void *) without adding casts. > >> > >> > >> > -- >> > error compiling committee.c: too many arguments to function