From mboxrd@z Thu Jan 1 00:00:00 1970 From: Blue Swirl Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Tue, 28 Aug 2012 17:01:55 +0000 Message-ID: References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503C74DD.3020307@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Jan Kiszka , Avi Kivity , Marcelo Tosatti , Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" To: Michael Tokarev Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:64941 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487Ab2H1RCQ (ORCPT ); Tue, 28 Aug 2012 13:02:16 -0400 Received: by ialo24 with SMTP id o24so11091580ial.19 for ; Tue, 28 Aug 2012 10:02:15 -0700 (PDT) In-Reply-To: <503C74DD.3020307@msgid.tls.msk.ru> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > On 27.08.2012 22:56, Blue Swirl wrote: > [] >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) >>> +{ >>> + AssignedDevRegion *d = opaque; >>> + uint8_t *in = d->u.r_virtbase + addr; >> >> Don't perform arithmetic with void pointers. > > There are a few places in common qemu code which does this for a very > long time. So I guess it is safe now. It's a non-standard GCC extension. > > /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PBJ-0007KO-S6 for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:02:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6PBA-0001Ja-G7 for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:02:25 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:38978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PBA-0001JW-A9 for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:02:16 -0400 Received: by iakx26 with SMTP id x26so10683410iak.4 for ; Tue, 28 Aug 2012 10:02:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <503C74DD.3020307@msgid.tls.msk.ru> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503C74DD.3020307@msgid.tls.msk.ru> From: Blue Swirl Date: Tue, 28 Aug 2012 17:01:55 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Avi Kivity On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > On 27.08.2012 22:56, Blue Swirl wrote: > [] >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) >>> +{ >>> + AssignedDevRegion *d = opaque; >>> + uint8_t *in = d->u.r_virtbase + addr; >> >> Don't perform arithmetic with void pointers. > > There are a few places in common qemu code which does this for a very > long time. So I guess it is safe now. It's a non-standard GCC extension. > > /mjt