From mboxrd@z Thu Jan 1 00:00:00 1970 From: Blue Swirl Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Sat, 8 Sep 2012 10:16:43 +0000 Message-ID: References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> <874nndmrjs.fsf@codemonkey.ws> <50476F3E.7000100@redhat.com> <87wr081nq4.fsf@codemonkey.ws> <50486270.9020504@redhat.com> <82563D1C-0B5E-432B-9CA1-68F72B122055@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Avi Kivity , "kvm@vger.kernel.org" , "Michael S. Tsirkin" , Marcelo Tosatti , "qemu-devel@nongnu.org" , Alex Williamson , Jan Kiszka , Anthony Liguori , qemu-ppc , =?UTF-8?Q?Andreas_F=C3=A4rber?= To: Alexander Graf Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:56930 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753215Ab2IHKRF (ORCPT ); Sat, 8 Sep 2012 06:17:05 -0400 Received: by ieje11 with SMTP id e11so480744iej.19 for ; Sat, 08 Sep 2012 03:17:04 -0700 (PDT) In-Reply-To: <82563D1C-0B5E-432B-9CA1-68F72B122055@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: > > > On 08.09.2012, at 10:06, Blue Swirl wrote: > >> On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: >>> On 09/05/2012 10:04 PM, Blue Swirl wrote: >>>> >>>> Reinventing a disassembler for ever growing x86 assembly is >>>> no fun. >>> >>> We can try linking to a disassembler library. I use udis86 to >>> disassemble instructions in kvm tracepoints >>> (http://udis86.git.sourceforge.net/git/gitweb.cgi?p=udis86/udis86;a=shortlog), >>> it's maintained but not heavily so. >> >> I think commonality with KVM would be preferred. The library looks >> neat and based on changelog, more actively developed than BSD DDB. >> >>> >>> Of course for non-x86 we'd need to continue using binutils; this is >>> about copying code vs. libraries, not about licensing. >> >> For most architectures, pre-GPLv3 binutils is good enough since the >> instruction set does not change anymore. Maybe only PPC and Sparc64 >> still change besides x86. New CPUs types more recent than 2007 will >> have problems. > > Alternatively we could try to run the disassembler in a different process, right? For qemu.log this would be doable and even improve performance since only binary data would be transferred. But for monitor disassembly command x/i it may be too clumsy. There's some overlap with GDB support, so maybe we could deprecate monitor disassembly. > > Alex > >> >>> >>> >>> -- >>> error compiling committee.c: too many arguments to function >> From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAI67-0001Ab-0E for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:17:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAI65-0006W5-SH for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:17:06 -0400 MIME-Version: 1.0 In-Reply-To: <82563D1C-0B5E-432B-9CA1-68F72B122055@suse.de> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> <874nndmrjs.fsf@codemonkey.ws> <50476F3E.7000100@redhat.com> <87wr081nq4.fsf@codemonkey.ws> <50486270.9020504@redhat.com> <82563D1C-0B5E-432B-9CA1-68F72B122055@suse.de> From: Blue Swirl Date: Sat, 8 Sep 2012 10:16:43 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "kvm@vger.kernel.org" , "Michael S. Tsirkin" , Marcelo Tosatti , "qemu-devel@nongnu.org" , Alex Williamson , Jan Kiszka , Avi Kivity , Anthony Liguori , qemu-ppc , =?UTF-8?Q?Andreas_F=C3=A4rber?= On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: > > > On 08.09.2012, at 10:06, Blue Swirl wrote: > >> On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: >>> On 09/05/2012 10:04 PM, Blue Swirl wrote: >>>> >>>> Reinventing a disassembler for ever growing x86 assembly is >>>> no fun. >>> >>> We can try linking to a disassembler library. I use udis86 to >>> disassemble instructions in kvm tracepoints >>> (http://udis86.git.sourceforge.net/git/gitweb.cgi?p=udis86/udis86;a=shortlog), >>> it's maintained but not heavily so. >> >> I think commonality with KVM would be preferred. The library looks >> neat and based on changelog, more actively developed than BSD DDB. >> >>> >>> Of course for non-x86 we'd need to continue using binutils; this is >>> about copying code vs. libraries, not about licensing. >> >> For most architectures, pre-GPLv3 binutils is good enough since the >> instruction set does not change anymore. Maybe only PPC and Sparc64 >> still change besides x86. New CPUs types more recent than 2007 will >> have problems. > > Alternatively we could try to run the disassembler in a different process, right? For qemu.log this would be doable and even improve performance since only binary data would be transferred. But for monitor disassembly command x/i it may be too clumsy. There's some overlap with GDB support, so maybe we could deprecate monitor disassembly. > > Alex > >> >>> >>> >>> -- >>> error compiling committee.c: too many arguments to function >>